Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] test-main.js needs an unhandled exception handler #73330

Closed
radical opened this issue Aug 3, 2022 · 3 comments · Fixed by #74751
Closed

[wasm] test-main.js needs an unhandled exception handler #73330

radical opened this issue Aug 3, 2022 · 3 comments · Fixed by #74751
Assignees
Labels
arch-wasm WebAssembly architecture area-VM-meta-mono test-enhancement Improvements of test source code
Milestone

Comments

@radical
Copy link
Member

radical commented Aug 3, 2022

When running tests with xharness on browser, we are not able to get the traces for uncaught exceptions. A handler for that can print the trace which can be usable by anyone looking at test logs.

[11:20:03] info: Starting:    System.Runtime.Tests.dll
[11:21:00] fail: [out of order message from the browser]: http://127.0.0.1:49197/dotnet.js 1880:6 Uncaught
[11:21:00] fail: [out of order message from the browser]: http://127.0.0.1:49197/dotnet.js 1880:6 Uncaught
[11:21:00] fail: [out of order message from the browser]: http://127.0.0.1:49197/dotnet.js 1880:6 Uncaught
[11:34:33] fail: Tests timed out. Killing driver service pid 7840
[11:34:33] fail: Application has finished with exit code TIMED_OUT but 0 was expected

Also, note the timings above. xharness continues to wait for 13mins after the uncaught exception, because the app did not signal that it had crashed.

@radical radical added arch-wasm WebAssembly architecture test-enhancement Improvements of test source code area-VM-meta-mono labels Aug 3, 2022
@radical radical added this to the 7.0.0 milestone Aug 3, 2022
@ghost
Copy link

ghost commented Aug 3, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

When running tests with xharness on browser, we are not able to get the traces for uncaught exceptions. A handler for that can print the trace which can be usable by anyone looking at test logs.

[11:20:03] info: Starting:    System.Runtime.Tests.dll
[11:21:00] fail: [out of order message from the browser]: http://127.0.0.1:49197/dotnet.js 1880:6 Uncaught
[11:21:00] fail: [out of order message from the browser]: http://127.0.0.1:49197/dotnet.js 1880:6 Uncaught
[11:21:00] fail: [out of order message from the browser]: http://127.0.0.1:49197/dotnet.js 1880:6 Uncaught
[11:34:33] fail: Tests timed out. Killing driver service pid 7840
[11:34:33] fail: Application has finished with exit code TIMED_OUT but 0 was expected

Also, note the timings above. xharness continues to wait for 13mins after the uncaught exception, because the app did not signal that it had crashed.

Author: radical
Assignees: pavelsavara
Labels:

arch-wasm, test-enhancement, area-VM-meta-mono

Milestone: 7.0.0

@pavelsavara
Copy link
Member

Should xharness kill the test on any unhanded exception ?

@radical
Copy link
Member Author

radical commented Aug 29, 2022

The runtime should print the details for the error, and then exit, which would trigger xharness to kill the browser process.

@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Aug 29, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Aug 30, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Sep 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-VM-meta-mono test-enhancement Improvements of test source code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants