Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mono] Re-enable passing Vector128 arguments in SIMD registers #74583

Closed
Tracked by #43051
lambdageek opened this issue Aug 25, 2022 · 3 comments · Fixed by #86634
Closed
Tracked by #43051

[mono] Re-enable passing Vector128 arguments in SIMD registers #74583

lambdageek opened this issue Aug 25, 2022 · 3 comments · Fixed by #86634
Assignees
@fanyang-mono
Labels
area-Codegen-JIT-mono
Milestone
8.0.0

Comments

@lambdageek
Copy link
Member

Due to mixing LLVM and non-LLVM code (see #73454) we disabled the work done for #68991 to pass arguments in SIMD registers. Once the JIT (and interp?) can also use the SIMD registers, we should re-enable that code.

#74582
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Aug 25, 2022
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Aug 25, 2022
@ghost
Copy link

ghost commented Aug 25, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Due to mixing LLVM and non-LLVM code (see #73454) we disabled the work done for #68991 to pass arguments in SIMD registers. Once the JIT (and interp?) can also use the SIMD registers, we should re-enable that code.

#74582

Author: lambdageek
Assignees: -
Labels:

area-CodeGen-coreclr, untriaged
Milestone: -

@lambdageek lambdageek added area-Codegen-meta-mono and removed area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI untriaged New issue has not been triaged by the area owner labels Aug 25, 2022
@lambdageek lambdageek added this to the 8.0.0 milestone Aug 25, 2022
@lambdageek
Copy link
Member Author

/cc @vargaz @fanyang-mono @SamMonoRT

@SamMonoRT
Copy link
Member

Assigning to @fanyang-mono for tracking and consolidating related issues for 8.0.0

@fanyang-mono fanyang-mono mentioned this issue Sep 26, 2022
Open
58 tasks
@fanyang-mono fanyang-mono changed the title [mono] Re-enable passing arguments in SIMD registers [mono] Re-enable passing Vector128 arguments in SIMD registers Jan 30, 2023
@fanyang-mono fanyang-mono mentioned this issue May 23, 2023
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label May 23, 2023
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label May 25, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jun 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@fanyang-mono fanyang-mono

Labels
area-Codegen-JIT-mono
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

[Mono] Pass SIMD type variables using SIMD registers fanyang-mono/runtime
3 participants
@lambdageek @SamMonoRT @fanyang-mono