Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate changes in Buffer.MemCopy to bring into Span.Clear #7478

Closed
ahsonkhan opened this issue Feb 21, 2017 · 6 comments
Closed

Investigate changes in Buffer.MemCopy to bring into Span.Clear #7478

ahsonkhan opened this issue Feb 21, 2017 · 6 comments
Labels
area-System.Memory enhancement Product code improvement that does NOT require public API changes/additions help wanted [up-for-grabs] Good issue for external contributors tenet-performance Performance related issue
Milestone
Future

Comments

@ahsonkhan
Copy link
Contributor

From PR dotnet/coreclr#9598

dotnet/coreclr#9598 (comment)

I see you copied some of the code from Buffer.MemoryCopy... you may want to take a look at dotnet/coreclr#9143 for the managed part of the implementation. It should be more efficient especially on AMD64 because it writes things out in 16/32/64-byte blocks and does not have the extra branches at the beginning/end to check for alignment. (For lengths >= 512/1024 it is probably better to stick to the native implementation.)
@ahsonkhan ahsonkhan changed the title Investigate changes from Buffer.MemCopy to bring into Span.Clear Investigate changes in Buffer.MemCopy to bring into Span.Clear Feb 21, 2017
@hanblee
Copy link
Contributor

hanblee commented Feb 28, 2017

dotnet/coreclr#9143 has been superseded by dotnet/coreclr#9786

@ahsonkhan ahsonkhan removed their assignment Apr 11, 2017
@gkhanna79
Copy link
Member

@joshfree @ahsonkhan Is this still on for .NET Core 2.0?

@ahsonkhan
Copy link
Contributor Author

No, this can wait till 2.1.

@ahsonkhan
Copy link
Contributor Author

cc @GrabYourPitchforks

@GrabYourPitchforks
Copy link
Member

Not sure what's being requested here. Span.Clear doesn't have alignment requirements and has already gone through an optimization pass.

@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@msftgits msftgits added this to the Future milestone Jan 31, 2020
@stephentoub
Copy link
Member

Closing per @GrabYourPitchforks' comment.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.Memory enhancement Product code improvement that does NOT require public API changes/additions help wanted [up-for-grabs] Good issue for external contributors tenet-performance Performance related issue
Projects
None yet
Milestone
Future
Development

No branches or pull requests
6 participants
@GrabYourPitchforks @stephentoub @ahsonkhan @msftgits @gkhanna79 @hanblee