Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage for TLS resume #75545

Closed
wfurt opened this issue Sep 13, 2022 · 3 comments
Closed

Improve test coverage for TLS resume #75545

wfurt opened this issue Sep 13, 2022 · 3 comments
Labels
area-System.Net.Security test-enhancement Improvements of test source code
Milestone

Comments

@wfurt
Copy link
Member

wfurt commented Sep 13, 2022

fix for #75079 did not have test as I was unable to construct one.
But in general, most tests do verify given behavior once but that may not be sufficient.
The behavior may change because of

  • session cache (primarily windows)
  • TLS resume (primarily Linux)

we should add test for #75079 as well as improve test coverage in general.

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Sep 13, 2022
@ghost
Copy link

ghost commented Sep 13, 2022

Tagging subscribers to this area: @dotnet/ncl, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

fix for #75079 did not have test as I was unable to construct one.
But in general, most tests do verify given behavior once but that may not be sufficient.
The behavior may change because of

  • session cache (primarily windows)
  • TLS resume (primarily Linux)

we should add test for #75079 as well as improve test coverage in general.

Author: wfurt
Assignees: -
Labels:

area-System.Net.Security

Milestone: -

@wfurt wfurt added the test-enhancement Improvements of test source code label Sep 13, 2022
@karelz karelz added this to the 8.0.0 milestone Sep 13, 2022
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Sep 13, 2022
@liveans liveans self-assigned this Oct 18, 2022
@liveans liveans removed their assignment Dec 2, 2022
@wfurt wfurt self-assigned this Dec 29, 2022
@karelz karelz modified the milestones: 8.0.0, Future Jun 9, 2023
@karelz karelz unassigned wfurt Jun 9, 2023
@karelz karelz modified the milestones: Future, 9.0.0 Jul 18, 2023
@rzikm
Copy link
Member

rzikm commented Oct 24, 2023

Triage:

  • Look at the coverage we already have and see if something is missing
  • consider adding tests that check if a session was actually resumed, there is a Debug-only property which we can check via Reflection.

@rzikm rzikm self-assigned this Nov 16, 2023
@rzikm
Copy link
Member

rzikm commented Nov 27, 2023

Test covering #75079 was added as part of #79898, since then, multiple other changes have explicitly added checks with TLS resume as well, e.g. #86047. I don't think there are any missing tests at this point.

@rzikm rzikm closed this as completed Nov 27, 2023
@rzikm rzikm removed their assignment Nov 27, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Net.Security test-enhancement Improvements of test source code
Projects
None yet
Development

No branches or pull requests

4 participants