-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] Perf regression of Span.IndexOf #75709
Labels
area-Codegen-AOT-mono
blocking-release
tenet-performance
Performance related issue
tenet-performance-benchmarks
Issue from performance benchmark
Milestone
Comments
I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label. |
radekdoulik
added
area-Codegen-AOT-mono
and removed
untriaged
New issue has not been triaged by the area owner
labels
Sep 15, 2022
discussion happening at #74395 |
One possible cause: |
2 tasks
ghost
added
the
in-pr
There is an active PR which will close this issue when it is merged
label
Sep 20, 2022
jeffhandley
added
blocking-release
tenet-performance
Performance related issue
tenet-performance-benchmarks
Issue from performance benchmark
labels
Sep 20, 2022
ghost
removed
the
in-pr
There is an active PR which will close this issue when it is merged
label
Sep 22, 2022
Reopening to track 7.0 fix |
Closing as the 7.0 fix was merged |
ghost
locked as resolved and limited conversation to collaborators
Oct 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-Codegen-AOT-mono
blocking-release
tenet-performance
Performance related issue
tenet-performance-benchmarks
Issue from performance benchmark
The performance of
Span
'sIndexOf
got worse with #73768 on wasm.Visible in dotnet/perf-autofiling-issues#7981, dotnet/perf-autofiling-issues#7976 and here:
I think what is happening is that after the change we end up calling a shared generic method in the span helper, instead of an inflated one.
Stack trace before:
after:
The text was updated successfully, but these errors were encountered: