[WASM] Check if we can still skip GC critical method check in WASM

[naricc]

There is an ifdef here to skip the critical method check in wasm:

runtime/src/mono/mono/metadata/sgen-mono.c

Line 237 in 77bf509

#ifdef HOST_WASM

.

Its not clear if this can still be safely skipped when wasm is multithreaded. Wasm uses co-op suspend, so if the managed code has no GC safepoints, this should still be ok. If it does have safepoints, the runtime might need to do the critical method check.

If we are able to safely skip it, the comment should be updated to say it can be skipped because of co-op suspend and the lack of safepoints (rather than single threadedness).

[ghost]

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

---

There is an ifdef here to skip the critical method check in wasm:

runtime/src/mono/mono/metadata/sgen-mono.c

Line 237 in 77bf509

#ifdef HOST_WASM

.

Its not clear if this can still be safely skipped when wasm is multithreaded. Wasm uses co-op suspend, so if the managed code has no GC safepoints, this should still be ok. If it does have safepoints, the runtime might need to do the critical method check.

If we are able to safely skip it, the comment should be updated to say it can be skipped because of co-op suspend and the lack of safepoints (rather than single threadedness).

Author:	naricc
Assignees:	-
Labels:	arch-wasm, area-GC-mono
Milestone:	8.0.0

[lewing]

cc @pavelsavara