Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regressions in System.Text.Json.Serialization.Tests.ColdStartSerialization<SimpleStructWithProperties> #77279

Closed
performanceautofiler bot opened this issue Oct 20, 2022 · 4 comments
Labels
area-System.Text.Json tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark

Comments

@performanceautofiler
Copy link

Run Information

Architecture arm64
OS Windows 10.0.19041
Baseline 59f14ac45408d557bd6b423e7a9c175adc85e125
Compare 8393c4eb74afecaa70267b2a94b9b94c1d1ae384
Diff Diff

Regressions in System.Text.Json.Serialization.Tests.ColdStartSerialization<SimpleStructWithProperties>

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
NewDefaultOptions - Duration of single invocation 1.27 μs 1.48 μs 1.16 0.07 False

graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'System.Text.Json.Serialization.Tests.ColdStartSerialization&lt;SimpleStructWithProperties&gt;*'

Related Issues

Regressions

Improvements

Payloads

Baseline
Compare

Histogram

Edge Detector Info

Collection Data

System.Text.Json.Serialization.Tests.ColdStartSerialization<SimpleStructWithProperties>.NewDefaultOptions


Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionWindowed: Marked as regression because we could not find enough baseline builds for window checking.
IsChangePoint: Marked as a change because one of 8/5/2022 12:58:40 PM, 10/6/2022 12:41:43 AM, 10/17/2022 3:19:47 PM, 10/19/2022 4:51:05 PM falls between 10/10/2022 11:56:05 PM and 10/19/2022 4:51:05 PM.
IsRegressionStdDev: Marked as regression because -8.340742740855228 (T) = (0 -1465.5622377774455) / Math.Sqrt((690.7713871981738 / (26)) + (2855.6693825126813 / (6))) is less than -2.0422724562973107 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (26) + (6) - 2, .025) and -0.1462336330881648 = (1278.5894563475254 - 1465.5622377774455) / 1278.5894563475254 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

@performanceautofiler performanceautofiler bot added arm64 untriaged New issue has not been triaged by the area owner labels Oct 20, 2022
@EgorBo EgorBo changed the title [Perf] Windows/arm64: 1 Regression on 10/17/2022 8:10:07 PM Regressions in System.Text.Json.Serialization.Tests.ColdStartSerialization<SimpleStructWithProperties> Oct 20, 2022
@EgorBo EgorBo removed refs/heads/main untriaged New issue has not been triaged by the area owner labels Oct 20, 2022
@EgorBo EgorBo transferred this issue from dotnet/perf-autofiling-issues Oct 20, 2022
@EgorBo
Copy link
Member

EgorBo commented Oct 20, 2022

Likely caused by #76782 cc @eiriktsarpalis

@EgorBo EgorBo added tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark labels Oct 20, 2022
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Oct 20, 2022
@ghost
Copy link

ghost commented Oct 20, 2022

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

Run Information

Architecture arm64
OS Windows 10.0.19041
Baseline 59f14ac45408d557bd6b423e7a9c175adc85e125
Compare 8393c4eb74afecaa70267b2a94b9b94c1d1ae384
Diff Diff

Regressions in System.Text.Json.Serialization.Tests.ColdStartSerialization<SimpleStructWithProperties>

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
NewDefaultOptions - Duration of single invocation 1.27 μs 1.48 μs 1.16 0.07 False

graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'System.Text.Json.Serialization.Tests.ColdStartSerialization&lt;SimpleStructWithProperties&gt;*'

Related Issues

Regressions

Improvements

Payloads

Baseline
Compare

Histogram

Edge Detector Info

Collection Data

System.Text.Json.Serialization.Tests.ColdStartSerialization<SimpleStructWithProperties>.NewDefaultOptions


Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionWindowed: Marked as regression because we could not find enough baseline builds for window checking.
IsChangePoint: Marked as a change because one of 8/5/2022 12:58:40 PM, 10/6/2022 12:41:43 AM, 10/17/2022 3:19:47 PM, 10/19/2022 4:51:05 PM falls between 10/10/2022 11:56:05 PM and 10/19/2022 4:51:05 PM.
IsRegressionStdDev: Marked as regression because -8.340742740855228 (T) = (0 -1465.5622377774455) / Math.Sqrt((690.7713871981738 / (26)) + (2855.6693825126813 / (6))) is less than -2.0422724562973107 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (26) + (6) - 2, .025) and -0.1462336330881648 = (1278.5894563475254 - 1465.5622377774455) / 1278.5894563475254 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Author: performanceautofiler[bot]
Assignees: -
Labels:

area-System.Text.Json

Milestone: -

@EgorBo
Copy link
Member

EgorBo commented Oct 20, 2022

Likely related regression: dotnet/perf-autofiling-issues#9075

@eiriktsarpalis
Copy link
Member

This is expected -- the change in #76782 intentionally regresses performance for that particular benchmark in favor of other scenaria, cf. #76782 (comment).

@ghost ghost locked as resolved and limited conversation to collaborators Nov 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Text.Json tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark
Projects
None yet
Development

No branches or pull requests

2 participants