Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test failure] System.Net.Http.Functional.Tests.PlatformHandler_HttpClientHandler_ServerCertificates_Test.NoCallback_RevokedCertificate_NoRevocationChecking_Succeeds #77726

Closed
runfoapp bot opened this issue Nov 1, 2022 · 12 comments · Fixed by #105793
Closed

[Test failure] System.Net.Http.Functional.Tests.PlatformHandler_HttpClientHandler_ServerCertificates_Test.NoCallback_RevokedCertificate_NoRevocationChecking_Succeeds #77726

runfoapp bot opened this issue Nov 1, 2022 · 12 comments · Fixed by #105793
Assignees
@wfurt
Labels
area-System.Net.Http disabled-test The test is disabled in source code against the issue in-pr There is an active PR which will close this issue when it is merged test-bug Problem in test source code (most likely) test-run-core Test failures in .NET Core test runs
Milestone
9.0.0

Comments

@runfoapp
Copy link

runfoapp bot commented Nov 1, 2022 •
edited
Loading

Runfo Tracking Issue: [Test failure] NoCallback_RevokedCertificate_NoRevocationChecking_Succeeds

Build Definition Kind Run Name

Build Result Summary

Day Hit Count Week Hit Count Month Hit Count
0 0 0
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Nov 1, 2022
@ghost
Copy link

ghost commented Nov 1, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Runfo Tracking Issue: [Test failure] NoCallback_RevokedCertificate_NoRevocationChecking_Succeeds

Build Definition Kind Run Name Console Core Dump Test Results Run Client
69118 runtime-libraries-coreclr outerloop Rolling net48-windows-Release-x64-Windows.11.Amd64.Client.Open console.log runclient.py
69118 runtime-libraries-coreclr outerloop Rolling net48-windows-Release-x86-Windows.10.Amd64.Client21H1.Open console.log runclient.py
69115 runtime-libraries-coreclr outerloop-windows Rolling net48-windows-Release-x86-Windows.10.Amd64.Client21H1.Open console.log runclient.py
69115 runtime-libraries-coreclr outerloop-windows Rolling net48-windows-Release-x64-Windows.11.Amd64.Client.Open console.log runclient.py
69113 runtime-libraries-coreclr outerloop Rolling net48-windows-Release-x86-Windows.10.Amd64.Client21H1.Open console.log runclient.py
69113 runtime-libraries-coreclr outerloop Rolling net48-windows-Release-x64-Windows.11.Amd64.Client.Open console.log runclient.py
69111 runtime-libraries-coreclr outerloop-windows Rolling net48-windows-Release-x64-Windows.11.Amd64.Client.Open console.log runclient.py
69111 runtime-libraries-coreclr outerloop-windows Rolling net48-windows-Release-x86-Windows.10.Amd64.Client21H1.Open console.log runclient.py
67858 runtime-libraries-coreclr outerloop Rolling net48-windows-Release-x64-Windows.11.Amd64.Client.Open console.log runclient.py
67858 runtime-libraries-coreclr outerloop Rolling net48-windows-Release-x86-Windows.10.Amd64.Client21H1.Open console.log runclient.py
67854 runtime-libraries-coreclr outerloop Rolling net48-windows-Release-x86-Windows.10.Amd64.Client21H1.Open console.log runclient.py
67854 runtime-libraries-coreclr outerloop Rolling net48-windows-Release-x64-Windows.11.Amd64.Client.Open console.log runclient.py
67853 runtime-libraries-coreclr outerloop-windows Rolling net48-windows-Release-x64-Windows.11.Amd64.Client.Open console.log runclient.py
67853 runtime-libraries-coreclr outerloop-windows Rolling net48-windows-Release-x86-Windows.10.Amd64.Client21H1.Open console.log runclient.py
67850 runtime-libraries-coreclr outerloop-windows Rolling net48-windows-Release-x86-Windows.10.Amd64.Client21H1.Open console.log runclient.py
67850 runtime-libraries-coreclr outerloop-windows Rolling net48-windows-Release-x64-Windows.11.Amd64.Client.Open console.log runclient.py

Build Result Summary

Day Hit Count Week Hit Count Month Hit Count
4 8 8
Author: runfoapp[bot]
Assignees: -
Labels:

area-System.Net.Http, untriaged
Milestone: -

@rzikm rzikm changed the title [Test failure] NoCallback_RevokedCertificate_NoRevocationChecking_Succeeds [Test failure] System.Net.Http.Functional.Tests.PlatformHandler_HttpClientHandler_ServerCertificates_Test.NoCallback_RevokedCertificate_NoRevocationChecking_Succeeds Nov 1, 2022
@ManickaP
Copy link
Member

ManickaP commented Nov 1, 2022

Based on the console log, the error is this:

System.Net.Http.Functional.Tests.PlatformHandler_HttpClientHandler_ServerCertificates_Test.NoCallback_RevokedCertificate_NoRevocationChecking_Succeeds [FAIL]
      System.Net.Http.HttpRequestException : An error occurred while sending the request.
      ---- System.Net.Http.WinHttpException : Error 12175 calling WINHTTP_CALLBACK_STATUS_REQUEST_ERROR, 'A security error occurred'.
      Stack Trace:
           at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
           at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
        /_/src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.ServerCertificates.cs(234,0): at System.Net.Http.Functional.Tests.HttpClientHandler_ServerCertificates_Test.<NoCallback_RevokedCertificate_NoRevocationChecking_Succeeds>d__19.MoveNext()
        --- End of stack trace from previous location where exception was thrown ---
           at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
           at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
        --- End of stack trace from previous location where exception was thrown ---
           at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
           at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
        --- End of stack trace from previous location where exception was thrown ---
           at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
           at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
        ----- Inner Stack Trace -----
           at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
        /_/src/libraries/Common/src/System/Threading/Tasks/RendezvousAwaitable.cs(64,0): at System.Threading.Tasks.RendezvousAwaitable`1.GetResult()
        /_/src/libraries/System.Net.Http.WinHttpHandler/src/System/Net/Http/WinHttpHandler.cs(946,0): at System.Net.Http.WinHttpHandler.<StartRequestAsync>d__122.MoveNext()

Docs for 12175 ERROR_WINHTTP_SECURE_FAILURE: One or more errors were found in the Secure Sockets Layer (SSL) certificate sent by the server. To determine what type of error was encountered, check for a WINHTTP_CALLBACK_STATUS_SECURE_FAILURE notification in a status callback function. For more information, see WINHTTP_STATUS_CALLBACK.

Seems like cert problem, can it be expired? And if I get the description right, does it mean there are more details about the error available? If so, would it be worthwhile to retrieve them?
cc @wfurt @rzikm

@wfurt
Copy link
Member

wfurt commented Nov 1, 2022

We should try to reproduce it. If it is expired certificate it will show up consistently.

@ManickaP ManickaP added this to the 8.0.0 milestone Nov 1, 2022
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Nov 1, 2022
@ManickaP
Copy link
Member

ManickaP commented Nov 1, 2022

Triage: needs to be tested locally if it's a cert problem (should be easily reproducible). If so, we should promptly fix this or disable the test.

@wfurt
Copy link
Member

wfurt commented Nov 1, 2022

The test is using https://revoked.badssl.com/ and it expired 10/27. Since this is outer loop test we may ignore it for few more days. The badssl.com usually fix their certs eventually.
It is still shown as revoked so we may alternatively fix the validation tests to ignore expiration and only check revocation.
But I'm not sure if it is worth of the troubles.
Last option IMHO is to remove dependency on badssl.com and host our own sites.

@wfurt
Copy link
Member

wfurt commented Nov 1, 2022

BTW this is easy to reproduce and SocketsHttpHandler fails as well

@rzikm rzikm self-assigned this Nov 2, 2022
@rzikm
Copy link
Member

rzikm commented Nov 2, 2022

badssl issue: chromium/badssl.com#515

@MihaZupan MihaZupan mentioned this issue Nov 4, 2022
Merged
@rzikm rzikm mentioned this issue Dec 8, 2022
Merged
@ManickaP ManickaP added the disabled-test The test is disabled in source code against the issue label Jan 31, 2023
@karelz
Copy link
Member

karelz commented Jan 31, 2023

Test disabled in PR #79407

@karelz karelz added the test-bug Problem in test source code (most likely) label Jan 31, 2023
@ManickaP
Copy link
Member

ManickaP commented Jan 31, 2023 •
edited
Loading

Triage: we can either wait until chromium/badssl.com#515 if fixed or change our logic around certificates and ignore the expiration.

@ManickaP ManickaP modified the milestones: 8.0.0, Future Jan 31, 2023
@wfurt wfurt self-assigned this Mar 8, 2023
@wfurt wfurt mentioned this issue Mar 8, 2023
Closed
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Mar 8, 2023
@ghost ghost added in-pr There is an active PR which will close this issue when it is merged and removed in-pr There is an active PR which will close this issue when it is merged labels Apr 28, 2023
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label May 28, 2023
@wfurt wfurt modified the milestones: 8.0.0, Future Jun 7, 2023
@rzikm rzikm removed their assignment Jul 20, 2023
@karelz karelz added the test-run-core Test failures in .NET Core test runs label Sep 21, 2023
@rzikm rzikm mentioned this issue Jan 4, 2024
Closed
@rzikm
Copy link
Member

rzikm commented Jan 4, 2024

We should also disable the tests in 7.0 and 6.0 to clean up CI there.

@karelz
Copy link
Member

karelz commented Jun 24, 2024

Tests were disabled in main (8.0) in PR #79407 and in 7.0.x in PR #96053 and in 6.0.x in PR #96055

@rzikm rzikm mentioned this issue Aug 1, 2024
Merged
@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Aug 1, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 1, 2024
@karelz karelz modified the milestones: Future, 9.0.0 Sep 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@wfurt wfurt

Labels
area-System.Net.Http disabled-test The test is disabled in source code against the issue in-pr There is an active PR which will close this issue when it is merged test-bug Problem in test source code (most likely) test-run-core Test failures in .NET Core test runs
Projects
None yet
Milestone
9.0.0
4 participants
@karelz @ManickaP @wfurt @rzikm