Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for MSBuild tasks in src/tasks #79010

Closed
radical opened this issue Nov 30, 2022 · 2 comments
Closed

Add tests for MSBuild tasks in src/tasks #79010

radical opened this issue Nov 30, 2022 · 2 comments
Labels
area-Build-mono test-enhancement Improvements of test source code
Milestone

Comments

@radical
Copy link
Member

radical commented Nov 30, 2022

Currently, there are no unit tests for the msbuild tasks in src/tasks. For wasm, there are some limited tests for PInvokeTableGenerator in src/mono/wasm/Wasm.Build.Tests, but these perform full builds which are not always necessary.

Instead, the msbuild tasks should have their own unit tests in src/tests which can be targeted, and much lighter to run.

Examples for tests to add:

This should be applicable for mobile tasks too.

cc @maraf @ilonatommy @lewing @steveisok

@radical radical added test-enhancement Improvements of test source code area-Build-mono labels Nov 30, 2022
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Nov 30, 2022
@radical
Copy link
Member Author

radical commented Nov 30, 2022

@maraf did we have an existing issue for this?

@maraf
Copy link
Member

maraf commented Nov 30, 2022

@maraf did we have an existing issue for this?

I don't know of any

@radical radical added this to the 8.0.0 milestone Nov 30, 2022
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Nov 30, 2022
@steveisok steveisok modified the milestones: 8.0.0, 9.0.0 Aug 8, 2023
@lewing lewing closed this as completed Jul 29, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Build-mono test-enhancement Improvements of test source code
Projects
None yet
Development

No branches or pull requests

4 participants