Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono][perf] Master issue for WASM disk size regressions #79288

Open
kotlarmilos opened this issue Dec 6, 2022 · 3 comments
Open

[mono][perf] Master issue for WASM disk size regressions #79288

kotlarmilos opened this issue Dec 6, 2022 · 3 comments
Assignees
Labels
arch-wasm WebAssembly architecture area-VM-meta-mono size-reduction Issues impacting final app size primary for size sensitive workloads tenet-performance Performance related issue tracking This issue is tracking the completion of other related issues.
Milestone

Comments

@kotlarmilos
Copy link
Member

kotlarmilos commented Dec 6, 2022

Description

Disk size (SOD) regressions detected in Mono Blazorwasm.

Details - Mono

Date Diff Change Size increase (bytes) Size increase (%) Tracking issue
15 Nov 2022 3cfd6cf...ce58915 ce58915 18588 0.87 #79598
21 Nov 2022 8171bd0...aa91451 aa91451 15002 0.70 #79599
06 Dec 2022 b399eed...fcf0a09 62f3eb2 11042 0.51 #79285
04 Jan 2023 b399eed...fcf0a09 65376 3.03 #80737

Screenshot 2023-01-17 at 15 31 14


Details - Mono AOT

Date Diff Change Size increase (bytes) Size increase (%) Tracking issue
11 Nov 2022 2b1f57e...3e94fdc 486682a 72114 1.86 #78851
15 Nov 2022 3cfd6cf...ce58915 ce58915 24418 0.62 #79598
21 Nov 2022 8171bd0...dd0ec94 aa91451 87278 2.20 #79599
06 Dec 2022 b399eed...fcf0a09 62f3eb2 414367 9.48 #79285
04 Jan 2023 b399eed...fcf0a09 459520 10.93 #80737
01 Mar 2023 340508f...0a15c3b cdd71fe 101487 2.71 #84065

Screenshot 2023-01-17 at 15 31 26

cc @SamMonoRT @lewing

Configuration

OS: Ubuntu 18.04
Architecture: x64
.NET version: 7.0.100-rc.1.22431.12

@kotlarmilos kotlarmilos added the tenet-performance Performance related issue label Dec 6, 2022
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Dec 6, 2022
@SamMonoRT SamMonoRT added this to the 8.0.0 milestone Dec 7, 2022
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Dec 7, 2022
@SamMonoRT SamMonoRT added arch-wasm WebAssembly architecture size-reduction Issues impacting final app size primary for size sensitive workloads labels Dec 8, 2022
@ghost
Copy link

ghost commented Dec 8, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Description

Several regressions disk size regressions (SOD) in Mono Blazorwasm detected. Binary disk size (SOD) for Mono Blazorwasm sample has been cumulatively increased by 6%.

Details

Changes SOD in bytes
2b1f57e 2909028
005e280 3010613
ce58915 3037025
aa91451 cce374c 0b3f44e ae70706 3094443

@radekdoulik could you confirm that 005e280 caused a regression in 2b1f57e...3e94fdc?

cc @SamMonoRT @lewing

Configuration

OS: iOS/OSX
Architecture: arm64
.NET version: 7.0.100-rc.1.22431.12

Author: kotlarmilos
Assignees: -
Labels:

arch-wasm, tenet-performance, area-VM-meta-mono, size-reduction

Milestone: 8.0.0

@SamMonoRT
Copy link
Member

@radekdoulik @gfoidl - can we confirm if 005e280 in indeed causing size regressions in WASM too -- also have we seen any auto-filled issues for this already and can track it in that issue ?

@kotlarmilos
Copy link
Member Author

I checked it on a blazorwasm app and confirm that 005e280 didn't cause the regression.

@kotlarmilos kotlarmilos reopened this Dec 9, 2022
@kotlarmilos kotlarmilos changed the title Mono WASM disk size regressions [mono][perf] Master issue for WASM disk size regressions Dec 13, 2022
@kotlarmilos kotlarmilos added the tracking This issue is tracking the completion of other related issues. label Dec 13, 2022
@kotlarmilos kotlarmilos modified the milestones: 8.0.0, 9.0.0 Jul 13, 2023
@kotlarmilos kotlarmilos modified the milestones: 9.0.0, Future Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-wasm WebAssembly architecture area-VM-meta-mono size-reduction Issues impacting final app size primary for size sensitive workloads tenet-performance Performance related issue tracking This issue is tracking the completion of other related issues.
Projects
None yet
Development

No branches or pull requests

3 participants