-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Perf] Linux/arm64: 29 Regressions on 12/2/2022 1:56:04 AM #79336
Comments
Run Information
Regressions in System.Tests.Perf_UInt16
Reprogit clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Tests.Perf_UInt16*' PayloadsHistogramSystem.Tests.Perf_UInt16.ToString(value: 12345)
Description of detection logic
Description of detection logic
Description of detection logic
DocsProfiling workflow for dotnet/runtime repository
Regressions in System.Numerics.Tests.Perf_BigInteger
Reprogit clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Numerics.Tests.Perf_BigInteger*' PayloadsHistogramSystem.Numerics.Tests.Perf_BigInteger.ToStringD(numberString: 123)
Description of detection logic
DocsProfiling workflow for dotnet/runtime repository Run Information
Regressions in PerfLabTests.LowLevelPerf
Reprogit clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'PerfLabTests.LowLevelPerf*' PayloadsHistogramPerfLabTests.LowLevelPerf.IntegerFormatting
Description of detection logic
DocsProfiling workflow for dotnet/runtime repository Run Information
Regressions in PerfLabTests.BlockCopyPerf
Reprogit clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'PerfLabTests.BlockCopyPerf*' PayloadsHistogramPerfLabTests.BlockCopyPerf.CallBlockCopy(numElements: 10)
Description of detection logic
DocsProfiling workflow for dotnet/runtime repository Run Information
Regressions in System.Tests.Perf_String
Reprogit clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Tests.Perf_String*' PayloadsHistogramSystem.Tests.Perf_String.Remove_IntInt(s: "dzsdzsDDZSDZSDZSddsz", i1: 0, i2: 8)
Description of detection logic
DocsProfiling workflow for dotnet/runtime repository Run Information
Regressions in System.Threading.Tests.Perf_Lock
Reprogit clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Threading.Tests.Perf_Lock*' PayloadsHistogramSystem.Threading.Tests.Perf_Lock.ReaderWriterLockSlimPerf
Description of detection logic
DocsProfiling workflow for dotnet/runtime repository |
I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label. |
Tagging subscribers to this area: @BrzVlad Issue DetailsRun Information
Regressions in System.Tests.Perf_Version
Reprogit clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Tests.Perf_Version*' PayloadsHistogramSystem.Tests.Perf_Version.Ctor3
Description of detection logic
Description of detection logic
Description of detection logic
DocsProfiling workflow for dotnet/runtime repository
Regressions in System.Tests.Perf_Int16
Reprogit clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Tests.Perf_Int16*' PayloadsHistogramSystem.Tests.Perf_Int16.ToString(value: 32767)
Description of detection logic
Description of detection logic
DocsProfiling workflow for dotnet/runtime repository Run Information
Regressions in System.Numerics.Tests.Perf_Matrix4x4
Reprogit clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Numerics.Tests.Perf_Matrix4x4*' PayloadsHistogramSystem.Numerics.Tests.Perf_Matrix4x4.CreatePerspectiveFieldOfViewBenchmark
Description of detection logic
Description of detection logic
Description of detection logic
DocsProfiling workflow for dotnet/runtime repository Run Information
Regressions in LinqBenchmarks
Reprogit clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'LinqBenchmarks*' PayloadsHistogramLinqBenchmarks.Where01ForX
Description of detection logic
Description of detection logic
Description of detection logic
DocsProfiling workflow for dotnet/runtime repository Run Information
Regressions in System.Perf_Convert
Reprogit clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Perf_Convert*' PayloadsHistogramSystem.Perf_Convert.ChangeType
Description of detection logic
DocsProfiling workflow for dotnet/runtime repository Run Information
Regressions in System.Tests.Perf_Byte
Reprogit clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Tests.Perf_Byte*' PayloadsHistogramSystem.Tests.Perf_Byte.ToString(value: 255)
Description of detection logic
Description of detection logic
DocsProfiling workflow for dotnet/runtime repository Run Information
Regressions in System.Tests.Perf_SByte
Reprogit clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Tests.Perf_SByte*' PayloadsHistogramSystem.Tests.Perf_SByte.ToString(value: 127)
Description of detection logic
DocsProfiling workflow for dotnet/runtime repository Run Information
Regressions in System.Tests.Perf_Int32
Reprogit clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Tests.Perf_Int32*' PayloadsHistogramSystem.Tests.Perf_Int32.ToString(value: 4)
Description of detection logic
Description of detection logic
Description of detection logic
DocsProfiling workflow for dotnet/runtime repository Run Information
Regressions in System.Tests.Perf_UInt32
Reprogit clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Tests.Perf_UInt32*' PayloadsHistogramSystem.Tests.Perf_UInt32.ToString(value: 0)
Description of detection logic
Description of detection logic
Description of detection logic
DocsProfiling workflow for dotnet/runtime repository
|
Presumably these are all due to removing the C implementation of UInt32ToDecStr that the mono interpreter was using in preference to it using the managed implenentstion. |
Overall I'm against bring this intrinsic back, especially now that managed and native code is diverging. The regression doesn't seem to be that widespread and there is significant room for improvement on the interpreter side that can help with this. Testing locally |
Ok, thanks, sounds good. I will unassign myself then.
Nice. |
https://pvscmdupload.blob.core.windows.net/reports/allTestHistory%2frefs%2fheads%2fmain_x64_ubuntu%2018.04_CompliationMode%3dwasm_RunKind%3dmicro%2fSystem.Tests.Perf_UInt16.ToString(value%3a%2065535).html we've still got a pretty big regression in number formatting |
Mitigated by #82093. |
Mitigated by #83490. |
Run Information
Regressions in System.Tests.Perf_Version
Test Report
Repro
Payloads
Baseline
Compare
Histogram
System.Tests.Perf_Version.Ctor3
Description of detection logic
Description of detection logic
Description of detection logic
Docs
Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
Regressions in System.Tests.Perf_Int16
Test Report
Repro
Payloads
Baseline
Compare
Histogram
System.Tests.Perf_Int16.ToString(value: 32767)
Description of detection logic
Description of detection logic
Docs
Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
Run Information
Regressions in System.Numerics.Tests.Perf_Matrix4x4
Test Report
Repro
Payloads
Baseline
Compare
Histogram
System.Numerics.Tests.Perf_Matrix4x4.CreatePerspectiveFieldOfViewBenchmark
Description of detection logic
Description of detection logic
Description of detection logic
Docs
Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
Run Information
Regressions in LinqBenchmarks
Test Report
Repro
Payloads
Baseline
Compare
Histogram
LinqBenchmarks.Where01ForX
Description of detection logic
Description of detection logic
Description of detection logic
Docs
Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
Run Information
Regressions in System.Perf_Convert
Test Report
Repro
Payloads
Baseline
Compare
Histogram
System.Perf_Convert.ChangeType
Description of detection logic
Docs
Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
Run Information
Regressions in System.Tests.Perf_Byte
Test Report
Repro
Payloads
Baseline
Compare
Histogram
System.Tests.Perf_Byte.ToString(value: 255)
Description of detection logic
Description of detection logic
Docs
Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
Run Information
Regressions in System.Tests.Perf_SByte
Test Report
Repro
Payloads
Baseline
Compare
Histogram
System.Tests.Perf_SByte.ToString(value: 127)
Description of detection logic
Docs
Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
Run Information
Regressions in System.Tests.Perf_Int32
Test Report
Repro
Payloads
Baseline
Compare
Histogram
System.Tests.Perf_Int32.ToString(value: 4)
Description of detection logic
Description of detection logic
Description of detection logic
Docs
Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
Run Information
Regressions in System.Tests.Perf_UInt32
Test Report
Repro
Payloads
Baseline
Compare
Histogram
System.Tests.Perf_UInt32.ToString(value: 0)
Description of detection logic
Description of detection logic
Description of detection logic
Docs
Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
The text was updated successfully, but these errors were encountered: