-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm][icu] Canonical locales are not in filters but users would like to use them #79816
Comments
Tagging subscribers to this area: @dotnet/area-system-globalization Issue Detailsin ICU we have a list of commonly used locales: Not all of them are listed in the filters for "full" icu data file and some users get confused as they would like to use them. There are 3 locales that were requested in the discussion (#53239):
I have no broader overview how frequently they are used, each of them was mentioned once in the issue. Size effect: I would like to underline that these are not the only canonical locales we are missing. These are only these, that got reported, so apparently are in use. If we wanted to patch all the missing ones it would be 36 of them:
Any help regarding making the decision if to add the requested 3 locales is welcome. cc @lewing @directhex
|
Tagging subscribers to 'arch-wasm': @lewing Issue Detailsin ICU we have a list of commonly used locales: Not all of them are listed in the filters for "full" icu data file and some users get confused as they would like to use them. There are 3 locales that were requested in the discussion (#53239):
I have no broader overview how frequently they are used, each of them was mentioned once in the issue. Size effect: I would like to underline that these are not the only canonical locales we are missing. These are only these, that got reported, so apparently are in use. If we wanted to patch all the missing ones it would be 36 of them:
Any help regarding making the decision if to add the requested 3 locales is welcome. cc @lewing @directhex
|
Closing from similar reason as dotnet/icu#298. We are thinking about custom ICU files and it would solve this issue. #79987 |
in ICU we have a list of commonly used locales:
https://github.com/dotnet/icu/blob/dotnet/main/icu/icu4c/source/common/locid.cpp#L517
Not all of them are listed in the filters for "full" icu data file and some users get confused as they would like to use them. There are 3 locales that were requested in the discussion (#53239 and #43398):
I have no broader overview how frequently they are used, each of them was mentioned once in the issue.
Size effect:
if we make a bold assumption that ICU bundle was affected only by adding these 3 locales then size increase is <3%.
Previous size: 1490 kB,
Current size: 1533 kB.
I would like to underline that these are not the only canonical locales we are missing. These are only these, that got reported, so apparently are in use. If we wanted to patch all the missing ones it would be 36 of them:
Any help regarding making the decision if to add the requested 3 locales is welcome. cc @lewing @directhex
The text was updated successfully, but these errors were encountered: