Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regressions in System.Buffers.Text.Tests.Utf8FormatterTests #81228

Closed
performanceautofiler bot opened this issue Jan 26, 2023 · 3 comments
Closed

Regressions in System.Buffers.Text.Tests.Utf8FormatterTests #81228

performanceautofiler bot opened this issue Jan 26, 2023 · 3 comments
Assignees
Labels
area-System.Buffers tenet-build-performance Impacts build time: official, developer or CI tenet-performance Performance related issue
Milestone

Comments

@performanceautofiler
Copy link

Run Information

Architecture arm64
OS ubuntu 20.04
Baseline 7568ca398689b60841a9753f2777e5b3407a6d45
Compare 64f7fab10afa8dc7fca817a554070607648eae38
Diff Diff

Regressions in System.Buffers.Text.Tests.Utf8FormatterTests

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
FormatterInt32 - Duration of single invocation 1.83 ns 4.71 ns 2.58 0.54 False

graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Buffers.Text.Tests.Utf8FormatterTests*'

Payloads

Baseline
Compare

Histogram

System.Buffers.Text.Tests.Utf8FormatterTests.FormatterInt32(value: 4)


Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 4.705460713835775 > 1.9172362760235513.
IsChangePoint: Marked as a change because one of 1/21/2023 1:51:00 AM, 1/25/2023 11:59:01 PM falls between 1/17/2023 11:08:46 AM and 1/25/2023 11:59:01 PM.
IsRegressionStdDev: Marked as regression because -17.948001637125667 (T) = (0 -5.15830760168831) / Math.Sqrt((0.4702231425596768 / (26)) + (0.08762632214038191 / (17))) is less than -2.019540970439573 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (26) + (17) - 2, .025) and -1.1296012944001799 = (2.422194058226843 - 5.15830760168831) / 2.422194058226843 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

@performanceautofiler performanceautofiler bot added the untriaged New issue has not been triaged by the area owner label Jan 26, 2023
@cincuranet cincuranet changed the title [Perf] Linux/arm64: 1 Regression on 1/21/2023 8:03:21 AM Regressions in System.Buffers.Text.Tests.Utf8FormatterTests Jan 26, 2023
@cincuranet cincuranet removed the untriaged New issue has not been triaged by the area owner label Jan 26, 2023
@cincuranet cincuranet transferred this issue from dotnet/perf-autofiling-issues Jan 26, 2023
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Jan 26, 2023
@ghost
Copy link

ghost commented Jan 26, 2023

Tagging subscribers to this area: @dotnet/area-system-buffers
See info in area-owners.md if you want to be subscribed.

Issue Details

Run Information

Architecture arm64
OS ubuntu 20.04
Baseline 7568ca398689b60841a9753f2777e5b3407a6d45
Compare 64f7fab10afa8dc7fca817a554070607648eae38
Diff Diff

Regressions in System.Buffers.Text.Tests.Utf8FormatterTests

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
FormatterInt32 - Duration of single invocation 1.83 ns 4.71 ns 2.58 0.54 False

graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Buffers.Text.Tests.Utf8FormatterTests*'

Payloads

Baseline
Compare

Histogram

System.Buffers.Text.Tests.Utf8FormatterTests.FormatterInt32(value: 4)


Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 4.705460713835775 > 1.9172362760235513.
IsChangePoint: Marked as a change because one of 1/21/2023 1:51:00 AM, 1/25/2023 11:59:01 PM falls between 1/17/2023 11:08:46 AM and 1/25/2023 11:59:01 PM.
IsRegressionStdDev: Marked as regression because -17.948001637125667 (T) = (0 -5.15830760168831) / Math.Sqrt((0.4702231425596768 / (26)) + (0.08762632214038191 / (17))) is less than -2.019540970439573 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (26) + (17) - 2, .025) and -1.1296012944001799 = (2.422194058226843 - 5.15830760168831) / 2.422194058226843 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Author: performanceautofiler[bot]
Assignees: tannergooding
Labels:

area-System.Buffers

Milestone: -

@cincuranet
Copy link
Contributor

Related regression #80745. Although it's a different commit range and different OS.

Maybe cause by #80888 or #80932.

@dakersnar dakersnar added tenet-performance Performance related issue tenet-build-performance Impacts build time: official, developer or CI labels Feb 10, 2023
@dakersnar dakersnar added this to the 8.0.0 milestone Feb 10, 2023
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Feb 10, 2023
@tannergooding
Copy link
Member

The general code here had a number of refactorings to allow sharing between UTF-8 and UTF-16. Some minor regressions were expected and while this isn't the fastest its been all release, its still faster than it was in .NET 6/7.

@ghost ghost locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Buffers tenet-build-performance Impacts build time: official, developer or CI tenet-performance Performance related issue
Projects
None yet
Development

No branches or pull requests

3 participants