Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for "archiving" of SPMI-generated diffs #81838

Open
SingleAccretion opened this issue Feb 8, 2023 · 4 comments
Open

Allow for "archiving" of SPMI-generated diffs #81838

SingleAccretion opened this issue Feb 8, 2023 · 4 comments
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Milestone

Comments

@SingleAccretion
Copy link
Contributor

SingleAccretion commented Feb 8, 2023

Today, we use the very informative SPMI diffs pipeline to make decisions and observe diffs before merging changes, but the summaries quickly expire, and so they are not as useful as they could be for looking at past changes. It would be great to have some (preferably automatic) way to save them (perhaps even with the .dasms).

@dotnet/jit-contrib

category:eng-sys
theme:super-pmi
skill-level:intermediate
cost:medium
impact:medium

@SingleAccretion SingleAccretion added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 8, 2023
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Feb 8, 2023
@ghost
Copy link

ghost commented Feb 8, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak
See info in area-owners.md if you want to be subscribed.

Issue Details

Today, we use the very informative SPMI diffs pipeline to make decisions and observe diffs before merging changes, but the summaries quickly expire, and so they are not as useful as they could be for looking at past changes. It would be great to have some (preferably automatic) way to save them (perhaps even with the .dasms) for merged changes.

@dotnet/jit-contrib

Author: SingleAccretion
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@BruceForstall BruceForstall changed the title Allow for "achiving" of SPMI-genereated diffs Allow for "archiving" of SPMI-generated diffs Feb 8, 2023
@BruceForstall
Copy link
Member

Thank you for opening this issue. We've talked about this internally many times but I couldn't find another GitHub issue describing it.

It would be nice if the "Extensions" page ("Summary" markdown file) was automatically posted to the GitHub comments of a triggering PR. There are some tricky security challenges to get that to happen (namely, giving the superpmi-diffs job GitHub posting permissions). The ASP.NET perf system apparently does do this kind of post-back so it should be solveable.

Similarly, you could imagine posting the .dasm file summaries to the JIT Azure Storage location (where the SPMI MCH files and JIT rolling builds are stored), with some appropriate size/time expiration policy (that is more generous than the Azure DevOps policy). Once again, the issue is security.

@BruceForstall BruceForstall added this to the Future milestone Feb 8, 2023
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Feb 8, 2023
@JulieLeeMSFT
Copy link
Member

I was hoping to see this happen as well. Meanwhile, I recommend the contributors to copy/paste the key diff info to the GitHub comments manually for recording/documentation purpose. CC @dotnet/jit-contrib.

It would be nice if the "Extensions" page ("Summary" markdown file) was automatically posted to the GitHub comments

@kunalspathak
Copy link
Member

I will talk to @sebastienros to see how we can integrate this ability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

No branches or pull requests

4 participants