Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regressions in System.Numerics.Tests.Perf_Vector3 #82102

Closed
performanceautofiler bot opened this issue Feb 14, 2023 · 3 comments
Closed

Regressions in System.Numerics.Tests.Perf_Vector3 #82102

performanceautofiler bot opened this issue Feb 14, 2023 · 3 comments
Assignees
@tannergooding
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark
Milestone
8.0.0

Comments

@performanceautofiler
Copy link

Run Information

Architecture x64
OS Windows 10.0.18362
Baseline 4af855b0101bad16a4e25a7ec3c4c6a2f2984fb0
Compare 77b50161a2cc14ee21a0483be9c72530ccd02bed
Diff Diff

Regressions in System.Numerics.Tests.Perf_Vector3

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
DivideByScalarOperatorBenchmark - Duration of single invocation 0.35 ns 53.52 ns 151.97 0.05 False 6.879176172427058 4.061063962659871 0.590341613714928) Trace Trace
SquareRootBenchmark - Duration of single invocation 0.08 ns 47.89 ns 614.20 0.09 False Trace Trace
DivideByScalarBenchmark - Duration of single invocation 0.35 ns 53.82 ns 153.43 0.04 False 6.880801615941536 3.9414617708295734 0.5728201437602765) Trace Trace
NormalizeBenchmark - Duration of single invocation 0.35 ns 61.31 ns 174.34 0.26 False 7.871873483279524 4.90030786269817 0.6225084629607943) Trace Trace
ReflectBenchmark - Duration of single invocation 0.47 ns 47.24 ns 100.95 0.21 False Trace Trace
DivideByVector3OperatorBenchmark - Duration of single invocation 0.35 ns 53.51 ns 152.50 0.17 False Trace Trace
DivideByVector3Benchmark - Duration of single invocation 0.35 ns 53.79 ns 152.77 0.20 False Trace Trace

graph
graph
graph
graph
graph
graph
graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

Payloads

Baseline
Compare

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Numerics.Tests.Perf_Vector3*'

Payloads

Baseline
Compare

Histogram

System.Numerics.Tests.Perf_Vector3.DivideByScalarOperatorBenchmark

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 53.52204080385452 > 0.3683153178798433.
IsChangePoint: Marked as a change because one of 2/11/2023 5:46:38 PM, 2/14/2023 2:39:38 AM falls between 2/4/2023 10:21:07 PM and 2/14/2023 2:39:38 AM.
IsRegressionStdDev: Marked as regression because -945.0675087798578 (T) = (0 -53.598412650439705) / Math.Sqrt((0.012932180021838246 / (51)) + (0.026350713548776977 / (9))) is less than -2.001717484144427 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (51) + (9) - 2, .025) and -182.13345259929045 = (0.2926740684986538 - 53.598412650439705) / 0.2926740684986538 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```### Baseline Jit Disasm

```assembly
; System.Numerics.Tests.Perf_Vector3.DivideByScalarOperatorBenchmark()
       vzeroupper
       vmovups   xmm0,[7FFA0D2F52B0]
       vmovups   xmm1,[7FFA0D2F52C0]
       vdivps    xmm0,xmm0,xmm1
       vmovsd    qword ptr [rdx],xmm0
       vextractps dword ptr [rdx+8],xmm0,2
       mov       rax,rdx
       ret
; Total bytes of code 38

Compare Jit Disasm

; System.Numerics.Tests.Perf_Vector3.DivideByScalarOperatorBenchmark()
       vzeroupper
       vmovups   xmm0,[7FFF318A3510]
       vmovups   xmm1,[7FFF318A3520]
       vdivps    xmm0,xmm0,xmm1
       vmovsd    qword ptr [rdx],xmm0
       vextractps dword ptr [rdx+8],xmm0,2
       mov       rax,rdx
       ret
; Total bytes of code 38

System.Numerics.Tests.Perf_Vector3.SquareRootBenchmark

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 47.89157764632702 > 0.08186366886077377.
IsChangePoint: Marked as a change because one of 2/11/2023 5:46:38 PM, 2/14/2023 2:39:38 AM falls between 2/4/2023 10:21:07 PM and 2/14/2023 2:39:38 AM.
IsRegressionStdDev: Marked as regression because -1689.292404500761 (T) = (0 -47.925733276120276) / Math.Sqrt((0.0030365137556125394 / (51)) + (0.00668027690403714 / (9))) is less than -2.001717484144427 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (51) + (9) - 2, .025) and -520.8939215725901 = (0.09183041092279573 - 47.925733276120276) / 0.09183041092279573 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```### Baseline Jit Disasm

```assembly
; System.Numerics.Tests.Perf_Vector3.SquareRootBenchmark()
       vzeroupper
       vmovups   xmm0,[7FF805035280]
       vsqrtps   xmm0,xmm0
       vmovsd    qword ptr [rdx],xmm0
       vextractps dword ptr [rdx+8],xmm0,2
       mov       rax,rdx
       ret
; Total bytes of code 30

Compare Jit Disasm

; System.Numerics.Tests.Perf_Vector3.SquareRootBenchmark()
       vzeroupper
       vmovups   xmm0,[7FFD361A3920]
       vsqrtps   xmm0,xmm0
       vmovsd    qword ptr [rdx],xmm0
       vextractps dword ptr [rdx+8],xmm0,2
       mov       rax,rdx
       ret
; Total bytes of code 30

System.Numerics.Tests.Perf_Vector3.DivideByScalarBenchmark

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 53.82498764271161 > 0.36836061180518365.
IsChangePoint: Marked as a change because one of 2/11/2023 5:46:38 PM, 2/14/2023 2:39:38 AM falls between 2/4/2023 10:21:07 PM and 2/14/2023 2:39:38 AM.
IsRegressionStdDev: Marked as regression because -1116.2364442576868 (T) = (0 -53.61209157811599) / Math.Sqrt((0.012889778118739495 / (51)) + (0.01826087089025488 / (9))) is less than -2.001717484144427 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (51) + (9) - 2, .025) and -182.3790665026277 = (0.29235666098969787 - 53.61209157811599) / 0.29235666098969787 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```### Baseline Jit Disasm

```assembly
; System.Numerics.Tests.Perf_Vector3.DivideByScalarBenchmark()
       vzeroupper
       vmovups   xmm0,[7FFC05D152B0]
       vmovups   xmm1,[7FFC05D152C0]
       vdivps    xmm0,xmm0,xmm1
       vmovsd    qword ptr [rdx],xmm0
       vextractps dword ptr [rdx+8],xmm0,2
       mov       rax,rdx
       ret
; Total bytes of code 38

Compare Jit Disasm

; System.Numerics.Tests.Perf_Vector3.DivideByScalarBenchmark()
       vzeroupper
       vmovups   xmm0,[7FF96D943510]
       vmovups   xmm1,[7FF96D943520]
       vdivps    xmm0,xmm0,xmm1
       vmovsd    qword ptr [rdx],xmm0
       vextractps dword ptr [rdx+8],xmm0,2
       mov       rax,rdx
       ret
; Total bytes of code 38

System.Numerics.Tests.Perf_Vector3.NormalizeBenchmark

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 61.31495027827794 > 0.3702649959268577.
IsChangePoint: Marked as a change because one of 2/11/2023 5:46:38 PM, 2/14/2023 2:39:38 AM falls between 2/4/2023 10:21:07 PM and 2/14/2023 2:39:38 AM.
IsRegressionStdDev: Marked as regression because -13010.454424926322 (T) = (0 -61.31828198442138) / Math.Sqrt((0.0010209650054354 / (51)) + (1.738655488528319E-05 / (9))) is less than -2.001717484144427 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (51) + (9) - 2, .025) and -168.30795288508605 = (0.3621701221917188 - 61.31828198442138) / 0.3621701221917188 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```### Baseline Jit Disasm

```assembly
; System.Numerics.Tests.Perf_Vector3.NormalizeBenchmark()
       vzeroupper
       vmovups   xmm0,[7FFC855052B0]
       vdpps     xmm1,xmm0,xmm0,7F
       vsqrtps   xmm1,xmm1
       vdivps    xmm0,xmm0,xmm1
       vmovsd    qword ptr [rdx],xmm0
       vextractps dword ptr [rdx+8],xmm0,2
       mov       rax,rdx
       ret
; Total bytes of code 40

Compare Jit Disasm

; System.Numerics.Tests.Perf_Vector3.NormalizeBenchmark()
       vzeroupper
       vmovups   xmm0,[7FFECA0734F0]
       vdpps     xmm1,xmm0,xmm0,7F
       vsqrtps   xmm1,xmm1
       vdivps    xmm0,xmm0,xmm1
       vmovsd    qword ptr [rdx],xmm0
       vextractps dword ptr [rdx+8],xmm0,2
       mov       rax,rdx
       ret
; Total bytes of code 40

System.Numerics.Tests.Perf_Vector3.ReflectBenchmark

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 47.239718626946264 > 0.49228310189007785.
IsChangePoint: Marked as a change because one of 2/11/2023 5:46:38 PM, 2/14/2023 2:39:38 AM falls between 2/4/2023 10:21:07 PM and 2/14/2023 2:39:38 AM.
IsRegressionStdDev: Marked as regression because -1350.3620740238593 (T) = (0 -47.31927468917582) / Math.Sqrt((0.0019186625652479728 / (51)) + (0.010492087891274964 / (9))) is less than -2.001717484144427 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (51) + (9) - 2, .025) and -98.62469144483694 = (0.47497537009062574 - 47.31927468917582) / 0.47497537009062574 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```### Baseline Jit Disasm

```assembly
; System.Numerics.Tests.Perf_Vector3.ReflectBenchmark()
       vzeroupper
       vmovups   xmm0,[7FFCE99E52E0]
       vmovups   xmm1,[7FFCE99E52F0]
       vdpps     xmm2,xmm0,xmm1,7F
       vmulps    xmm1,xmm2,xmm1
       vmovups   xmm2,[7FFCE99E5300]
       vmulps    xmm1,xmm1,xmm2
       vsubps    xmm0,xmm0,xmm1
       vmovsd    qword ptr [rdx],xmm0
       vextractps dword ptr [rdx+8],xmm0,2
       mov       rax,rdx
       ret
; Total bytes of code 60

Compare Jit Disasm

; System.Numerics.Tests.Perf_Vector3.ReflectBenchmark()
       vzeroupper
       vmovups   xmm0,[7FF8D95D3520]
       vmovups   xmm1,[7FF8D95D3530]
       vdpps     xmm2,xmm0,xmm1,7F
       vmulps    xmm1,xmm2,xmm1
       vmovups   xmm2,[7FF8D95D3540]
       vmulps    xmm1,xmm1,xmm2
       vsubps    xmm0,xmm0,xmm1
       vmovsd    qword ptr [rdx],xmm0
       vextractps dword ptr [rdx+8],xmm0,2
       mov       rax,rdx
       ret
; Total bytes of code 60

System.Numerics.Tests.Perf_Vector3.DivideByVector3OperatorBenchmark

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 53.511835230492565 > 0.36956199011981633.
IsChangePoint: Marked as a change because one of 2/11/2023 5:46:38 PM, 2/14/2023 2:39:38 AM falls between 2/4/2023 10:21:07 PM and 2/14/2023 2:39:38 AM.
IsRegressionStdDev: Marked as regression because -1305.37253561525 (T) = (0 -53.57891246875374) / Math.Sqrt((0.014271517508874195 / (52)) + (0.01253237059212297 / (9))) is less than -2.000995378087428 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (52) + (9) - 2, .025) and -188.34752745526927 = (0.2829660000784062 - 53.57891246875374) / 0.2829660000784062 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```### Baseline Jit Disasm

```assembly
; System.Numerics.Tests.Perf_Vector3.DivideByVector3OperatorBenchmark()
       vzeroupper
       vmovups   xmm0,[7FF8D9A952B0]
       vmovups   xmm1,[7FF8D9A952C0]
       vdivps    xmm0,xmm0,xmm1
       vmovsd    qword ptr [rdx],xmm0
       vextractps dword ptr [rdx+8],xmm0,2
       mov       rax,rdx
       ret
; Total bytes of code 38

Compare Jit Disasm

; System.Numerics.Tests.Perf_Vector3.DivideByVector3OperatorBenchmark()
       vzeroupper
       vmovups   xmm0,[7FFA1ABF3510]
       vmovups   xmm1,[7FFA1ABF3520]
       vdivps    xmm0,xmm0,xmm1
       vmovsd    qword ptr [rdx],xmm0
       vextractps dword ptr [rdx+8],xmm0,2
       mov       rax,rdx
       ret
; Total bytes of code 38

System.Numerics.Tests.Perf_Vector3.DivideByVector3Benchmark

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 53.79376455907825 > 0.36838773242445005.
IsChangePoint: Marked as a change because one of 2/11/2023 5:46:38 PM, 2/14/2023 2:39:38 AM falls between 2/4/2023 10:21:07 PM and 2/14/2023 2:39:38 AM.
IsRegressionStdDev: Marked as regression because -1038.8372651281372 (T) = (0 -53.66677275393125) / Math.Sqrt((0.012757445817109176 / (52)) + (0.02154880527507278 / (9))) is less than -2.000995378087428 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (52) + (9) - 2, .025) and -181.5932534708969 = (0.2939143245097227 - 53.66677275393125) / 0.2939143245097227 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```### Baseline Jit Disasm

```assembly
; System.Numerics.Tests.Perf_Vector3.DivideByVector3Benchmark()
       vzeroupper
       vmovups   xmm0,[7FF90C7F52B0]
       vmovups   xmm1,[7FF90C7F52C0]
       vdivps    xmm0,xmm0,xmm1
       vmovsd    qword ptr [rdx],xmm0
       vextractps dword ptr [rdx+8],xmm0,2
       mov       rax,rdx
       ret
; Total bytes of code 38

Compare Jit Disasm

; System.Numerics.Tests.Perf_Vector3.DivideByVector3Benchmark()
       vzeroupper
       vmovups   xmm0,[7FFC20EA3510]
       vmovups   xmm1,[7FFC20EA3520]
       vdivps    xmm0,xmm0,xmm1
       vmovsd    qword ptr [rdx],xmm0
       vextractps dword ptr [rdx+8],xmm0,2
       mov       rax,rdx
       ret
; Total bytes of code 38

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Run Information

Architecture x64
OS Windows 10.0.18362
Baseline 4af855b0101bad16a4e25a7ec3c4c6a2f2984fb0
Compare 77b50161a2cc14ee21a0483be9c72530ccd02bed
Diff Diff

Regressions in System.Numerics.Tests.Perf_Vector4

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
DistanceSquaredJitOptimizeCanaryBenchmark - Duration of single invocation 0.00 ns 1.05 ns ∞ 0.07 False 1.9292793112991027 2.828632192796161 1.4661600195626774) Trace Trace
DistanceSquaredBenchmark - Duration of single invocation 0.00 ns 1.30 ns ∞ 0.12 False 2.0348397949579375 2.827296748521746 1.3894443953412998) Trace Trace

graph
graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

Payloads

Baseline
Compare

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Numerics.Tests.Perf_Vector4*'

Payloads

Baseline
Compare

Histogram

System.Numerics.Tests.Perf_Vector4.DistanceSquaredJitOptimizeCanaryBenchmark

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 1.052668205452118 > 0.
IsChangePoint: Marked as a change because one of 1/22/2023 2:59:30 AM, 2/11/2023 5:46:38 PM, 2/14/2023 2:39:38 AM falls between 2/4/2023 10:21:07 PM and 2/14/2023 2:39:38 AM.
IsRegressionStdDev: Marked as regression because -729.2403668326342 (T) = (0 -1.0547871517338334) / Math.Sqrt((7.345720760572574E-05 / (51)) + (5.689327399871686E-06 / (9))) is less than -2.001717484144427 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (51) + (9) - 2, .025) and -211.51233998846368 = (0.004963416015235129 - 1.0547871517338334) / 0.004963416015235129 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```### Baseline Jit Disasm

```assembly
; System.Numerics.Tests.Perf_Vector4.DistanceSquaredJitOptimizeCanaryBenchmark()
       vzeroupper
       vmovups   xmm0,[7FFEE37F5190]
       vsubps    xmm0,xmm0,[7FFEE37F51A0]
       vdpps     xmm0,xmm0,xmm0,0FF
       ret
; Total bytes of code 26

Compare Jit Disasm

; System.Numerics.Tests.Perf_Vector4.DistanceSquaredJitOptimizeCanaryBenchmark()
       vzeroupper
       vmovups   xmm0,[7FF9CAF63400]
       vsubps    xmm0,xmm0,[7FF9CAF63410]
       vmovups   xmm0,[7FF9CAF63420]
       vdpps     xmm0,xmm0,[7FF9CAF63420],0FF
       ret
; Total bytes of code 38

System.Numerics.Tests.Perf_Vector4.DistanceSquaredBenchmark

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 1.3046965537422 > 0.
IsChangePoint: Marked as a change because one of 1/22/2023 2:59:30 AM, 2/11/2023 5:46:38 PM, 2/14/2023 2:39:38 AM falls between 2/4/2023 10:21:07 PM and 2/14/2023 2:39:38 AM.
IsRegressionStdDev: Marked as regression because -215.42371536833542 (T) = (0 -1.3045865322987362) / Math.Sqrt((0.0018186852798285386 / (51)) + (1.671063706677567E-08 / (9))) is less than -2.001717484144427 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (51) + (9) - 2, .025) and -70.99720345232437 = (0.018119961189362262 - 1.3045865322987362) / 0.018119961189362262 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```### Baseline Jit Disasm

```assembly
; System.Numerics.Tests.Perf_Vector4.DistanceSquaredBenchmark()
       vzeroupper
       vmovups   xmm0,[7FF900A85190]
       vsubps    xmm0,xmm0,[7FF900A851A0]
       vdpps     xmm0,xmm0,xmm0,0FF
       ret
; Total bytes of code 26

Compare Jit Disasm

; System.Numerics.Tests.Perf_Vector4.DistanceSquaredBenchmark()
       vzeroupper
       vmovups   xmm0,[7FFF8FAA3400]
       vsubps    xmm0,xmm0,[7FFF8FAA3410]
       vmovups   xmm0,[7FFF8FAA3420]
       vdpps     xmm0,xmm0,[7FFF8FAA3420],0FF
       ret
; Total bytes of code 38

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
@performanceautofiler performanceautofiler bot added the untriaged New issue has not been triaged by the area owner label Feb 14, 2023
@cincuranet cincuranet removed the untriaged New issue has not been triaged by the area owner label Feb 14, 2023
@cincuranet cincuranet changed the title [Perf] Windows/x64: 9 Regressions on 2/12/2023 12:05:22 AM Regressions in System.Numerics.Tests.Perf_Vector3 Feb 14, 2023
@cincuranet cincuranet transferred this issue from dotnet/perf-autofiling-issues Feb 14, 2023
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Feb 14, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 14, 2023
@ghost
Copy link

ghost commented Feb 14, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak
See info in area-owners.md if you want to be subscribed.

Issue Details

Run Information

Architecture x64
OS Windows 10.0.18362
Baseline 4af855b0101bad16a4e25a7ec3c4c6a2f2984fb0
Compare 77b50161a2cc14ee21a0483be9c72530ccd02bed
Diff Diff

Regressions in System.Numerics.Tests.Perf_Vector3

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
DivideByScalarOperatorBenchmark - Duration of single invocation 0.35 ns 53.52 ns 151.97 0.05 False 6.879176172427058 4.061063962659871 0.590341613714928) Trace Trace
SquareRootBenchmark - Duration of single invocation 0.08 ns 47.89 ns 614.20 0.09 False Trace Trace
DivideByScalarBenchmark - Duration of single invocation 0.35 ns 53.82 ns 153.43 0.04 False 6.880801615941536 3.9414617708295734 0.5728201437602765) Trace Trace
NormalizeBenchmark - Duration of single invocation 0.35 ns 61.31 ns 174.34 0.26 False 7.871873483279524 4.90030786269817 0.6225084629607943) Trace Trace
ReflectBenchmark - Duration of single invocation 0.47 ns 47.24 ns 100.95 0.21 False Trace Trace
DivideByVector3OperatorBenchmark - Duration of single invocation 0.35 ns 53.51 ns 152.50 0.17 False Trace Trace
DivideByVector3Benchmark - Duration of single invocation 0.35 ns 53.79 ns 152.77 0.20 False Trace Trace

graph
graph
graph
graph
graph
graph
graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

Payloads

Baseline
Compare

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Numerics.Tests.Perf_Vector3*'

Payloads

Baseline
Compare

Histogram

System.Numerics.Tests.Perf_Vector3.DivideByScalarOperatorBenchmark

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 53.52204080385452 > 0.3683153178798433.
IsChangePoint: Marked as a change because one of 2/11/2023 5:46:38 PM, 2/14/2023 2:39:38 AM falls between 2/4/2023 10:21:07 PM and 2/14/2023 2:39:38 AM.
IsRegressionStdDev: Marked as regression because -945.0675087798578 (T) = (0 -53.598412650439705) / Math.Sqrt((0.012932180021838246 / (51)) + (0.026350713548776977 / (9))) is less than -2.001717484144427 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (51) + (9) - 2, .025) and -182.13345259929045 = (0.2926740684986538 - 53.598412650439705) / 0.2926740684986538 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```### Baseline Jit Disasm

```assembly
; System.Numerics.Tests.Perf_Vector3.DivideByScalarOperatorBenchmark()
       vzeroupper
       vmovups   xmm0,[7FFA0D2F52B0]
       vmovups   xmm1,[7FFA0D2F52C0]
       vdivps    xmm0,xmm0,xmm1
       vmovsd    qword ptr [rdx],xmm0
       vextractps dword ptr [rdx+8],xmm0,2
       mov       rax,rdx
       ret
; Total bytes of code 38

Compare Jit Disasm

; System.Numerics.Tests.Perf_Vector3.DivideByScalarOperatorBenchmark()
       vzeroupper
       vmovups   xmm0,[7FFF318A3510]
       vmovups   xmm1,[7FFF318A3520]
       vdivps    xmm0,xmm0,xmm1
       vmovsd    qword ptr [rdx],xmm0
       vextractps dword ptr [rdx+8],xmm0,2
       mov       rax,rdx
       ret
; Total bytes of code 38

System.Numerics.Tests.Perf_Vector3.SquareRootBenchmark

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 47.89157764632702 > 0.08186366886077377.
IsChangePoint: Marked as a change because one of 2/11/2023 5:46:38 PM, 2/14/2023 2:39:38 AM falls between 2/4/2023 10:21:07 PM and 2/14/2023 2:39:38 AM.
IsRegressionStdDev: Marked as regression because -1689.292404500761 (T) = (0 -47.925733276120276) / Math.Sqrt((0.0030365137556125394 / (51)) + (0.00668027690403714 / (9))) is less than -2.001717484144427 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (51) + (9) - 2, .025) and -520.8939215725901 = (0.09183041092279573 - 47.925733276120276) / 0.09183041092279573 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```### Baseline Jit Disasm

```assembly
; System.Numerics.Tests.Perf_Vector3.SquareRootBenchmark()
       vzeroupper
       vmovups   xmm0,[7FF805035280]
       vsqrtps   xmm0,xmm0
       vmovsd    qword ptr [rdx],xmm0
       vextractps dword ptr [rdx+8],xmm0,2
       mov       rax,rdx
       ret
; Total bytes of code 30

Compare Jit Disasm

; System.Numerics.Tests.Perf_Vector3.SquareRootBenchmark()
       vzeroupper
       vmovups   xmm0,[7FFD361A3920]
       vsqrtps   xmm0,xmm0
       vmovsd    qword ptr [rdx],xmm0
       vextractps dword ptr [rdx+8],xmm0,2
       mov       rax,rdx
       ret
; Total bytes of code 30

System.Numerics.Tests.Perf_Vector3.DivideByScalarBenchmark

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 53.82498764271161 > 0.36836061180518365.
IsChangePoint: Marked as a change because one of 2/11/2023 5:46:38 PM, 2/14/2023 2:39:38 AM falls between 2/4/2023 10:21:07 PM and 2/14/2023 2:39:38 AM.
IsRegressionStdDev: Marked as regression because -1116.2364442576868 (T) = (0 -53.61209157811599) / Math.Sqrt((0.012889778118739495 / (51)) + (0.01826087089025488 / (9))) is less than -2.001717484144427 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (51) + (9) - 2, .025) and -182.3790665026277 = (0.29235666098969787 - 53.61209157811599) / 0.29235666098969787 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```### Baseline Jit Disasm

```assembly
; System.Numerics.Tests.Perf_Vector3.DivideByScalarBenchmark()
       vzeroupper
       vmovups   xmm0,[7FFC05D152B0]
       vmovups   xmm1,[7FFC05D152C0]
       vdivps    xmm0,xmm0,xmm1
       vmovsd    qword ptr [rdx],xmm0
       vextractps dword ptr [rdx+8],xmm0,2
       mov       rax,rdx
       ret
; Total bytes of code 38

Compare Jit Disasm

; System.Numerics.Tests.Perf_Vector3.DivideByScalarBenchmark()
       vzeroupper
       vmovups   xmm0,[7FF96D943510]
       vmovups   xmm1,[7FF96D943520]
       vdivps    xmm0,xmm0,xmm1
       vmovsd    qword ptr [rdx],xmm0
       vextractps dword ptr [rdx+8],xmm0,2
       mov       rax,rdx
       ret
; Total bytes of code 38

System.Numerics.Tests.Perf_Vector3.NormalizeBenchmark

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 61.31495027827794 > 0.3702649959268577.
IsChangePoint: Marked as a change because one of 2/11/2023 5:46:38 PM, 2/14/2023 2:39:38 AM falls between 2/4/2023 10:21:07 PM and 2/14/2023 2:39:38 AM.
IsRegressionStdDev: Marked as regression because -13010.454424926322 (T) = (0 -61.31828198442138) / Math.Sqrt((0.0010209650054354 / (51)) + (1.738655488528319E-05 / (9))) is less than -2.001717484144427 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (51) + (9) - 2, .025) and -168.30795288508605 = (0.3621701221917188 - 61.31828198442138) / 0.3621701221917188 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```### Baseline Jit Disasm

```assembly
; System.Numerics.Tests.Perf_Vector3.NormalizeBenchmark()
       vzeroupper
       vmovups   xmm0,[7FFC855052B0]
       vdpps     xmm1,xmm0,xmm0,7F
       vsqrtps   xmm1,xmm1
       vdivps    xmm0,xmm0,xmm1
       vmovsd    qword ptr [rdx],xmm0
       vextractps dword ptr [rdx+8],xmm0,2
       mov       rax,rdx
       ret
; Total bytes of code 40

Compare Jit Disasm

; System.Numerics.Tests.Perf_Vector3.NormalizeBenchmark()
       vzeroupper
       vmovups   xmm0,[7FFECA0734F0]
       vdpps     xmm1,xmm0,xmm0,7F
       vsqrtps   xmm1,xmm1
       vdivps    xmm0,xmm0,xmm1
       vmovsd    qword ptr [rdx],xmm0
       vextractps dword ptr [rdx+8],xmm0,2
       mov       rax,rdx
       ret
; Total bytes of code 40

System.Numerics.Tests.Perf_Vector3.ReflectBenchmark

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 47.239718626946264 > 0.49228310189007785.
IsChangePoint: Marked as a change because one of 2/11/2023 5:46:38 PM, 2/14/2023 2:39:38 AM falls between 2/4/2023 10:21:07 PM and 2/14/2023 2:39:38 AM.
IsRegressionStdDev: Marked as regression because -1350.3620740238593 (T) = (0 -47.31927468917582) / Math.Sqrt((0.0019186625652479728 / (51)) + (0.010492087891274964 / (9))) is less than -2.001717484144427 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (51) + (9) - 2, .025) and -98.62469144483694 = (0.47497537009062574 - 47.31927468917582) / 0.47497537009062574 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```### Baseline Jit Disasm

```assembly
; System.Numerics.Tests.Perf_Vector3.ReflectBenchmark()
       vzeroupper
       vmovups   xmm0,[7FFCE99E52E0]
       vmovups   xmm1,[7FFCE99E52F0]
       vdpps     xmm2,xmm0,xmm1,7F
       vmulps    xmm1,xmm2,xmm1
       vmovups   xmm2,[7FFCE99E5300]
       vmulps    xmm1,xmm1,xmm2
       vsubps    xmm0,xmm0,xmm1
       vmovsd    qword ptr [rdx],xmm0
       vextractps dword ptr [rdx+8],xmm0,2
       mov       rax,rdx
       ret
; Total bytes of code 60

Compare Jit Disasm

; System.Numerics.Tests.Perf_Vector3.ReflectBenchmark()
       vzeroupper
       vmovups   xmm0,[7FF8D95D3520]
       vmovups   xmm1,[7FF8D95D3530]
       vdpps     xmm2,xmm0,xmm1,7F
       vmulps    xmm1,xmm2,xmm1
       vmovups   xmm2,[7FF8D95D3540]
       vmulps    xmm1,xmm1,xmm2
       vsubps    xmm0,xmm0,xmm1
       vmovsd    qword ptr [rdx],xmm0
       vextractps dword ptr [rdx+8],xmm0,2
       mov       rax,rdx
       ret
; Total bytes of code 60

System.Numerics.Tests.Perf_Vector3.DivideByVector3OperatorBenchmark

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 53.511835230492565 > 0.36956199011981633.
IsChangePoint: Marked as a change because one of 2/11/2023 5:46:38 PM, 2/14/2023 2:39:38 AM falls between 2/4/2023 10:21:07 PM and 2/14/2023 2:39:38 AM.
IsRegressionStdDev: Marked as regression because -1305.37253561525 (T) = (0 -53.57891246875374) / Math.Sqrt((0.014271517508874195 / (52)) + (0.01253237059212297 / (9))) is less than -2.000995378087428 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (52) + (9) - 2, .025) and -188.34752745526927 = (0.2829660000784062 - 53.57891246875374) / 0.2829660000784062 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```### Baseline Jit Disasm

```assembly
; System.Numerics.Tests.Perf_Vector3.DivideByVector3OperatorBenchmark()
       vzeroupper
       vmovups   xmm0,[7FF8D9A952B0]
       vmovups   xmm1,[7FF8D9A952C0]
       vdivps    xmm0,xmm0,xmm1
       vmovsd    qword ptr [rdx],xmm0
       vextractps dword ptr [rdx+8],xmm0,2
       mov       rax,rdx
       ret
; Total bytes of code 38

Compare Jit Disasm

; System.Numerics.Tests.Perf_Vector3.DivideByVector3OperatorBenchmark()
       vzeroupper
       vmovups   xmm0,[7FFA1ABF3510]
       vmovups   xmm1,[7FFA1ABF3520]
       vdivps    xmm0,xmm0,xmm1
       vmovsd    qword ptr [rdx],xmm0
       vextractps dword ptr [rdx+8],xmm0,2
       mov       rax,rdx
       ret
; Total bytes of code 38

System.Numerics.Tests.Perf_Vector3.DivideByVector3Benchmark

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 53.79376455907825 > 0.36838773242445005.
IsChangePoint: Marked as a change because one of 2/11/2023 5:46:38 PM, 2/14/2023 2:39:38 AM falls between 2/4/2023 10:21:07 PM and 2/14/2023 2:39:38 AM.
IsRegressionStdDev: Marked as regression because -1038.8372651281372 (T) = (0 -53.66677275393125) / Math.Sqrt((0.012757445817109176 / (52)) + (0.02154880527507278 / (9))) is less than -2.000995378087428 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (52) + (9) - 2, .025) and -181.5932534708969 = (0.2939143245097227 - 53.66677275393125) / 0.2939143245097227 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```### Baseline Jit Disasm

```assembly
; System.Numerics.Tests.Perf_Vector3.DivideByVector3Benchmark()
       vzeroupper
       vmovups   xmm0,[7FF90C7F52B0]
       vmovups   xmm1,[7FF90C7F52C0]
       vdivps    xmm0,xmm0,xmm1
       vmovsd    qword ptr [rdx],xmm0
       vextractps dword ptr [rdx+8],xmm0,2
       mov       rax,rdx
       ret
; Total bytes of code 38

Compare Jit Disasm

; System.Numerics.Tests.Perf_Vector3.DivideByVector3Benchmark()
       vzeroupper
       vmovups   xmm0,[7FFC20EA3510]
       vmovups   xmm1,[7FFC20EA3520]
       vdivps    xmm0,xmm0,xmm1
       vmovsd    qword ptr [rdx],xmm0
       vextractps dword ptr [rdx+8],xmm0,2
       mov       rax,rdx
       ret
; Total bytes of code 38

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Run Information

Architecture x64
OS Windows 10.0.18362
Baseline 4af855b0101bad16a4e25a7ec3c4c6a2f2984fb0
Compare 77b50161a2cc14ee21a0483be9c72530ccd02bed
Diff Diff

Regressions in System.Numerics.Tests.Perf_Vector4

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
DistanceSquaredJitOptimizeCanaryBenchmark - Duration of single invocation 0.00 ns 1.05 ns ∞ 0.07 False 1.9292793112991027 2.828632192796161 1.4661600195626774) Trace Trace
DistanceSquaredBenchmark - Duration of single invocation 0.00 ns 1.30 ns ∞ 0.12 False 2.0348397949579375 2.827296748521746 1.3894443953412998) Trace Trace

graph
graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

Payloads

Baseline
Compare

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Numerics.Tests.Perf_Vector4*'

Payloads

Baseline
Compare

Histogram

System.Numerics.Tests.Perf_Vector4.DistanceSquaredJitOptimizeCanaryBenchmark

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 1.052668205452118 > 0.
IsChangePoint: Marked as a change because one of 1/22/2023 2:59:30 AM, 2/11/2023 5:46:38 PM, 2/14/2023 2:39:38 AM falls between 2/4/2023 10:21:07 PM and 2/14/2023 2:39:38 AM.
IsRegressionStdDev: Marked as regression because -729.2403668326342 (T) = (0 -1.0547871517338334) / Math.Sqrt((7.345720760572574E-05 / (51)) + (5.689327399871686E-06 / (9))) is less than -2.001717484144427 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (51) + (9) - 2, .025) and -211.51233998846368 = (0.004963416015235129 - 1.0547871517338334) / 0.004963416015235129 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```### Baseline Jit Disasm

```assembly
; System.Numerics.Tests.Perf_Vector4.DistanceSquaredJitOptimizeCanaryBenchmark()
       vzeroupper
       vmovups   xmm0,[7FFEE37F5190]
       vsubps    xmm0,xmm0,[7FFEE37F51A0]
       vdpps     xmm0,xmm0,xmm0,0FF
       ret
; Total bytes of code 26

Compare Jit Disasm

; System.Numerics.Tests.Perf_Vector4.DistanceSquaredJitOptimizeCanaryBenchmark()
       vzeroupper
       vmovups   xmm0,[7FF9CAF63400]
       vsubps    xmm0,xmm0,[7FF9CAF63410]
       vmovups   xmm0,[7FF9CAF63420]
       vdpps     xmm0,xmm0,[7FF9CAF63420],0FF
       ret
; Total bytes of code 38

System.Numerics.Tests.Perf_Vector4.DistanceSquaredBenchmark

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 1.3046965537422 > 0.
IsChangePoint: Marked as a change because one of 1/22/2023 2:59:30 AM, 2/11/2023 5:46:38 PM, 2/14/2023 2:39:38 AM falls between 2/4/2023 10:21:07 PM and 2/14/2023 2:39:38 AM.
IsRegressionStdDev: Marked as regression because -215.42371536833542 (T) = (0 -1.3045865322987362) / Math.Sqrt((0.0018186852798285386 / (51)) + (1.671063706677567E-08 / (9))) is less than -2.001717484144427 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (51) + (9) - 2, .025) and -70.99720345232437 = (0.018119961189362262 - 1.3045865322987362) / 0.018119961189362262 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```### Baseline Jit Disasm

```assembly
; System.Numerics.Tests.Perf_Vector4.DistanceSquaredBenchmark()
       vzeroupper
       vmovups   xmm0,[7FF900A85190]
       vsubps    xmm0,xmm0,[7FF900A851A0]
       vdpps     xmm0,xmm0,xmm0,0FF
       ret
; Total bytes of code 26

Compare Jit Disasm

; System.Numerics.Tests.Perf_Vector4.DistanceSquaredBenchmark()
       vzeroupper
       vmovups   xmm0,[7FFF8FAA3400]
       vsubps    xmm0,xmm0,[7FFF8FAA3410]
       vmovups   xmm0,[7FFF8FAA3420]
       vdpps     xmm0,xmm0,[7FFF8FAA3420],0FF
       ret
; Total bytes of code 38

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Author: performanceautofiler[bot]
Assignees: EgorBo
Labels:

area-CodeGen-coreclr, untriaged
Milestone: -

@cincuranet
Copy link
Contributor

cincuranet commented Feb 14, 2023 •
edited
Loading

Probably caused by #81547.

More instances:

cc @tannergooding

@cincuranet cincuranet added tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark labels Feb 14, 2023
@JulieLeeMSFT JulieLeeMSFT assigned tannergooding and unassigned EgorBo Feb 14, 2023
@JulieLeeMSFT JulieLeeMSFT removed the untriaged New issue has not been triaged by the area owner label Feb 14, 2023
@JulieLeeMSFT JulieLeeMSFT added this to the 8.0.0 milestone Feb 14, 2023
@jakobbotsch jakobbotsch mentioned this issue Feb 16, 2023
Closed
@tannergooding
Copy link
Member

This is a dupe of #81766

@ghost ghost locked as resolved and limited conversation to collaborators Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tannergooding tannergooding

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark
Projects
None yet
Milestone
8.0.0
Development

No branches or pull requests
4 participants
@EgorBo @cincuranet @tannergooding @JulieLeeMSFT