-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some hardware intrinsic ILLInk.Substitution entries may be unnecessary #83164
Comments
I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label. |
These methods are marked with Linker does not look at bodies of methods marked `[Intrinsic]. The IL of these methods often does not match what the method actually does. The substitution is required to tell the linker what the method actually does. |
Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas Issue DetailsAs per #83040 (comment), some of the ILLink.Substitution entries may be unnecessary since corelib already compiles in a different copy of the ISAs ( We should double check that removing these are ok and make the files shorter if possible. -- Noting the
|
Thanks for the info! Will close this as unnecessary then. |
As per #83040 (comment), some of the ILLink.Substitution entries may be unnecessary since corelib already compiles in a different copy of the ISAs (
*.PlatformNotSupported.cs
) which return constantfalse
.We should double check that removing these are ok and make the files shorter if possible.
-- Noting the
Vector64/128/256/512
entries are needed since they do not return constant false and are instead recursive by default.The text was updated successfully, but these errors were encountered: