Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing unnecessary AllowEmptyTelemetry task usage from Crossgen Targets #83290

Open
baronfel opened this issue Mar 11, 2023 · 2 comments

Comments

@baronfel
Copy link
Member

In #82805 (and related) we had to update the AllowEmptyTelemetry task usage in the Crossgen targets to account for changes in the upstream SDK targets, which are the ones that customers actually use. While maintaining parity for the copies in this repo is important, in order to reduce the blast radius of other SDK changes we should consider removing the use of AET entirely here, in the 7.0 and 8.0 code flows.

It should be enough to remove this range from the 7.0 and main branches.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Mar 11, 2023
@davidwrighton
Copy link
Member

Seems like a good idea to me.

@mangod9 mangod9 removed the untriaged New issue has not been triaged by the area owner label Mar 22, 2023
@mangod9 mangod9 added this to the 8.0.0 milestone Mar 22, 2023
@trylek trylek mentioned this issue May 3, 2023
46 tasks
@mangod9 mangod9 modified the milestones: 8.0.0, Future Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants