Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mono][jit] OP_STOREX_MEMBASE can exceed maximum expected length on arm64 #83769

Closed
jandupej opened this issue Mar 22, 2023 · 1 comment
Closed

[mono][jit] OP_STOREX_MEMBASE can exceed maximum expected length on arm64 #83769

jandupej opened this issue Mar 22, 2023 · 1 comment
Assignees
@jandupej
Labels
area-Codegen-JIT-mono
Milestone
8.0.0

Comments

@jandupej
Copy link
Member

The issue occurred in #83592. Log

The expected maximum length of OP_STOREX_MEMBASE is 12, however if the address is large enough, it can cost as much as 4 instructions (2 for emit_imm, 1 for addx and strfpq each). The max length should thus be increased to 16.
@jandupej jandupej added this to the 8.0.0 milestone Mar 22, 2023
@jandupej jandupej self-assigned this Mar 22, 2023
@jandupej jandupej mentioned this issue Mar 22, 2023
Merged
@jandupej
Copy link
Member Author

Resolved in the above PR.

@lambdageek lambdageek mentioned this issue Mar 22, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jandupej jandupej

Labels
area-Codegen-JIT-mono
Projects
None yet
Milestone
8.0.0
Development

No branches or pull requests
1 participant
@jandupej