Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOS save/restore for AVX-512 state #83983

Open
tannergooding opened this issue Mar 27, 2023 · 2 comments
Open

MacOS save/restore for AVX-512 state #83983

tannergooding opened this issue Mar 27, 2023 · 2 comments
Assignees
Labels
area-VM-coreclr avx512 Related to the AVX-512 architecture
Milestone

Comments

@tannergooding
Copy link
Member

#83784 added initial support for thread suspend/restore of AVX512 state for Linux and did most of the work for MacOS.

However, MacOS ended up being disabled due to additional complexities in how AVX-512 support works on such systems.

We should do some minimal additional investigation to determine if AVX-512 support can in fact be enabled for OSX. The believed most likely scenario is that our hardware exception handler may be observing the fault and surfacing it regardless.

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Mar 27, 2023
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Mar 27, 2023
@tannergooding tannergooding added avx512 Related to the AVX-512 architecture area-VM-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Mar 27, 2023
@tannergooding tannergooding self-assigned this Mar 27, 2023
@EgorBo
Copy link
Member

EgorBo commented Mar 27, 2023

Since Apple gave up on x86 architecture, does it make any sense?

@tannergooding
Copy link
Member Author

Its still worth it to do the minimal additional investigation to try and support enablement IMO.

There is quite a bit of existing hardware that has support, including in our own CI lab. They likewise still support x64 emulation and while they aren't actively producing new x64 machines today, we can't really say they won't have other support in the future.

That being said, I don't want to spend significant additional time on this. I really just want to complete the investigation based on the suspected blocking issue as if it is just that, then the rest of the logic to support AVX-512 on OSX already exists. If that doesn't resolve the issue, then this issue can be closed with a note that adding the support is low-priority and with a breakdown of where things are today.

@mangod9 mangod9 removed the untriaged New issue has not been triaged by the area owner label Apr 3, 2023
@mangod9 mangod9 added this to the Future milestone Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-VM-coreclr avx512 Related to the AVX-512 architecture
Projects
None yet
Development

No branches or pull requests

3 participants