ZipFile hangs when encountering named pipe

[tmds]

The following program hangs:

using System.ComponentModel;
using System.IO.Compression;
using System.Runtime.InteropServices;

var dir = Directory.CreateDirectory(Path.Combine(Path.GetTempPath(), Path.GetRandomFileName())).FullName;
int res = MkFifo(Path.Combine(dir, "fifo"), 0x1ff);
if (res != 0)
{
    throw new Win32Exception();
}

ZipFile.CreateFromDirectory(dir, Path.Combine(Path.GetTempPath(), Path.GetRandomFileName()));

[DllImport("libSystem.Native", EntryPoint = "SystemNative_MkFifo", SetLastError = true)]
static extern int MkFifo(string pathName, uint mode);

ZipFile handles the fifo as a regular file. The open call doesn't return (because there is no peer that has it opened for writing, and the fifo isn't opened as non-blocking).

Instead of trying to open the fifo, we should either skip it, or throw an exception for encountering an unsupported file type.

[ghost]

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

---

The following program hangs:

using System.ComponentModel;
using System.IO.Compression;
using System.Runtime.InteropServices;

var dir = Directory.CreateDirectory(Path.Combine(Path.GetTempPath(), Path.GetRandomFileName())).FullName;
int res = MkFifo(Path.Combine(dir, "fifo"), 0x1ff);
if (res != 0)
{
    throw new Win32Exception();
}

ZipFile.CreateFromDirectory(dir, Path.Combine(Path.GetTempPath(), Path.GetRandomFileName()));

[DllImport("libSystem.Native", EntryPoint = "SystemNative_MkFifo", SetLastError = true)]
static extern int MkFifo(string pathName, uint mode);

ZipFile handles the fifo as a regular file. The open call doesn't return (because there is no peer that has it opened for writing, and the fifo isn't opened as non-blocking).

Instead of trying to open the fifo, we should either skip it, or throw an exception for encountering an unsupported file type.

Author:	tmds
Assignees:	-
Labels:	area-System.IO, untriaged
Milestone:	-

[ghost]

Tagging subscribers to this area: @dotnet/area-system-io-compression
See info in area-owners.md if you want to be subscribed.

Issue Details

---

The following program hangs:

using System.ComponentModel;
using System.IO.Compression;
using System.Runtime.InteropServices;

var dir = Directory.CreateDirectory(Path.Combine(Path.GetTempPath(), Path.GetRandomFileName())).FullName;
int res = MkFifo(Path.Combine(dir, "fifo"), 0x1ff);
if (res != 0)
{
    throw new Win32Exception();
}

ZipFile.CreateFromDirectory(dir, Path.Combine(Path.GetTempPath(), Path.GetRandomFileName()));

[DllImport("libSystem.Native", EntryPoint = "SystemNative_MkFifo", SetLastError = true)]
static extern int MkFifo(string pathName, uint mode);

ZipFile handles the fifo as a regular file. The open call doesn't return (because there is no peer that has it opened for writing, and the fifo isn't opened as non-blocking).

Instead of trying to open the fifo, we should either skip it, or throw an exception for encountering an unsupported file type.

Author:	tmds
Assignees:	-
Labels:	area-System.IO, area-System.IO.Compression, untriaged
Milestone:	-

[tmds]

we should either skip it, or throw an exception for encountering an unsupported file type.

The tar writer throws for unsupported types:

runtime/src/libraries/System.Formats.Tar/src/System/Formats/Tar/TarWriter.Unix.cs

Line 38 in ab2b80d

_ => throw new IOException(SR.Format(SR.TarUnsupportedFile, fullPath)),