Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI failure in the "banana" rid leg on Centos Stream 8 #86169

Closed
jkoritzinsky opened this issue May 12, 2023 · 9 comments · Fixed by #86688
Closed

CI failure in the "banana" rid leg on Centos Stream 8 #86169

jkoritzinsky opened this issue May 12, 2023 · 9 comments · Fixed by #86688
Labels
area-Infrastructure-libraries blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' source-build Issues relating to dotnet/source-build
Milestone

Comments

@jkoritzinsky
Copy link
Member

jkoritzinsky commented May 12, 2023

We're seeing a failure on the banana leg where we use a fake RID that isn't in the RID graph. The RID graph construction tools look like they are unable to determine where to add the banana.24-x64 RID into the RID graph. I think this is new with the CentOS Stream 8 base image change, but there have been many different failures in this leg for a while that I'm not sure what caused it to start failing in this manner.

Known Issue Error Message

Fill the error message using known issues guidance.

{
  "ErrorMessage": "",
  "BuildRetry": false
}

Report

Summary

24-Hour Hit Count 7-Day Hit Count 1-Month Count
0 0 0
@jkoritzinsky jkoritzinsky added blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' source-build Issues relating to dotnet/source-build labels May 12, 2023
@ghost ghost added the untriaged New issue has not been triaged by the area owner label May 12, 2023
@ghost
Copy link

ghost commented May 12, 2023

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

We're seeing a failure on the banana leg where we use a fake RID that isn't in the RID graph. The RID graph construction tools look like they are unable to determine where to add the banana.24-x64 RID into the RID graph. I think this is new with the CentOS Stream 8 base image change, but there have been many different failures in this leg for a while that I'm not sure what caused it to start failing in this manner.

Known Issue Error Message

Fill the error message using known issues guidance.

{
  "ErrorMessage": "",
  "BuildRetry": false
}
Author: jkoritzinsky
Assignees: -
Labels:

area-Infrastructure-libraries, blocking-clean-ci, source-build, untriaged

Milestone: -

@ViktorHofer
Copy link
Member

cc @am11 @tmds

@ViktorHofer
Copy link
Member

@jkoritzinsky can you please link to a build?

@ViktorHofer
Copy link
Member

@tmat would you mind looking at the build and trying to diagnose what's failing? Asking as you recently made changes to the GenerateRuntimeGraph task.

@ericstj
Copy link
Member

ericstj commented May 23, 2023

For brand new RIDs you should also specify AdditionalRuntimeIdentifierParent with something like linux or rhel or whatever is appropriate. Looks like folks try to handle here:

<InnerBuildArgs>$(InnerBuildArgs) /p:AdditionalRuntimeIdentifierParent=$(BaseOS)</InnerBuildArgs>
. Not sure if that's being used in the scenario discussed here.

@ericstj ericstj removed the untriaged New issue has not been triaged by the area owner label May 23, 2023
@ericstj ericstj added this to the 8.0.0 milestone May 23, 2023
@ericstj
Copy link
Member

ericstj commented May 23, 2023

@ViktorHofer did you mean to tag @tmds rather than @tmat?

@jkoritzinsky
Copy link
Member Author

That was never in use when this job was run on CentOS 7, so I wasn't sure if the BaseOS was inferred from somewhere or if it was broken there already.

There's no good way to specify the BaseOS (or any other additional properties for that matter) in the eng/common infra for source-build, so we might need to solve that problem first.

@tmds
Copy link
Member

tmds commented May 24, 2023

Sorry for chiming in late. As mentioned, we should set the BaseOS (just like source-build does). I'll make a PR for it.

@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label May 24, 2023
@ghost ghost added in-pr There is an active PR which will close this issue when it is merged and removed in-pr There is an active PR which will close this issue when it is merged labels May 31, 2023
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label May 31, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jun 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure-libraries blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' source-build Issues relating to dotnet/source-build
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants