Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a SPMI collection for pre-AVX512 hardware #87145

Open
tannergooding opened this issue Jun 5, 2023 · 1 comment
Open

Add a SPMI collection for pre-AVX512 hardware #87145

tannergooding opened this issue Jun 5, 2023 · 1 comment
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI avx512 Related to the AVX-512 architecture Priority:3 Work that is nice to have
Milestone
Future

Comments

@tannergooding
Copy link
Member

Our current SPMI collection runs are all on CI machines with AVX-512 support and therefore we are missing coverage for the more common hardware that only has up through AVX2.

We should add a collection job that sets DOTNET_EnableAVX512F=0 to ensure we have sufficient coverage of that scenario.

We should already be getting coverage for DOTNET_EnableAVX=0 via the crossgen2 job and so likely do not need to add coverage for that as well.
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jun 5, 2023
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Jun 5, 2023
@tannergooding tannergooding added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jun 5, 2023
@ghost
Copy link

ghost commented Jun 5, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Our current SPMI collection runs are all on CI machines with AVX-512 support and therefore we are missing coverage for the more common hardware that only has up through AVX2.

We should add a collection job that sets DOTNET_EnableAVX512F=0 to ensure we have sufficient coverage of that scenario.

We should already be getting coverage for DOTNET_EnableAVX=0 via the crossgen2 job and so likely do not need to add coverage for that as well.

Author: tannergooding
Assignees: -
Labels:

area-CodeGen-coreclr, untriaged
Milestone: -

@JulieLeeMSFT JulieLeeMSFT added this to the 8.0.0 milestone Jun 6, 2023
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Jun 6, 2023
@JulieLeeMSFT JulieLeeMSFT added untriaged New issue has not been triaged by the area owner Priority:3 Work that is nice to have and removed untriaged New issue has not been triaged by the area owner labels Jun 6, 2023
@JulieLeeMSFT JulieLeeMSFT modified the milestones: 8.0.0, 9.0.0 Aug 7, 2023
@BruceForstall BruceForstall mentioned this issue Oct 6, 2023
Closed
10 tasks
@BruceForstall BruceForstall added the avx512 Related to the AVX-512 architecture label Mar 18, 2024
@AndyAyersMS AndyAyersMS modified the milestones: 9.0.0, Future Jul 28, 2024
@BruceForstall BruceForstall mentioned this issue Oct 15, 2024
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI avx512 Related to the AVX-512 architecture Priority:3 Work that is nice to have
Projects
None yet
Milestone
Future
Development

No branches or pull requests
4 participants
@AndyAyersMS @tannergooding @BruceForstall @JulieLeeMSFT