Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure in checked/release asm diffs pipeline #87432

Closed
BruceForstall opened this issue Jun 12, 2023 · 4 comments · Fixed by #87504
Closed

Failure in checked/release asm diffs pipeline #87432

BruceForstall opened this issue Jun 12, 2023 · 4 comments · Fixed by #87504
Assignees
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI blocking-clean-ci-optional Blocking optional rolling runs
Milestone

Comments

@BruceForstall
Copy link
Member

In the coreclr_tests spmi collection, we're seeing a bunch of:

ISSUE: <ASSERT> #303569 D:\a\_work\1\s\src\coreclr\jit\compiler.h (8722) - Assertion failed '(JitConfig.EnableHWIntrinsic() == 0) || (JitConfig.EnableSSE() == 0)' in 'System.Diagnostics.Tracing.RuntimeEventSource:.ctor():this' during 'Importation' (IL size 55; hash 0xd472ed50; FullOpts)

https://dev.azure.com/dnceng-public/public/_build/results?buildId=302887&view=results

This doesn't happen when doing a spmi replay of either Checked or Release compilers alone. Note that checked/release diffs uses the superpmi.py option --diff_with_release, which in turn passes -ignoreStoredConfig to superpmi.exe. Note the comment in superpmi.py:

# If one of the JITs is Release, ignore all the stored configuration variables.
# This isn't necessary if both are Release builds (and, in fact, it can clear variables
# that both Release compilers can interpret). However, we rarely or never compare
# two Release compilers, so this is safest.
flags += [ "-ignoreStoredConfig" ]

This appears to be a regression from #85551.

Maybe will be fixed by #87420?

@BruceForstall BruceForstall added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI blocking-clean-ci-optional Blocking optional rolling runs labels Jun 12, 2023
@BruceForstall BruceForstall added this to the 8.0.0 milestone Jun 12, 2023
@ghost
Copy link

ghost commented Jun 12, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

In the coreclr_tests spmi collection, we're seeing a bunch of:

ISSUE: <ASSERT> #303569 D:\a\_work\1\s\src\coreclr\jit\compiler.h (8722) - Assertion failed '(JitConfig.EnableHWIntrinsic() == 0) || (JitConfig.EnableSSE() == 0)' in 'System.Diagnostics.Tracing.RuntimeEventSource:.ctor():this' during 'Importation' (IL size 55; hash 0xd472ed50; FullOpts)

https://dev.azure.com/dnceng-public/public/_build/results?buildId=302887&view=results

This doesn't happen when doing a spmi replay of either Checked or Release compilers alone. Note that checked/release diffs uses the superpmi.py option --diff_with_release, which in turn passes -ignoreStoredConfig to superpmi.exe. Note the comment in superpmi.py:

# If one of the JITs is Release, ignore all the stored configuration variables.
# This isn't necessary if both are Release builds (and, in fact, it can clear variables
# that both Release compilers can interpret). However, we rarely or never compare
# two Release compilers, so this is safest.
flags += [ "-ignoreStoredConfig" ]

This appears to be a regression from #85551.

Maybe will be fixed by #87420?

Author: BruceForstall
Assignees: tannergooding
Labels:

area-CodeGen-coreclr, blocking-clean-ci-optional

Milestone: 8.0.0

@BruceForstall
Copy link
Member Author

@tannergooding
Copy link
Member

tannergooding commented Jun 13, 2023

#87420 won't fix this as the asserts weren't removed/changed.

This assert should probably just be removed. There are a few cases where Vector<T> can be unsupported even without HWIntrinsics being disabled.

@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jun 13, 2023
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jun 14, 2023
@tannergooding
Copy link
Member

@ghost ghost locked as resolved and limited conversation to collaborators Jul 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI blocking-clean-ci-optional Blocking optional rolling runs
Projects
None yet
2 participants