-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failure in checked/release asm diffs pipeline #87432
Comments
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsIn the
https://dev.azure.com/dnceng-public/public/_build/results?buildId=302887&view=results This doesn't happen when doing a spmi replay of either Checked or Release compilers alone. Note that checked/release diffs uses the superpmi.py option
This appears to be a regression from #85551. Maybe will be fixed by #87420?
|
I kicked off https://dev.azure.com/dnceng-public/public/_build/results?buildId=305674&view=results to see if #87420 fixes it |
#87420 won't fix this as the asserts weren't removed/changed. This assert should probably just be removed. There are a few cases where |
In the
coreclr_tests
spmi collection, we're seeing a bunch of:https://dev.azure.com/dnceng-public/public/_build/results?buildId=302887&view=results
This doesn't happen when doing a spmi replay of either Checked or Release compilers alone. Note that checked/release diffs uses the superpmi.py option
--diff_with_release
, which in turn passes-ignoreStoredConfig
to superpmi.exe. Note the comment in superpmi.py:This appears to be a regression from #85551.
Maybe will be fixed by #87420?
The text was updated successfully, but these errors were encountered: