Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update trimming tests to use live-built ILLink.Targets logic #88624

Closed
eerhardt opened this issue Jul 10, 2023 · 2 comments · Fixed by #88929
Closed

Update trimming tests to use live-built ILLink.Targets logic #88624

eerhardt opened this issue Jul 10, 2023 · 2 comments · Fixed by #88929
Assignees
Labels
area-Tools-ILLink .NET linker development as well as trimming analyzers

Comments

@eerhardt
Copy link
Member

The trimming tests are not using the current ILLink.Targets logic that comes from the dotnet/runtime repo. This is a left-over of the previous versions when this logic came from the dotnet/linker repo. But it is now contained in dotnet/runtime, so we should be using the current repo version so PRs are validated with the updated logic.

          My understanding is that the `trimmingTests` failing here are using the package version picked up in this PR, based on

<!-- Logic to override the default IlLink tasks that come from the SDK and use the one
we use in dotnet/runtime repo -->
<ItemGroup>
<PackageReference Include="Microsoft.NET.ILLink.Tasks"
Version="{MicrosoftNETILLinkTasksVersion}"
PrivateAssets="all"
IsImplicitlyDefined="true" />
</ItemGroup>

Originally posted by @sbomer in #88245 (comment)

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 10, 2023
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Jul 10, 2023
@eerhardt eerhardt added area-Tools-ILLink .NET linker development as well as trimming analyzers and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jul 10, 2023
@ghost
Copy link

ghost commented Jul 10, 2023

Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas
See info in area-owners.md if you want to be subscribed.

Issue Details

The trimming tests are not using the current ILLink.Targets logic that comes from the dotnet/runtime repo. This is a left-over of the previous versions when this logic came from the dotnet/linker repo. But it is now contained in dotnet/runtime, so we should be using the current repo version so PRs are validated with the updated logic.

          My understanding is that the `trimmingTests` failing here are using the package version picked up in this PR, based on

<!-- Logic to override the default IlLink tasks that come from the SDK and use the one
we use in dotnet/runtime repo -->
<ItemGroup>
<PackageReference Include="Microsoft.NET.ILLink.Tasks"
Version="{MicrosoftNETILLinkTasksVersion}"
PrivateAssets="all"
IsImplicitlyDefined="true" />
</ItemGroup>

Originally posted by @sbomer in #88245 (comment)

Author: eerhardt
Assignees: -
Labels:

untriaged, area-Tools-ILLink

Milestone: -

@radical
Copy link
Member

radical commented Jul 10, 2023

cc @lewing

@agocke agocke added this to AppModel Jul 10, 2023
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Aug 1, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Aug 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Tools-ILLink .NET linker development as well as trimming analyzers
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants