-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update trimming tests to use live-built ILLink.Targets logic #88624
Comments
Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas Issue DetailsThe trimming tests are not using the current ILLink.Targets logic that comes from the dotnet/runtime repo. This is a left-over of the previous versions when this logic came from the dotnet/linker repo. But it is now contained in dotnet/runtime, so we should be using the current repo version so PRs are validated with the updated logic.
runtime/eng/testing/linker/project.csproj.template Lines 55 to 62 in a41f655
Originally posted by @sbomer in #88245 (comment)
|
cc @lewing |
The trimming tests are not using the current ILLink.Targets logic that comes from the dotnet/runtime repo. This is a left-over of the previous versions when this logic came from the dotnet/linker repo. But it is now contained in dotnet/runtime, so we should be using the current repo version so PRs are validated with the updated logic.
runtime/eng/testing/linker/project.csproj.template
Lines 55 to 62 in a41f655
Originally posted by @sbomer in #88245 (comment)
The text was updated successfully, but these errors were encountered: