Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RyuJIT] Introduce a general reverse copy prop for struct temps #8887

Open
Tracked by #76931
, #93105
...
erozenfeld opened this issue Sep 6, 2017 · 2 comments
Open
Tracked by #76931
, #93105
...

[RyuJIT] Introduce a general reverse copy prop for struct temps #8887

erozenfeld opened this issue Sep 6, 2017 · 2 comments
Assignees
@jakobbotsch
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI enhancement Product code improvement that does NOT require public API changes/additions JitUntriaged CLR JIT issues needing additional triage optimization tenet-performance Performance related issue
Milestone
Future

Comments

@erozenfeld
Copy link
Member

erozenfeld commented Sep 6, 2017 •
edited by jakobbotsch
Loading

We currently allocate a struct temp for the result of newobj or any function returning struct. In many cases that struct is immediately assigned to a local. We should perform reverse copy prop to get rid of the temp.

The relevant comment in the code is here

Related issues:

category:cq
theme:copy-prop
skill-level:intermediate
cost:medium
@erozenfeld erozenfeld self-assigned this Sep 6, 2017
@erozenfeld
Copy link
Member Author

This also came up in https://github.com/dotnet/coreclr/issues/7914.

@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@msftgits msftgits added this to the Future milestone Jan 31, 2020
@AndyAyersMS AndyAyersMS mentioned this issue Jul 7, 2020
Closed
@erozenfeld erozenfeld removed their assignment Oct 12, 2020
@BruceForstall BruceForstall added the JitUntriaged CLR JIT issues needing additional triage label Oct 28, 2020
@EgorBo EgorBo mentioned this issue Jun 26, 2022
Closed
@EgorBo EgorBo mentioned this issue Aug 3, 2022
Merged
@jakobbotsch jakobbotsch modified the milestones: Future, 8.0.0 Oct 12, 2022
@jakobbotsch jakobbotsch mentioned this issue Oct 12, 2022
Closed
20 tasks
@jakobbotsch jakobbotsch mentioned this issue Jan 18, 2023
Open
@jakobbotsch
Copy link
Member

Sadly I don't think this will make 8.0.

@jakobbotsch jakobbotsch modified the milestones: 8.0.0, Future Jun 9, 2023
@jakobbotsch jakobbotsch mentioned this issue Oct 6, 2023
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jakobbotsch jakobbotsch

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI enhancement Product code improvement that does NOT require public API changes/additions JitUntriaged CLR JIT issues needing additional triage optimization tenet-performance Performance related issue
Projects
None yet
Milestone
Future
Development

No branches or pull requests
4 participants
@jakobbotsch @msftgits @erozenfeld @BruceForstall