Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config binder gen: further tighten filtering constraint for input binding method invocations #90687

Closed
layomia opened this issue Aug 16, 2023 · 3 comments
Closed

Config binder gen: further tighten filtering constraint for input binding method invocations #90687

layomia opened this issue Aug 16, 2023 · 3 comments
Assignees
@layomia
Labels
area-Extensions-Configuration source-generator Indicates an issue with a source generator feature tenet-performance Performance related issue
Milestone
8.0.0

Comments

@layomia
Copy link
Contributor

layomia commented Aug 16, 2023

Address feedback from #90619 (comment). cc @eiriktsarpalis.
@layomia layomia added area-Extensions-Configuration source-generator Indicates an issue with a source generator feature labels Aug 16, 2023
@layomia layomia added this to the 9.0.0 milestone Aug 16, 2023
@layomia layomia self-assigned this Aug 16, 2023
@ghost
Copy link

ghost commented Aug 16, 2023

Tagging subscribers to this area: @dotnet/area-extensions-configuration
See info in area-owners.md if you want to be subscribed.

Issue Details

Address feedback from #90619 (comment). cc @eiriktsarpalis.

Author: layomia
Assignees: layomia
Labels:

area-Extensions-Configuration, source-generator
Milestone: 9.0.0

@layomia layomia mentioned this issue Aug 16, 2023
Merged
@eiriktsarpalis eiriktsarpalis modified the milestones: 9.0.0, 8.0.0 Aug 16, 2023
@eiriktsarpalis
Copy link
Member

We should aim doing this for RC2. cc @ericstj

@eiriktsarpalis eiriktsarpalis added the tenet-performance Performance related issue label Aug 16, 2023
@layomia layomia mentioned this issue Aug 24, 2023
Merged
@ericstj ericstj changed the title Condfig binder gen: further tighten filtering constraint for input binding method invocations Config binder gen: further tighten filtering constraint for input binding method invocations Sep 5, 2023
@ericstj
Copy link
Member

ericstj commented Sep 20, 2023

Fixed in RC2 with #90746

@ericstj ericstj closed this as completed Sep 20, 2023
@layomia layomia mentioned this issue Sep 27, 2023
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Oct 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@layomia layomia

Labels
area-Extensions-Configuration source-generator Indicates an issue with a source generator feature tenet-performance Performance related issue
Projects
None yet
Milestone
8.0.0
Development

No branches or pull requests
3 participants
@eiriktsarpalis @ericstj @layomia