Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider removing CORINFO_HELP_CHKCASTARRAY and CORINFO_HELP_ISINSTANCEOFARRAY from JIT/EE interface #91016

Open
VSadov opened this issue Aug 23, 2023 · 1 comment
Open

Consider removing CORINFO_HELP_CHKCASTARRAY and CORINFO_HELP_ISINSTANCEOFARRAY from JIT/EE interface #91016

VSadov opened this issue Aug 23, 2023 · 1 comment
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Milestone
Future

Comments

@VSadov
Copy link
Member

VSadov commented Aug 23, 2023

An attempt was made in #89548, but it turned out to be trickier than expected.
While these helpers are not used at run time (they are mapped to "ANY" variants), there is dependency at JIT time as JIT considers these helpers when making optimization choices.

It is possible that a different API would be more appropriate or less fragile here.
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 23, 2023
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Aug 23, 2023
@VSadov VSadov mentioned this issue Aug 23, 2023
Closed
@jkotas jkotas added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Aug 23, 2023
@ghost
Copy link

ghost commented Aug 23, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

An attempt was made in #89548, but it turned out to be trickier than expected.
While these helpers are not used at run time (they are mapped to "ANY" variants), there is dependency at JIT time as JIT considers these helpers when making optimization choices.

It is possible that a different API would be more appropriate or less fragile here.

Author: VSadov
Assignees: -
Labels:

area-CodeGen-coreclr, untriaged
Milestone: -

@JulieLeeMSFT JulieLeeMSFT added this to the Future milestone Aug 28, 2023
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
Future
Development

No branches or pull requests
3 participants
@jkotas @VSadov @JulieLeeMSFT