Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Regex use of SearchValues<string> to be OrdinalCaseInsensitive #91645

Closed
stephentoub opened this issue Sep 5, 2023 · 1 comment
Closed

Update Regex use of SearchValues<string> to be OrdinalCaseInsensitive #91645

stephentoub opened this issue Sep 5, 2023 · 1 comment
Assignees
@stephentoub
Labels
area-System.Text.RegularExpressions tenet-performance Performance related issue
Milestone
9.0.0

Comments

@stephentoub
Copy link
Member

SearchValues<string> supports OrdinalIgnoreCase. As of #88400, Regex currently only uses Ordinal, which means if it actually began with multiple ignore-case prefixes, it tries to create every cased permutation of their letters, and other than for extremely short prefixes, will quickly give up. We can instead teach its analysis to be able to use OrdinalIgnoreCase, which will lead to significantly better speedups on the relevant cases.
@stephentoub stephentoub added this to the 9.0.0 milestone Sep 5, 2023
@stephentoub stephentoub self-assigned this Dec 26, 2023
@stephentoub
Copy link
Member Author

Closing in favor of #85693

@stephentoub stephentoub closed this as not planned Won't fix, can't repro, duplicate, stale Jan 2, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@stephentoub stephentoub

Labels
area-System.Text.RegularExpressions tenet-performance Performance related issue
Projects
None yet
Milestone
9.0.0
Development

No branches or pull requests
1 participant
@stephentoub