Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm][debugger] Evaluate methods with short arguments #93057

Closed
Tracked by #90587
ilonatommy opened this issue Oct 5, 2023 · 2 comments
Closed
Tracked by #90587

[wasm][debugger] Evaluate methods with short arguments #93057

ilonatommy opened this issue Oct 5, 2023 · 2 comments
Labels
arch-wasm WebAssembly architecture area-Debugger-mono enhancement Product code improvement that does NOT require public API changes/additions
Milestone

Comments

@ilonatommy
Copy link
Member

ilonatommy commented Oct 5, 2023

We do not have a mechanism of detecting if literal is short, so both options from each case:

  • short and int
  • sbyte and byte
  • uint and ushort
    are falling into the non-short category in MonoSdbHelper.WriteNumbers. The simplest fix for it that comes to my mind is a mechanism of InvokeMethod retries every time we detect a numeric literal that is of type int/byte/uint. With multiple parameters that classify for retry, the number of retries grows exponentially which is not the best solution.

Uncomment

// ("test.SumDefaultNegativeAndRequiredParamShortInts(-1, -120)", TNumber(-121)),
// ("test.SumDefaultNegativeAndRequiredParamShortInts(-1)", TNumber(-124)), // default: -123
// ("test.GetDefaultNegativeShortInt(-123)", TNumber(-123)),

in EvaluateMethodWithDefaultParam test. Current behavior:
"No implementation of method 'GetDefaultNegativeShortInt' matching 'test.GetDefaultNegativeShortInt(-123)' found in type DebuggerTests.DefaultParamMethods.TestClass.",

Coreclr behavior for the short int tests scenarios:
image

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Oct 5, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 5, 2023
@ilonatommy ilonatommy added arch-wasm WebAssembly architecture area-Debugger-mono and removed untriaged New issue has not been triaged by the area owner needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Oct 5, 2023
@ghost
Copy link

ghost commented Oct 5, 2023

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

We do not have a mechanism of detecting if literal is short, so both options from each case:

  • short and int
  • sbyte and byte
  • uint and ushort
    are falling into the non-short category in MonoSdbHelper.WriteNumbers. The simplest fix for it that comes to my mind is a mechanism of InvokeMethod retries every time we detect a numeric literal that is of type int/byte/uint. With multiple parameters that classify for retry, the number of retries grows exponentially which is not the best solution.

Uncomment

// ("test.SumDefaultNegativeAndRequiredParamShortInts(-1, -120)", TNumber(-121)),
// ("test.SumDefaultNegativeAndRequiredParamShortInts(-1)", TNumber(-124)), // default: -123
// ("test.GetDefaultNegativeShortInt(-123)", TNumber(-123)),

in EvaluateMethodWithDefaultParam test. Current behavior:
"No implementation of method 'GetDefaultNegativeShortInt' matching 'test.GetDefaultNegativeShortInt(-123)' found in type DebuggerTests.DefaultParamMethods.TestClass.",

Coreclr behavior for the short int tests scenarios:
image

Author: ilonatommy
Assignees: -
Labels:

arch-wasm, area-Debugger-mono

Milestone: -

@mdh1418 mdh1418 added the enhancement Product code improvement that does NOT require public API changes/additions label Mar 13, 2024
@mdh1418 mdh1418 added this to the 9.0.0 milestone Mar 13, 2024
@lewing lewing modified the milestones: 9.0.0, Future Apr 25, 2024
@thaystg
Copy link
Member

thaystg commented Aug 6, 2024

This is fixed by the new debugger.

@thaystg thaystg closed this as completed Aug 6, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Debugger-mono enhancement Product code improvement that does NOT require public API changes/additions
Projects
None yet
Development

No branches or pull requests

4 participants