Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS][non-icu] HybridGlobalization code refactoring #94162

Closed
1 of 2 tasks
mkhamoyan opened this issue Oct 30, 2023 · 1 comment · Fixed by #104082
Closed
1 of 2 tasks

[iOS][non-icu] HybridGlobalization code refactoring #94162

mkhamoyan opened this issue Oct 30, 2023 · 1 comment · Fixed by #104082
Assignees
Labels
area-System.Globalization in-pr There is an active PR which will close this issue when it is merged os-ios Apple iOS
Milestone

Comments

@mkhamoyan
Copy link
Contributor

mkhamoyan commented Oct 30, 2023

Contributes to #80689

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Oct 30, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 30, 2023
@mkhamoyan mkhamoyan self-assigned this Oct 30, 2023
@mkhamoyan mkhamoyan added os-ios Apple iOS area-System.Globalization and removed untriaged New issue has not been triaged by the area owner needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Oct 30, 2023
@ghost
Copy link

ghost commented Oct 30, 2023

Tagging subscribers to 'os-ios': @steveisok, @akoeplinger, @kotlarmilos
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Maintain consistency instead of using below implementations

    #if TARGET_MACCATALYST || TARGET_IOS || TARGET_TVOS
        if (Hybrid)
        {
            HybridImplementation
        }
        else
        {
            NotHybridImplementation
        }
    #else
        NotHybridImplementation
    #endif
    
    #if TARGET_MACCATALYST || TARGET_IOS || TARGET_TVOS
        if (Hybrid)
        {
            HybridImplementation
        }
    #endif
        NotHybridImplementation
    

    Use below code , this avoids duplicating the NotHybridImplementation logic.

    #if TARGET_MACCATALYST || TARGET_IOS || TARGET_TVOS
        if (Hybrid)
        {
            HybridImplementation
        }
        else
    #endif
        {
            NotHybridImplementation
        }
    
  • Rename IsHybridGlobalizationOnOSX to IsHybridGlobalizationOniOS https://github.com/dotnet/runtime/blob/main/src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs#L369

Contributes to #80689

Author: mkhamoyan
Assignees: mkhamoyan
Labels:

os-ios

Milestone: -

@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Jun 27, 2024
@mkhamoyan mkhamoyan added this to the 9.0.0 milestone Jul 1, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Globalization in-pr There is an active PR which will close this issue when it is merged os-ios Apple iOS
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant