Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Arm64] Add HVA ABI support for HW Intrinsics #9600

Closed
sdmaclea opened this issue Jan 25, 2018 · 1 comment · Fixed by dotnet/coreclr#23675
Closed

[Arm64] Add HVA ABI support for HW Intrinsics #9600

sdmaclea opened this issue Jan 25, 2018 · 1 comment · Fixed by dotnet/coreclr#23675
Assignees
Labels
arch-arm64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI enhancement Product code improvement that does NOT require public API changes/additions
Milestone

Comments

@sdmaclea
Copy link
Contributor

Once Short Vector ABI is supported #9599, Homogenous Short Vector Aggregates (HVA) should be supported.

One approach would be to treat these as a subclass of HFA, getHfaType() could then return TYP_SIMD8 or TYP_SIMD16. This may simplify implementation.

@CarolEidt @tannergooding @dotnet/arm64-contrib @dotnet/jit-contrib This will require a design discussion

category:reach
theme:intrinsics
skill-level:expert
cost:medium

@sdmaclea
Copy link
Contributor Author

#9578

CarolEidt referenced this issue in CarolEidt/coreclr Nov 21, 2018
Extend HFA support to support vectors as well as floating point types.
Also, fix coreclr to preserve 128-bit argument registers.

Fix #14371
Fix #16022
CarolEidt referenced this issue in CarolEidt/coreclr Dec 11, 2018
Extend HFA support to support vectors as well as floating point types.
Also, fix coreclr to preserve 128-bit argument registers.

Fix #14371
Fix #16022
CarolEidt referenced this issue in CarolEidt/coreclr Dec 12, 2018
Extend HFA support to support vectors as well as floating point types.
Also, fix coreclr to preserve 128-bit argument registers.

Fix dotnet#14371
Fix dotnet#16022
CarolEidt referenced this issue in CarolEidt/coreclr Jan 23, 2019
Extend HFA support to support vectors as well as floating point types.
Also, fix coreclr to preserve 128-bit argument registers.

Fix dotnet#14371
Fix dotnet#16022
CarolEidt referenced this issue in CarolEidt/coreclr Feb 4, 2019
Extend HFA support to support vectors as well as floating point types.
Also, fix coreclr to preserve 128-bit argument registers.

Fix #16022
CarolEidt referenced this issue in CarolEidt/coreclr Feb 5, 2019
Extend HFA support to support vectors as well as floating point types.
Also, fix coreclr to preserve 128-bit argument registers.

Fix #16022
CarolEidt referenced this issue in CarolEidt/coreclr Mar 6, 2019
Extend HFA support to support vectors as well as floating point types.
Also, fix coreclr to preserve 128-bit argument registers.

Fix #16022
CarolEidt referenced this issue in CarolEidt/coreclr Mar 28, 2019
Extend HFA support to support vectors as well as floating point types.
Also, fix coreclr to preserve 128-bit argument registers.

Fix #16022
CarolEidt referenced this issue in CarolEidt/coreclr Mar 29, 2019
Extend HFA support to support vectors as well as floating point types.
Also, fix coreclr to preserve 128-bit argument registers.

Fix #16022
CarolEidt referenced this issue in CarolEidt/coreclr Mar 29, 2019
Extend HFA support to support vectors as well as floating point types.

Fix #16022
CarolEidt referenced this issue in CarolEidt/coreclr Apr 2, 2019
Extend HFA support to support vectors as well as floating point types.

Fix #16022
CarolEidt referenced this issue in CarolEidt/coreclr Apr 3, 2019
Extend HFA support to support vectors as well as floating point types.

Fix #16022
CarolEidt referenced this issue in CarolEidt/coreclr Apr 3, 2019
Extend HFA support to support vectors as well as floating point types.

Fix #16022
CarolEidt referenced this issue in CarolEidt/coreclr Apr 3, 2019
Extend HFA support to support vectors as well as floating point types.

Fix #16022
CarolEidt referenced this issue in CarolEidt/coreclr Apr 4, 2019
Extend HFA support to support vectors as well as floating point types.

Fix #16022
CarolEidt referenced this issue in CarolEidt/coreclr Apr 4, 2019
Extend HFA support to support vectors as well as floating point types.

Fix #16022
CarolEidt referenced this issue in CarolEidt/coreclr Apr 4, 2019
Extend HFA support to support vectors as well as floating point types.

Fix #16022
CarolEidt referenced this issue in CarolEidt/coreclr Apr 5, 2019
Extend HFA support to support vectors as well as floating point types.
This requires that the JIT recognize vector types even during crossgen,
so that the ABI is supported consistently.

Fix #16022
CarolEidt referenced this issue in CarolEidt/coreclr Apr 8, 2019
Extend HFA support to support vectors as well as floating point types.
This requires that the JIT recognize vector types even during crossgen,
so that the ABI is supported consistently.

Fix #16022
CarolEidt referenced this issue in CarolEidt/coreclr Apr 9, 2019
Extend HFA support to support vectors as well as floating point types.
This requires that the JIT recognize vector types even during crossgen,
so that the ABI is supported consistently.

Fix #16022
CarolEidt referenced this issue in CarolEidt/coreclr Apr 9, 2019
Extend HFA support to support vectors as well as floating point types.
This requires that the JIT recognize vector types even during crossgen,
so that the ABI is supported consistently.

Fix #16022
CarolEidt referenced this issue in CarolEidt/coreclr Apr 10, 2019
Extend HFA support to support vectors as well as floating point types.
This requires that the JIT recognize vector types even during crossgen,
so that the ABI is supported consistently.

Fix #16022
CarolEidt referenced this issue in CarolEidt/coreclr Apr 10, 2019
Extend HFA support to support vectors as well as floating point types.
This requires that the JIT recognize vector types even during crossgen,
so that the ABI is supported consistently.

Fix #16022
CarolEidt referenced this issue in CarolEidt/coreclr Apr 13, 2019
Extend HFA support to support vectors as well as floating point types.
This requires that the JIT recognize vector types even during crossgen,
so that the ABI is supported consistently.

Fix #16022
CarolEidt referenced this issue in dotnet/coreclr Apr 16, 2019
* Support for Arm64 Vector ABI

Extend HFA support to support vectors as well as floating point types.
This requires that the JIT recognize vector types even during crossgen,
so that the ABI is supported consistently.

Also, fix and re-enable the disabled Arm64 Simd tests.

Fix #16022
@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@msftgits msftgits added this to the 3.0 milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-arm64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI enhancement Product code improvement that does NOT require public API changes/additions
Projects
None yet
3 participants