-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unix Console SetWindowSize implementation #96208
Comments
Tagging subscribers to this area: @dotnet/area-system-console Issue DetailsIn #75824 support was added for As I mentioned in #95654 (comment), I believe this is for informing the kernel about the actual size, and not for requesting a size. This matches the behavior mentioned by @adamsitnik in this comment and the referenced stack overflow answer. #75824 (comment) seems to sort of work because the kernel is told the terminal has a size of However, the window that shows the terminal doesn't show the terminal size changed. I don't think this matches the Windows semantics, where (I assume) the window would resize or show scrollbars. Based on this, I think we should not use cc @adamsitnik @danmoseley @stephentoub @dotnet/area-system-console
|
Based on the previous comment, I think we should revert #75824. @adamsitnik @danmoseley @stephentoub @dotnet/area-system-console wdyt? are there any objections/concerns? |
In #75824 support was added for
Console.SetWindowSize
on Unix by usingioctl
TIOCSWINSZ
.As I mentioned in #95654 (comment), I believe this is for informing the kernel about the actual size, and not for requesting a size.
This matches the behavior mentioned by @adamsitnik in this comment and the referenced stack overflow answer.
#75824 (comment) seems to sort of work because the kernel is told the terminal has a size of
(80, 30)
.nvim
gets that size when it asks the terminal size, and it then renders in that part of the terminal window only.However, the window that shows the terminal doesn't show the terminal size changed.
I don't think this matches the Windows semantics, where (I assume) the window would resize or show scrollbars.
Based on this, I think we should not use
TIOCSWINSZ
to implementConsole.SetWindowSize
on Unix.cc @adamsitnik @danmoseley @stephentoub @dotnet/area-system-console
The text was updated successfully, but these errors were encountered: