ObjectDisposedException from FileConfigurationProvider in net8.0

[ericstj]

Description

Configuration providers might be built multiple times from the same source. Creating and disposing one provider should not "break" the source.

Reproduction Steps

Sample user reported repro:

using Microsoft.Extensions.Configuration;

var config = new ConfigurationManager() as IConfigurationBuilder;

_ = config.AddJsonFile("./appsettings.json", optional: false, reloadOnChange: true);
//  workaround
//_ = config.AddJsonFile(config.GetFileProvider(), "./appsettings.json", optional: false, reloadOnChange: true);


// change properties after setting up Json config
_ = config.Properties.Remove("ConfigurationBuilderPropertiesObserverKey");
_ = config.Properties.Remove("SecretObserverExtensionsConfigurationBuilderPropertiesObserverKey");

Or even simpler (though more artificial):

using Microsoft.Extensions.Configuration;
using Microsoft.Extensions.Configuration.Json;

var builder = new ConfigurationBuilder();
var jsonSource = new JsonConfigurationSource()
{
    Path = "appsettings.json",
    ReloadOnChange = true
};
((IDisposable)jsonSource.Build(builder)).Dispose();
_ = jsonSource.Build(builder);

Expected behavior

Disposing one provider should not break others. Once the last provider is disposed from a source, that source should still be able to build more providers that function correctly.

Actual behavior

After disposing one provider, all others are broken, and newly built providers are also broken.

Regression?

Yes, due to #86455

Known Workarounds

Specify a file provider when adding a FileConfigurationSource.

For example, instead of

_ = config.AddJsonFile("./appsettings.json", optional: false, reloadOnChange: true);

Use this:

_ = config.AddJsonFile(config.GetFileProvider(), "./appsettings.json", optional: false, reloadOnChange: true);

Configuration

Can repro in net6, net7, net8 when using the 8.0 version of Microsoft.Extensions.Configuration.

Other information

No response

[ghost]

Tagging subscribers to this area: @dotnet/area-extensions-configuration
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Description

Configuration providers might be built multiple times from the same source. Creating and disposing one provider should not "break" the source.

Reproduction Steps

Sample user reported repro:

using Microsoft.Extensions.Configuration;

var config = new ConfigurationManager() as IConfigurationBuilder;

_ = config.AddJsonFile("./appsettings.json", optional: false, reloadOnChange: true);
//  workaround
//_ = config.AddJsonFile(config.GetFileProvider(), "./appsettings.json", optional: false, reloadOnChange: true);


// change properties after setting up Json config
_ = config.Properties.Remove("ConfigurationBuilderPropertiesObserverKey");
_ = config.Properties.Remove("SecretObserverExtensionsConfigurationBuilderPropertiesObserverKey");

Or even simpler (though more artificial):

using Microsoft.Extensions.Configuration;
using Microsoft.Extensions.Configuration.Json;

var builder = new ConfigurationBuilder();
var jsonSource = new JsonConfigurationSource()
{
    Path = "appsettings.json",
    ReloadOnChange = true
};
((IDisposable)jsonSource.Build(builder)).Dispose();
_ = jsonSource.Build(builder);

Expected behavior

Disposing one provider should not break others. Once the last provider is disposed from a source, that source should still be able to build more providers that function correctly.

Actual behavior

After disposing one provider, all others are broken, and newly built providers are also broken.

Regression?

Yes, due to #86455

Known Workarounds

Specify a file provider when adding a FileConfigurationSource.

For example, instead of

_ = config.AddJsonFile("./appsettings.json", optional: false, reloadOnChange: true);

Use this:

_ = config.AddJsonFile(config.GetFileProvider(), "./appsettings.json", optional: false, reloadOnChange: true);

Configuration

Can repro in net6, net7, net8 when using the 8.0 version of Microsoft.Extensions.Configuration.

Other information

No response

Author:	ericstj
Assignees:	-
Labels:	untriaged, area-Extensions-Configuration
Milestone:	-

[vcsjones]

Dup of #95745?

[tarekgh]

thanks @vcsjones. Yes this looks the same issue.