Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vectorize several TensorPrimitive operations for double #96452

Closed
7 tasks done
stephentoub opened this issue Jan 3, 2024 · 1 comment · Fixed by #97874
Closed
7 tasks done

Vectorize several TensorPrimitive operations for double #96452

stephentoub opened this issue Jan 3, 2024 · 1 comment · Fixed by #97874
Labels
area-System.Numerics.Tensors tenet-performance Performance related issue
Milestone
9.0.0

Comments

@stephentoub
Copy link
Member

stephentoub commented Jan 3, 2024 •
edited
Loading

#94555 added new generic versions of existing float-based TensorPrimitive methods. However, several of them are only currently vectorized when T == float. That vectorization should be extended at least to double as well:

  • Exp
  • Log
  • Log2
  • Sigmoid
  • Cosh
  • Sinh
  • Tanh

runtime/src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/TensorPrimitives.netcore.cs

Line 14 in 7e51126

// - Vectorize the trig-related functions for Ts other than floats

@stephentoub stephentoub added this to the 9.0.0 milestone Jan 3, 2024
@ghost
Copy link

ghost commented Jan 3, 2024

Tagging subscribers to this area: @dotnet/area-system-numerics-tensors
See info in area-owners.md if you want to be subscribed.

Issue Details

#94555 added new generic versions of existing float-based TensorPrimitive methods. However, several of them are only currently vectorized when T == float. That vectorization should be extended at least to double as well:

  • Exp
  • Cosh
  • Sinh
  • Tanh
  • Log
  • Log2
  • Sigmoid
Author: stephentoub
Assignees: -
Labels:

area-System.Numerics.Tensors, tenet-performance
Milestone: 9.0.0

@stephentoub stephentoub mentioned this issue Jan 3, 2024
Merged
@stephentoub stephentoub mentioned this issue Feb 2, 2024
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Feb 2, 2024
@stephentoub stephentoub mentioned this issue Feb 2, 2024
Merged
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Feb 3, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.Numerics.Tensors tenet-performance Performance related issue
Projects
None yet
Milestone
9.0.0
Development

Successfully merging a pull request may close this issue.

Vectorize TensorPrimitives.Cosh/Sinh/Tanh for double stephentoub/runtime
2 participants
@stephentoub @tannergooding