Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] AOT tests *build* timing out on Linux #97044

Closed
radical opened this issue Jan 16, 2024 · 11 comments
Closed

[wasm] AOT tests *build* timing out on Linux #97044

radical opened this issue Jan 16, 2024 · 11 comments
Labels
arch-wasm WebAssembly architecture area-Tools-ILLink .NET linker development as well as trimming analyzers blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms'

Comments

@radical
Copy link
Member

radical commented Jan 16, 2024

AOT, and sometimes EAT(EnableAggressiveTrimming) builds have been timing out on linux. The first failing rolling AOT build was 33446fb1 . Note that the corresponding EAT build did not fail.
The first EAT failure was this for 22ba7d60 .

The last successful build was 4c500699 .

The changes responsible should be 4c50069...33446fb , or on the outside - 4c50069...22ba7d6 .

Known Issue Error Message

Fill the error message using step by step known issues guidance.

{
  "ErrorMessage": "",
  "ErrorPattern": "",
  "BuildRetry": false,
  "ExcludeConsoleLog": false
}

Report

Summary

24-Hour Hit Count 7-Day Hit Count 1-Month Count
0 0 0
@radical radical added arch-wasm WebAssembly architecture blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' area-Build-mono labels Jan 16, 2024
@ghost
Copy link

ghost commented Jan 16, 2024

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

AOT, and sometimes EAT(EnableAggressiveTrimming) builds have been timing out on linux. The first failing rolling AOT build was 33446fb1 . Note that the corresponding EAT build did not fail.
The first EAT failure was this for 22ba7d60 .

The last successful build was 4c500699 .

The changes responsible should be 4c50069...33446fb , or on the outside - 4c50069...22ba7d6 .

Author: radical
Assignees: -
Labels:

arch-wasm, blocking-clean-ci, area-Build-mono

Milestone: -

@lewing
Copy link
Member

lewing commented Jan 24, 2024

@vitek-karas this appears to be a linker hang, it is difficult to see in action because AZDO clears the data when it cancels the task

@lewing lewing added the area-Tools-ILLink .NET linker development as well as trimming analyzers label Jan 24, 2024
@ghost
Copy link

ghost commented Jan 24, 2024

Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas
See info in area-owners.md if you want to be subscribed.

Issue Details

AOT, and sometimes EAT(EnableAggressiveTrimming) builds have been timing out on linux. The first failing rolling AOT build was 33446fb1 . Note that the corresponding EAT build did not fail.
The first EAT failure was this for 22ba7d60 .

The last successful build was 4c500699 .

The changes responsible should be 4c50069...33446fb , or on the outside - 4c50069...22ba7d6 .

Known Issue Error Message

Fill the error message using step by step known issues guidance.

{
  "ErrorMessage": "",
  "ErrorPattern": "",
  "BuildRetry": false,
  "ExcludeConsoleLog": false
}

Report

Summary

24-Hour Hit Count 7-Day Hit Count 1-Month Count
0 0 0
Author: radical
Assignees: -
Labels:

arch-wasm, blocking-clean-ci, untriaged, area-Build-mono, area-Tools-ILLink

Milestone: -

@lewing lewing removed the untriaged New issue has not been triaged by the area owner label Jan 24, 2024
@matouskozak
Copy link
Member

matouskozak commented Jan 24, 2024

@vitek-karas this appears to be a linker hang, it is difficult to see in action because AZDO clears the data when it cancels the task

This is the last log from LibraryTests_AOT line, before it gets cleared by Azdo
image

@vargaz
Copy link
Contributor

vargaz commented Jan 24, 2024

As a workaround, would it be possible to stop building tests in parallel in these lanes ?

@lewing
Copy link
Member

lewing commented Jan 25, 2024

We're going to try #97491 to work around this

@vitek-karas
Copy link
Member

Sorry for the delay, I tried to repro this but it's hard to tell. Locally (on a DevBox in WSL) the Full AOT build took 18+ minutes, but it fails when packing the tests (no idea why), so it hasn't really finished. But it did run all of the trimming. I didn't see any specific trimming take really long time. What we would probably need is to try this on bits before it started to fail and after. It's possible something caused trimming to be slower in general and overall the build just crosses some threshold.

@matouskozak would you be able to try to get this data?

@matouskozak
Copy link
Member

We're going to try #97491 to work around this
@lewing looks like #97491 fixed the EAT lines, but the linux LibraryTests_AOT line is still crashing (https://dev.azure.com/dnceng-public/public/_build/results?buildId=546947&view=logs&j=58dc7ccb-0414-5dd3-62a5-bf2e63258b7c&t=4105ec49-25d1-5748-9e28-e40bff74a16b)

@lewing
Copy link
Member

lewing commented Feb 5, 2024

We're going to try #97491 to work around this

@lewing looks like #97491 fixed the EAT lines, but the linux LibraryTests_AOT line is still crashing (https://dev.azure.com/dnceng-public/public/_build/results?buildId=546947&view=logs&j=58dc7ccb-0414-5dd3-62a5-bf2e63258b7c&t=4105ec49-25d1-5748-9e28-e40bff74a16b)

@matouskozak I guess we could disable the parallel build there too? Do we know if this is just excessive slowness or something else. The EAT lanes just trim without doing AOT so I wouldn't expect them to timeout

@lewing
Copy link
Member

lewing commented Feb 12, 2024

@rmarinho you mentioned you were seeing something like this in the preview 2 builds you were testing, can you try again and let us know if setting the cpus to 1 avoids your issue as well

@lewing lewing closed this as completed Apr 1, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Tools-ILLink .NET linker development as well as trimming analyzers blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms'
Projects
Archived in project
Development

No branches or pull requests

5 participants