Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono] remove runtime support for cominterop #97703

Closed
lambdageek opened this issue Jan 30, 2024 · 1 comment · Fixed by #97789
Closed

[mono] remove runtime support for cominterop #97703

lambdageek opened this issue Jan 30, 2024 · 1 comment · Fixed by #97789
Assignees
Milestone

Comments

@lambdageek
Copy link
Member

It's just dead code now: we never enable mono's built-in COM support on any configuration. If there's a need to support COM with Mono, we should instead focus on the COM interop generator.

In particular, we should delete code like:

  if (MONO_CLASS_IS_IMPORT(...)) {
   // COM stuff
   ...
  }

and

#ifndef DISABLE_COM
// other COM stuff
#endif
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Jan 30, 2024
@lambdageek lambdageek added this to the 9.0.0 milestone Jan 30, 2024
@jkoritzinsky
Copy link
Member

I'll take a look into this today.

@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jan 31, 2024
@jkoritzinsky jkoritzinsky self-assigned this Jan 31, 2024
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Feb 8, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants