Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trim warnings from ComponentModel APIs that take Type as a parameter #97841

Closed
Tracked by #4649
LakshanF opened this issue Feb 2, 2024 · 6 comments
Closed
Tracked by #4649
Labels
api-suggestion Early API idea and discussion, it is NOT ready for implementation area-System.ComponentModel linkable-framework Issues associated with delivering a linker friendly framework needs-author-action An issue or pull request that requires more info or actions from the author.

Comments

@LakshanF
Copy link
Contributor

LakshanF commented Feb 2, 2024

WinForms have calls to ComponentModel APIs with a type as a parameter that gets trim warnings due to these APIs having RequiresUnreferencedCodeAttribute. Consider making trim compatible versions of these APIs, perhaps with a feature switch set.

Note that some of these APIs have the pattern object.GetType() to get the type parameter. A fuller list of these APIs can be found,
Default_Trimmed_Warnings_wpf_attributes_excluded_ComponentModel_Type.txt

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Feb 2, 2024
@ghost
Copy link

ghost commented Feb 2, 2024

Tagging subscribers to this area: @dotnet/area-system-componentmodel
See info in area-owners.md if you want to be subscribed.

Issue Details

WinForms have calls to ComponentModel APIs with a type as a parameter that gets trim warnings due to these APIs having RequiresUnreferencedCodeAttribute. Consider making trim compatible versions of these APIs, perhaps with a feature switch set.

Author: LakshanF
Assignees: -
Labels:

area-System.ComponentModel

Milestone: -

@buyaa-n buyaa-n added the linkable-framework Issues associated with delivering a linker friendly framework label Feb 7, 2024
@ghost
Copy link

ghost commented Feb 7, 2024

Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr, @marek-safar
See info in area-owners.md if you want to be subscribed.

Issue Details

WinForms have calls to ComponentModel APIs with a type as a parameter that gets trim warnings due to these APIs having RequiresUnreferencedCodeAttribute. Consider making trim compatible versions of these APIs, perhaps with a feature switch set.

Note that some of these APIs have the pattern object.GetType() to get the type parameter. A fuller list of these APIs can be found,
Default_Trimmed_Warnings_wpf_attributes_excluded_ComponentModel_Type.txt

Author: LakshanF
Assignees: -
Labels:

area-System.ComponentModel, untriaged, linkable-framework

Milestone: -

@steveharter
Copy link
Member

If this is an API suggestion, please add that. For example, I assume to be trim compatible will will want generic versions of these methods.

@steveharter steveharter added the needs-author-action An issue or pull request that requires more info or actions from the author. label Feb 7, 2024
@ghost
Copy link

ghost commented Feb 7, 2024

This issue has been marked needs-author-action and may be missing some important information.

@steveharter steveharter added the api-suggestion Early API idea and discussion, it is NOT ready for implementation label Feb 7, 2024
@buyaa-n buyaa-n added this to the 9.0.0 milestone Feb 21, 2024
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Feb 21, 2024
@ghost ghost added the no-recent-activity label Mar 7, 2024
@ghost
Copy link

ghost commented Mar 7, 2024

This issue has been automatically marked no-recent-activity because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will remove no-recent-activity.

Copy link
Contributor

This issue will now be closed since it had been marked no-recent-activity but received no further activity in the past 14 days. It is still possible to reopen or comment on the issue, but please note that the issue will be locked if it remains inactive for another 30 days.

@dotnet-policy-service dotnet-policy-service bot removed this from the 9.0.0 milestone Mar 22, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api-suggestion Early API idea and discussion, it is NOT ready for implementation area-System.ComponentModel linkable-framework Issues associated with delivering a linker friendly framework needs-author-action An issue or pull request that requires more info or actions from the author.
Projects
None yet
Development

No branches or pull requests

4 participants
@steveharter @LakshanF @buyaa-n and others