Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Windows/x64: Regressions in System.Text.RegularExpressions.Tests.Perf_Regex_Common 2/28/2024 9:23:39 AM #99318

Closed
performanceautofiler bot opened this issue Mar 5, 2024 · 9 comments
Labels
arch-x64 area-System.Text.RegularExpressions os-windows runtime-coreclr specific to the CoreCLR runtime tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark
Milestone

Comments

@performanceautofiler
Copy link

performanceautofiler bot commented Mar 5, 2024

Run Information

Name Value
Architecture x64
OS Windows 10.0.22621
Queue OwlWindows
Baseline 8538e722e1f30c526827c7c9a6abfbee5ff3b164
Compare 5742895d7c7493dfae4ac40ab36019995d256dd1
Diff Diff
Configs CompilationMode:tiered, RunKind:micro

Regressions in System.Linq.Tests.Perf_Enumerable

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
1.60 ns 5.38 ns 3.36 0.07 False

graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Linq.Tests.Perf_Enumerable*'

Payloads

Baseline
Compare

System.Linq.Tests.Perf_Enumerable.ElementAt(input: IList)

ETL Files

Histogram

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository


@performanceautofiler performanceautofiler bot added arch-x64 os-windows runtime-coreclr specific to the CoreCLR runtime untriaged New issue has not been triaged by the area owner labels Mar 5, 2024
Copy link
Author

performanceautofiler bot commented Mar 5, 2024

Run Information

Name Value
Architecture x64
OS Windows 10.0.22621
Queue OwlWindows
Baseline 8538e722e1f30c526827c7c9a6abfbee5ff3b164
Compare 4c90107c80a7f8eb2f38f1494b4e17d48d5c7828
Diff Diff
Configs CompilationMode:tiered, RunKind:micro

Regressions in System.Text.RegularExpressions.Tests.Perf_Regex_Common

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
80.90 ns 98.95 ns 1.22 0.20 False

graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Text.RegularExpressions.Tests.Perf_Regex_Common*'

Payloads

Baseline
Compare

System.Text.RegularExpressions.Tests.Perf_Regex_Common.Backtracking(Options: Compiled)

ETL Files

Histogram

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository


Run Information

Name Value
Architecture x64
OS Windows 10.0.22621
Queue OwlWindows
Baseline d06ebfee1cfd1ef437784013e93ccfcd31334ac0
Compare 5742895d7c7493dfae4ac40ab36019995d256dd1
Diff Diff
Configs CompilationMode:tiered, RunKind:micro

Regressions in Benchstone.BenchF.Whetsto

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
573.27 ms 614.59 ms 1.07 0.01 False

graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'Benchstone.BenchF.Whetsto*'

Payloads

Baseline
Compare

Benchstone.BenchF.Whetsto.Test

ETL Files

Histogram

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

@DrewScoggins DrewScoggins transferred this issue from dotnet/perf-autofiling-issues Mar 5, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Mar 5, 2024
@DrewScoggins DrewScoggins changed the title [Perf] Windows/x64: 22 Regressions on 2/28/2024 9:23:39 AM [Perf] Windows/x64: Regressions in System.Linq.Tests.Perf_Enumerable 2/28/2024 9:23:39 AM Mar 5, 2024
@DrewScoggins DrewScoggins added tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark labels Mar 5, 2024
@DrewScoggins
Copy link
Member

This is the range of commits, but there is nothing that seems to jump out, but we are seeing this regression across all of our configurations.

d06ebfe...e2acec9

@jeffschwMSFT
Copy link
Member

perhaps there is more than 1 reason for these regressions. given there is a Linq regression, I think that this change should be considered: e101ae2

@ghost
Copy link

ghost commented Mar 6, 2024

Tagging subscribers to this area: @dotnet/area-system-linq
See info in area-owners.md if you want to be subscribed.

Issue Details

Run Information

Name Value
Architecture x64
OS Windows 10.0.22621
Queue OwlWindows
Baseline 8538e722e1f30c526827c7c9a6abfbee5ff3b164
Compare 5742895d7c7493dfae4ac40ab36019995d256dd1
Diff Diff
Configs CompilationMode:tiered, RunKind:micro

Regressions in System.Linq.Tests.Perf_Enumerable

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
1.60 ns 5.38 ns 3.36 0.07 False

graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Linq.Tests.Perf_Enumerable*'

Payloads

Baseline
Compare

System.Linq.Tests.Perf_Enumerable.ElementAt(input: IList)

ETL Files

Histogram

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository


Author: performanceautofiler[bot]
Assignees: -
Labels:

area-System.Linq, os-windows, tenet-performance, tenet-performance-benchmarks, arch-x64, untriaged, runtime-coreclr, needs-area-label

Milestone: -

@stephentoub
Copy link
Member

perhaps there is more than 1 reason for these regressions. given there is a Linq regression, I think that this change should be considered: e101ae2

This could be related to the ElementAt test, and I can take a look at that one to see if I can repro. I don't think it could be related to the other two.

@eiriktsarpalis
Copy link
Member

Presumably fixed by #99437

@dotnet-policy-service dotnet-policy-service bot removed the untriaged New issue has not been triaged by the area owner label Mar 11, 2024
@stephentoub
Copy link
Member

@eiriktsarpalis, what about the other tests?

@eiriktsarpalis
Copy link
Member

I hadn't noticed that more regressions had been appended by the bot as a comment. Is that common?

@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Mar 11, 2024
@eiriktsarpalis eiriktsarpalis added area-System.Text.RegularExpressions and removed area-System.Linq untriaged New issue has not been triaged by the area owner labels Mar 11, 2024
@eiriktsarpalis eiriktsarpalis changed the title [Perf] Windows/x64: Regressions in System.Linq.Tests.Perf_Enumerable 2/28/2024 9:23:39 AM [Perf] Windows/x64: Regressions in System.Text.RegularExpressions.Tests.Perf_Regex_Common 2/28/2024 9:23:39 AM Mar 11, 2024
@vcsjones vcsjones removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Mar 12, 2024
@steveharter steveharter added this to the 9.0.0 milestone Mar 27, 2024
@stephentoub
Copy link
Member

All tests look to be back in normal ranges.

@stephentoub stephentoub closed this as not planned Won't fix, can't repro, duplicate, stale Jun 27, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-x64 area-System.Text.RegularExpressions os-windows runtime-coreclr specific to the CoreCLR runtime tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark
Projects
None yet
Development

No branches or pull requests

6 participants