Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HTTP/2] Reading data assert #99494

Closed
ManickaP opened this issue Mar 10, 2024 · 3 comments · Fixed by #99502
Closed

[HTTP/2] Reading data assert #99494

ManickaP opened this issue Mar 10, 2024 · 3 comments · Fixed by #99502
Assignees
Milestone

Comments

@ManickaP
Copy link
Member

https://github.com/dotnet/runtime/blame/a566fd59fc34d3f73da1b8eeaab613ab0c1fc9b5/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http2Stream.cs#L1127-L1127

With a recent repro from an internal customer, I'm hitting assert at this line as I'm testing with Debug build. I can share repro privately.

Copy link
Contributor

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Mar 10, 2024
@ManickaP ManickaP added this to the 9.0.0 milestone Mar 10, 2024
@ManickaP ManickaP added bug and removed untriaged New issue has not been triaged by the area owner labels Mar 10, 2024
@ManickaP
Copy link
Member Author

So the problem is the server sending DATA frame containing only padding and no data at all. We do not handle this case at all and we will unblock the user pending read with 0-bytes read (despite not being at the end of the stream).

@ManickaP ManickaP self-assigned this Mar 10, 2024
@karelz karelz modified the milestones: 9.0.0, 8.0.x Apr 2, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 3, 2024
@karelz
Copy link
Member

karelz commented May 14, 2024

Fixed in main (9.0) in PR #99502, in 6.0.30 in PR #99678 and in 8.0.5 in PR #99677

@karelz karelz modified the milestones: 8.0.x, 6.0.x May 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants