SafeFileHandle.ThreadPoolValueTaskSource made ligher by one field #113435
Conversation
dotnet-policy-service
bot
added
the
community-contribution
|
This is my first PR to the mighty |
|
Tagging subscribers to this area: @dotnet/area-system-io |
| Debug.Assert(_readScatterBuffers != null); | ||
| result = RandomAccess.ReadScatterAtOffset(_fileHandle, _readScatterBuffers, _fileOffset); | ||
| Debug.Assert(_buffers != null); | ||
| result = RandomAccess.ReadScatterAtOffset(_fileHandle, Unsafe.As<IReadOnlyList<Memory<byte>>>(_buffers), _fileOffset); |
There was a problem hiding this comment.
It is not ok to use Unsafe.As just because of you can. In fact, we are working on eliminating Unsafe.As and similar uses to make the runtime core more secure by construction.
There was a problem hiding this comment.
Clearly, one cannot use it just like that. The reasoning was that the setting of the field is made only in one of two scatter/gather methods and this is aligned with setting the _operation. In my opinion it's similar to the case in ValueTask which also casts As according to the "type" held in another filed.
There was a problem hiding this comment.
Maybe you could make a regular cast; the always-true type check will be dwarfed by the cost of the subsequent I/O operation.
Let me spin some tomorrow and share what it does. |
This PR combines gather/scatter fields in
SafeFileHandle.ThreadPoolValueTaskSourceinto one. This saves one reference field inTPVTS.