[clr-ios] Run full test suite on Apple mobile platforms #123033

Copilot · 2026-01-30T14:10:35Z

In this MacCatalyst CoreCLR libraries job, the buildArgs no longer pass /p:BuildTestsOnHelix=true. For mobile targets (maccatalyst is TargetsMobile=true), ArchiveTests only runs when BuildTestsOnHelix=true (see eng/testing/tests.targets:92-95), so this job is likely to skip producing the test archives needed by the subsequent helix.yml step. Add /p:BuildTestsOnHelix=true to the buildArgs (or otherwise ensure BuildTestsOnHelix is set during the build) so archiving and Helix submission work consistently.

Suggested change

buildArgs: -s clr+clr.runtime+libs+packs+libs.tests -c $(_BuildConfig) /p:ArchiveTests=true $(_runSmokeTestsOnlyArg) /p:DevTeamProvisioning=adhoc /p:RunAOTCompilation=false /p:UseMonoRuntime=false /p:MonoForceInterpreter=false /p:UseNativeAOTRuntime=false

buildArgs: -s clr+clr.runtime+libs+packs+libs.tests -c $(_BuildConfig) /p:ArchiveTests=true /p:BuildTestsOnHelix=true $(_runSmokeTestsOnlyArg) /p:DevTeamProvisioning=adhoc /p:RunAOTCompilation=false /p:UseMonoRuntime=false /p:MonoForceInterpreter=false /p:UseNativeAOTRuntime=false

Copilot · 2026-01-30T08:15:19Z

This block’s comment says runtime-async is enabled for “all .NET 11+ test projects”, but the condition now excludes Android and Apple mobile targets. Please update the comment to reflect these exclusions (or explain why these platforms are intentionally opted out).

Copilot · 2026-01-30T14:10:35Z

These two ItemGroups add the same ProjectReference entries under overlapping conditions. If a CoreCLR iOS run is ever configured with RunAOTCompilation=true (or if RunAOTCompilation is set globally), the same projects will be referenced twice. Consider consolidating into a single ItemGroup with a mutually exclusive condition, or guard the first ItemGroup to exclude CoreCLR (e.g., add a RuntimeFlavor check) to avoid duplicate references and keep this section maintainable.

-Original file line number
+Diff line change
@@ Expand Up / @@ -196,7 +196,7 @@ jobs: @@
           testGroup: innerloop
           nameSuffix: AllSubsets_CoreCLR_RuntimeTests
           buildArgs: -s clr+libs -c $(_BuildConfig)
-          timeoutInMinutes: 240
+          timeoutInMinutes: 480
           # extra steps, run tests
           extraVariablesTemplates:
             - template: /eng/pipelines/common/templates/runtimes/test-variables.yml
@@ Expand All / @@ -206,9 +206,9 @@ jobs: @@
             - template: /eng/pipelines/common/templates/runtimes/build-runtime-tests-and-send-to-helix.yml
               parameters:
                 creator: dotnet-bot
-                testBuildArgs: tree baseservices /p:DevTeamProvisioning=- /p:RunAOTCompilation=false /p:UseMonoRuntime=false /p:MonoForceInterpreter=false /p:UseNativeAOTRuntime=false /p:BuildTestsOnHelix=false
+                testBuildArgs: /p:DevTeamProvisioning=- /p:RunAOTCompilation=false /p:UseMonoRuntime=false /p:MonoForceInterpreter=false /p:UseNativeAOTRuntime=false /p:BuildTestsOnHelix=true
                 testRunNamePrefixSuffix: CoreCLR_$(_BuildConfig)
-                extraHelixArguments: /p:NeedsToBuildAppsOnHelix=false
+                extraHelixArguments: /p:NeedsToBuildAppsOnHelix=true
     #
     # Build the whole product using CoreCLR R2R and run library tests
@@ Expand All / @@ -234,12 +234,13 @@ jobs: @@
             value: $[ stageDependencies.EvaluatePaths.evaluate_paths.outputs['SetPathVars_tools_illink.containsChange'] ]
         jobParameters:
           testGroup: innerloop
-          nameSuffix: AllSubsets_CoreCLR_Smoke
-          buildArgs: -s clr+clr.runtime+libs+packs+libs.tests -c $(_BuildConfig) /p:ArchiveTests=true /p:DevTeamProvisioning=- /p:RunAOTCompilation=false /p:UseMonoRuntime=false /p:MonoForceInterpreter=false /p:BuildTestsOnHelix=false /p:UseNativeAOTRuntime=false /p:RunSmokeTestsOnly=true
-          timeoutInMinutes: 120
+          nameSuffix: AllSubsets_CoreCLR
+          buildArgs: -s clr+clr.runtime+libs+packs+libs.tests -c $(_BuildConfig) /p:ArchiveTests=true /p:DevTeamProvisioning=- /p:RunAOTCompilation=false /p:UseMonoRuntime=false /p:MonoForceInterpreter=false /p:UseNativeAOTRuntime=false $(_runSmokeTestsOnlyArg) /p:BuildTestsOnHelix=true /p:EnableAdditionalTimezoneChecks=true /p:UsePortableRuntimePack=false
+          timeoutInMinutes: 480
           # extra steps, run tests
           postBuildSteps:
             - template: /eng/pipelines/libraries/helix.yml
               parameters:
                 creator: dotnet-bot
                 testRunNamePrefixSuffix: CoreCLR_$(_BuildConfig)
+                extraHelixArguments: /p:NeedsToBuildAppsOnHelix=true

-Original file line number
+Diff line change
@@ Expand Up / @@ -164,7 +164,7 @@ jobs: @@
           testGroup: innerloop
           nameSuffix: AllSubsets_CoreCLR_RuntimeTests
           buildArgs: -s clr+libs -c $(_BuildConfig)
-          timeoutInMinutes: 240
+          timeoutInMinutes: 480
           # extra steps, run tests
           extraVariablesTemplates:
             - template: /eng/pipelines/common/templates/runtimes/test-variables.yml
@@ Expand All / @@ -174,12 +174,12 @@ jobs: @@
             - template: /eng/pipelines/common/templates/runtimes/build-runtime-tests-and-send-to-helix.yml
               parameters:
                 creator: dotnet-bot
-                testBuildArgs: tree baseservices /p:DevTeamProvisioning=- /p:RunAOTCompilation=false /p:UseMonoRuntime=false /p:MonoForceInterpreter=false /p:UseNativeAOTRuntime=false /p:BuildTestsOnHelix=false
+                testBuildArgs: /p:DevTeamProvisioning=- /p:RunAOTCompilation=false /p:UseMonoRuntime=false /p:MonoForceInterpreter=false /p:UseNativeAOTRuntime=false /p:BuildTestsOnHelix=true
                 testRunNamePrefixSuffix: CoreCLR_$(_BuildConfig)
-                extraHelixArguments: /p:NeedsToBuildAppsOnHelix=false
+                extraHelixArguments: /p:NeedsToBuildAppsOnHelix=true
     #
-    # Build the whole product using CoreCLR R2R and run library tests
+    # Build the whole product using CoreCLR R2R and run libraries tests
     #
     - template: /eng/pipelines/common/platform-matrix.yml
       parameters:
@@ Expand All / @@ -203,12 +203,13 @@ jobs: @@
             value: $[ stageDependencies.EvaluatePaths.evaluate_paths.outputs['SetPathVars_tools_illink.containsChange'] ]
         jobParameters:
           testGroup: innerloop
-          nameSuffix: AllSubsets_CoreCLR_Smoke
-          buildArgs: -s clr+clr.runtime+libs+packs+libs.tests -c $(_BuildConfig) /p:ArchiveTests=true /p:DevTeamProvisioning=- /p:RunAOTCompilation=false /p:UseMonoRuntime=false /p:MonoForceInterpreter=false /p:BuildTestsOnHelix=false /p:UseNativeAOTRuntime=false /p:RunSmokeTestsOnly=true
-          timeoutInMinutes: 120
+          nameSuffix: AllSubsets_CoreCLR
+          buildArgs: -s clr+clr.runtime+libs+packs+libs.tests -c $(_BuildConfig) /p:ArchiveTests=true $(_runSmokeTestsOnlyArg) /p:RunAOTCompilation=false /p:UseMonoRuntime=false /p:MonoForceInterpreter=false /p:UseNativeAOTRuntime=false /p:BuildTestsOnHelix=true
+          timeoutInMinutes: 480
           # extra steps, run tests
           postBuildSteps:
             - template: /eng/pipelines/libraries/helix.yml
               parameters:
                 creator: dotnet-bot
                 testRunNamePrefixSuffix: CoreCLR_$(_BuildConfig)
+                extraHelixArguments: /p:NeedsToBuildAppsOnHelix=true

-Original file line number
+Diff line change
@@ Expand Up / @@ -1083,7 +1083,7 @@ extends: @@
                         eq(variables['isRollingBuild'], true))
           #
-          # Build the whole product using CoreCLR and run functional tests
+          # Build the whole product using CoreCLR and run libraries tests
           #
           - template: /eng/pipelines/common/platform-matrix.yml
             parameters:
@@ Expand All / @@ -1105,7 +1105,7 @@ extends: @@
               jobParameters:
                 testGroup: innerloop
                 nameSuffix: AllSubsets_CoreCLR_Smoke
-                buildArgs: -s clr+clr.runtime+libs+packs+libs.tests -c $(_BuildConfig) /p:ArchiveTests=true /p:DevTeamProvisioning=- /p:RunAOTCompilation=false /p:UseMonoRuntime=false /p:MonoForceInterpreter=false /p:BuildTestsOnHelix=false /p:UseNativeAOTRuntime=false /p:RunSmokeTestsOnly=true
+                buildArgs: -s clr+clr.runtime+libs+packs+libs.tests -c $(_BuildConfig) /p:ArchiveTests=true /p:DevTeamProvisioning=- /p:RunAOTCompilation=false /p:UseMonoRuntime=false /p:MonoForceInterpreter=false /p:UseNativeAOTRuntime=false /p:RunSmokeTestsOnly=true /p:BuildTestsOnHelix=true /p:UsePortableRuntimePack=false
                 timeoutInMinutes: 120
                 condition: >-
                   or(
@@ Expand All / @@ -1119,6 +1119,7 @@ extends: @@
                     parameters:
                       creator: dotnet-bot
                       testRunNamePrefixSuffix: CoreCLR_$(_BuildConfig)
+                      extraHelixArguments: /p:NeedsToBuildAppsOnHelix=true
                       condition: >-
                         or(
                         eq(variables['librariesContainsChange'], true),
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up / @@ -16,7 +16,7 @@ @@
         <!-- running aot-helix tests locally, so we can test with the same project file as CI -->
         <_AOTBuildCommand Condition="'$(ContinuousIntegrationBuild)' != 'true'">$(_AOTBuildCommand) /p:RuntimeSrcDir=$(RepoRoot) /p:RuntimeConfig=$(Configuration)</_AOTBuildCommand>
         <!-- The command below sets default properties for runtime and library tests -->
-        <_AOTBuildCommand>$(_AOTBuildCommand) /p:XHARNESS_EXECUTION_DIR=&quot;$XHARNESS_EXECUTION_DIR&quot; /p:RunAOTCompilation=$(RunAOTCompilation) /p:UseNativeAOTRuntime=$(UseNativeAOTRuntime) /p:TargetOS=$(TargetOS) /p:TargetArchitecture=$(TargetArchitecture) /p:MonoForceInterpreter=$(MonoForceInterpreter) /p:MonoEnableLLVM=true /p:DevTeamProvisioning=$(DevTeamProvisioning) /p:UsePortableRuntimePack=$(UsePortableRuntimePack) /p:Configuration=$(Configuration)</_AOTBuildCommand>
+        <_AOTBuildCommand>$(_AOTBuildCommand) /p:XHARNESS_EXECUTION_DIR=&quot;$XHARNESS_EXECUTION_DIR&quot; /p:RunAOTCompilation=$(RunAOTCompilation) /p:UseNativeAOTRuntime=$(UseNativeAOTRuntime) /p:TargetOS=$(TargetOS) /p:TargetArchitecture=$(TargetArchitecture) /p:UseMonoRuntime=$(UseMonoRuntime) /p:MonoForceInterpreter=$(MonoForceInterpreter) /p:MonoEnableLLVM=true /p:DevTeamProvisioning=$(DevTeamProvisioning) /p:UsePortableRuntimePack=$(UsePortableRuntimePack) /p:Configuration=$(Configuration)</_AOTBuildCommand>
         <_AOTBuildCommand Condition="'$(NativeLib)' != ''">$(_AOTBuildCommand) /p:NativeLib=$(NativeLib) /p:BundlesResources=$(BundlesResources) /p:ForceLibraryModeGenerateAppBundle=$(ForceLibraryModeGenerateAppBundle)</_AOTBuildCommand>
         <_AOTBuildCommand>$(_AOTBuildCommand) </_AOTBuildCommand>
@@ Expand All / @@ -38,10 +38,8 @@ @@
         <RunScriptCommand>$(_AOTBuildCommand) $(_AfterBuildCommands)</RunScriptCommand>
       </PropertyGroup>
-      <Import Project="$(MonoProjectRoot)\msbuild\common\LibraryBuilder.props"
-              Condition="'$(BuildTestsOn)' == 'local'" />
-      <Import Project="$(MonoProjectRoot)\msbuild\apple\build\AppleBuild.props"
-              Condition="'$(BuildTestsOn)' == 'local'" />
+      <Import Project="$(MonoProjectRoot)\msbuild\common\LibraryBuilder.props" />
+      <Import Project="$(MonoProjectRoot)\msbuild\apple\build\AppleBuild.props" />
       <Import Project="$(MonoProjectRoot)\msbuild\apple\build\AppleBuild.InTree.targets"
               Condition="'$(BuildTestsOn)' == 'local'" />
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up / @@ -6,6 +6,8 @@ @@
         and '$(UseNativeAOTRuntime)' != 'true'
         and '$(TargetOS)' != 'browser'
         and '$(TargetOS)' != 'wasi'
+        and '$(TargetOS)' != 'android'
+        and '$(TargetsAppleMobile)' != 'true'
         and '$(RuntimeFlavor)' != 'Mono'
         and '$(UseRuntimeAsync)' != 'false'">
         <EnablePreviewFeatures>true</EnablePreviewFeatures>
@@ Expand Down @@

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[clr-ios] Run full test suite on Apple mobile platforms #123033

Uh oh!

Diff view

Diff view

There are no files selected for viewing

Copilot AI Jan 30, 2026

Uh oh!

Copilot AI Jan 30, 2026

Uh oh!

Copilot AI Jan 30, 2026

Uh oh!

Uh oh!

-Original file line number
+Diff line change
@@ Expand Up / @@ -702,7 +702,14 @@ @@
       </ItemGroup>
       <ItemGroup Condition="'$(ArchiveTests)' == 'true' and '$(TargetOS)' == 'ios' and '$(RunAOTCompilation)' == 'true'">
-        <!-- Only System.Runtime tests on iOS for now -->
+        <ProjectReference Include="$(MSBuildThisFileDirectory)System.Runtime\tests\System.Runtime.Tests\System.Runtime.Tests.csproj" />
+        <ProjectReference Include="$(RepoRoot)\src\tests\FunctionalTests\iOS\Device\**\*.Test.csproj"
+                          Exclude="@(ProjectExclusions)"
+                          BuildInParallel="false" />
+      </ItemGroup>
+      <ItemGroup Condition="'$(ArchiveTests)' == 'true' and '$(TargetOS)' == 'ios' and '$(RuntimeFlavor)' == 'CoreCLR' and '$(UseNativeAOTRuntime)' != 'true'">
         <ProjectReference Include="$(MSBuildThisFileDirectory)System.Runtime\tests\System.Runtime.Tests\System.Runtime.Tests.csproj" />
         <ProjectReference Include="$(RepoRoot)\src\tests\FunctionalTests\iOS\Device\**\*.Test.csproj"
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up / @@ -61,6 +61,7 @@ @@
         <LibraryBuilderDir>$([MSBuild]::NormalizeDirectory($(BuildBaseDir), 'LibraryBuilder'))</LibraryBuilderDir>
         <MonoAotCrossDir>$([MSBuild]::NormalizePath($(BuildBaseDir), 'cross'))</MonoAotCrossDir>
+        <Crossgen2InBuildDir>$([MSBuild]::NormalizeDirectory('$(BuildBaseDir)', 'crossgen2'))</Crossgen2InBuildDir>
         <CoreCLRILCompilerDir>$([MSBuild]::NormalizeDirectory('$(BuildBaseDir)', 'ilc'))</CoreCLRILCompilerDir>
         <ILCompilerTargetsDir>$([MSBuild]::NormalizePath('$(BuildBaseDir)', 'BuildIntegration'))</ILCompilerTargetsDir>
         <ILCompilerTargetsPath>$([MSBuild]::NormalizePath('$(ILCompilerTargetsDir)', 'Microsoft.DotNet.ILCompiler.SingleEntry.targets'))</ILCompilerTargetsPath>
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up / @@ -2,7 +2,7 @@ @@
       <!-- Tracking issue: https://github.com/dotnet/runtime/issues/119006
            Override the ResolveReadyToRunCompilers target to use the in-build crossgen2.
            This needs to be imported after SDK targets, so any project requiring this should set AfterMicrosoftNETSdkTargets -->
-      <Target Name="ResolveReadyToRunCompilers" Condition="'$(PublishReadyToRun)' == true" DependsOnTargets="ResolveRuntimeFilesFromLocalBuild">
+      <Target Name="ResolveReadyToRunCompilers" Condition="'$(PublishReadyToRun)' == true" DependsOnTargets="ResolveRuntimeFilesFromLocalBuild;ResolveLibrariesRuntimeFilesFromLocalBuild">
         <PropertyGroup>
           <Crossgen2Path>$([MSBuild]::NormalizePath('$(Crossgen2InBuildDir)', 'crossgen2$(ExeSuffix)'))</Crossgen2Path>
         </PropertyGroup>
@@ Expand All / @@ -13,5 +13,12 @@ @@
                          TargetOS="$(TargetOS)"
                          PerfmapFormatVersion="$(PublishReadyToRunPerfmapFormatVersion)"/>
         </ItemGroup>
+        <!-- Crossgen2 requires references to all runtime pack assemblies including System.Private.CoreLib.
+             Add managed assemblies from the local runtime pack as references for Crossgen2. -->
+        <ItemGroup>
+          <_ReadyToRunImplementationAssemblies Include="@(RuntimeFiles)" Condition="'%(RuntimeFiles.Extension)' == '.dll'" ReferenceOnly="true" />
+          <_ReadyToRunImplementationAssemblies Include="@(LibrariesRuntimeFiles)" Condition="'%(LibrariesRuntimeFiles.Extension)' == '.dll'" ReferenceOnly="true" />
+        </ItemGroup>
       </Target>
     </Project>

-Original file line number
+Diff line change
@@ Expand Up / @@ -62,7 +62,7 @@ @@
       <Import Project="$(Crossgen2SdkOverridePropsPath)" Condition="'$(PublishReadyToRun)' == 'true' and '$(UseMonoRuntime)' != 'true' and '$(UseNativeAOTRuntime)' != 'true' and '$(Crossgen2SdkOverridePropsPath)' != '' and Exists('$(Crossgen2SdkOverridePropsPath)')" />
       <PropertyGroup Condition="'$(PublishReadyToRun)' == 'true' and '$(UseMonoRuntime)' != 'true' and '$(UseNativeAOTRuntime)' != 'true'">
         <AfterMicrosoftNETSdkTargets Condition="'$(Crossgen2SdkOverrideTargetsPath)' != '' and Exists('$(Crossgen2SdkOverrideTargetsPath)')">$(AfterMicrosoftNETSdkTargets);$(Crossgen2SdkOverrideTargetsPath)</AfterMicrosoftNETSdkTargets>
-        <AfterMicrosoftNETSdkTargets>$(AfterMicrosoftNETSdkTargets);$(MonoProjectRoot)\msbuild\apple\build\AppleBuild.ReadyToRun.targets</AfterMicrosoftNETSdkTargets>
+        <AfterMicrosoftNETSdkTargets>$(AfterMicrosoftNETSdkTargets);$(MSBuildThisFileDirectory)AppleBuild.ReadyToRun.targets</AfterMicrosoftNETSdkTargets>
       </PropertyGroup>
       <Import Condition="'$(UseNativeAOTRuntime)' != 'true' and '$(UseMonoRuntime)' != 'false'" Project="$(_CommonTargetsDir)CommonMobileBuild.props" />
@@ Expand Down @@

-Original file line number
+Diff line change
@@ -1,10 +1,10 @@
     <Project>
-      <Target Name="_MonoReadAvailableComponentsManifest">
+      <Target Name="_MonoReadAvailableComponentsManifest" Condition="'$(UseMonoRuntime)' == 'true'">
         <Error Condition="'%(ResolvedFrameworkReference.Identity)' == 'Microsoft.NETCore.App' and '%(ResolvedFrameworkReference.RuntimePackPath)' == '' and '$(_MonoRuntimeComponentManifestJsonFilePath)' == ''"
                Text="Empty ResolveFrameworkReference.RuntimePackPath while trying to read runtime components manifest. ResolvedFrameworkReference available: @(ResolvedFrameworkReference -> '{ %(Identity), RuntimePackPath: %(RuntimePackPath) }')" />
         <PropertyGroup>
-          <_MonoRuntimeComponentManifestJsonFilePath
+          <_MonoRuntimeComponentManifestJsonFilePath
             Condition="'$(_MonoRuntimeComponentManifestJsonFilePath)' == '' and '%(ResolvedFrameworkReference.Identity)' == 'Microsoft.NETCore.App'">$([MSBuild]::NormalizePath('%(RuntimePackPath)', 'runtimes', '$(RuntimeIdentifier)', 'build', 'RuntimeComponentManifest.json'))</_MonoRuntimeComponentManifestJsonFilePath>
         </PropertyGroup>
@@ Expand Down Expand Up / @@ -69,7 +69,7 @@ @@
              Such a workload should then use DontLink to exclude the disabled components.  On the other
              hand a workload that explicitly picks the native libraries from native/ should use
              _MonoRuntimeComponentLink to pick just the needed runtime component artifacts. -->
         <!-- The target also depends on the following items that are provided by the component-manifest.props from the runtime pack -->
         <!-- _MonoRuntimeComponentLinking item list: either 'dynamic' or 'static' (defined by the runtime for each possible RuntimeIdentifier) -->
         <!-- _MonoRuntimeComponentName item list: the components for the current RuntimeIdentifier (defined by _MonoComputeAvailableComponentDefinitions above ) -->
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up / @@ -981,6 +981,8 @@ @@
                                                                                     Destination="build/BuildIntegration" />
           <HelixCorrelationPayload Include="$(CoreCLRAotSdkDir)"                     Condition="'$(RuntimeFlavor)' == 'coreclr'"
                                                                                     Destination="build/aotsdk" />
+          <HelixCorrelationPayload Include="$(Crossgen2InBuildDir)"                  Condition="'$(RuntimeFlavor)' == 'coreclr'"
+                                                                                    Destination="build/crossgen2" />
           <HelixCorrelationPayload Include="$(ToolsILLinkDir)"                       Destination="build" />
         </ItemGroup>
@@ Expand Down @@

[clr-ios] Run full test suite on Apple mobile platforms #123033

Are you sure you want to change the base?

Uh oh!

[clr-ios] Run full test suite on Apple mobile platforms #123033

Uh oh!

Uh oh!

Diff view

Diff view

There are no files selected for viewing

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!