Skip to content

Add early return in TryGetLast for empty results. #123306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephentoub merged 2 commits into from
Jan 18, 2026
Merged

Add early return in TryGetLast for empty results. #123306

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b76bd7b
Add early return in TryGetLast for empty results.
prozolic Jan 17, 2026
511e2e8
Update src/libraries/System.Linq/src/System/Linq/SkipTake.SpeedOpt.cs
prozolic Jan 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/libraries/System.Linq/src/System/Linq/SkipTake.SpeedOpt.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,8 +441,14 @@ public override Iterator<TSource> Take(int count)
{
if (_source is Iterator<TSource> iterator &&
iterator.GetCount(onlyIfCheap: true) is int count &&
count > _minIndexInclusive)
count >= 0)
{
if (count <= _minIndexInclusive)
{
found = false;
return default;
}

// If there's no upper bound, or if there are fewer items in the list
// than the upper bound allows, just return the last element of the list.
// Otherwise, get the element at the upper bound.
Expand Down
Loading