Skip to content

Infrastructure: Disable full assembly signing by default on non-Windows platforms #123401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aw0lid wants to merge 3 commits into
base: main
Choose a base branch
from
+3 −0
Open

Infrastructure: Disable full assembly signing by default on non-Windows platforms #123401

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0c4ce25
Disable full signing by default on non-Windows platforms.
aw0lid Jan 20, 2026
bbbe647
Disable full signing by default on non-Windows and workaround F# comp…
aw0lid Jan 21, 2026
783e365
Update src/libraries/Directory.Build.props
aw0lid Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/libraries/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@
<PropertyGroup>
<!-- Default any assembly not specifying a key to use the Open Key -->
<StrongNameKeyId>Open</StrongNameKeyId>
<FullAssemblySigningSupported Condition="'$(FullAssemblySigningSupported)' == '' and '$(OS)' != 'Windows_NT'">false</FullAssemblySigningSupported>
Copy link
Member

@jkotas jkotas Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to have this in the top-level Directory.Build.props file so that it applied to the whole repo?

<SignAssembly Condition="'$(FullAssemblySigningSupported)' == 'false' and '$(MSBuildProjectExtension)' == '.fsproj'">false</SignAssembly>
<PublicSign Condition="'$(FullAssemblySigningSupported)' == 'false' and '$(MSBuildProjectExtension)' == '.fsproj'">false</PublicSign>
<!-- Microsoft.Extensions projects have a separate StrongNameKeyId -->
<StrongNameKeyId Condition="$(MSBuildProjectName.StartsWith('Microsoft.Extensions.'))">MicrosoftAspNetCore</StrongNameKeyId>
<!-- We can't generate an apphost without restoring the targeting pack. -->
Expand Down