Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] Bring AggressiveOptimization back on AwaitUnsafeOnCompleted #90980

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 23, 2023

Backport of #90966 to release/8.0

/cc @EgorBo

Customer Impact

Fixes a small working set regression in TE benchmarks introduced by #90496

Testing

Tested locally via crank

Risk

No risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

@ghost
Copy link

ghost commented Aug 23, 2023

Tagging subscribers to this area: @dotnet/area-system-runtime-compilerservices
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #90966 to release/8.0

/cc @EgorBo

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-System.Runtime.CompilerServices

Milestone: -

@EgorBo EgorBo requested a review from jkotas August 23, 2023 09:37
@carlossanlop
Copy link
Member

@jeffschwMSFT do you approve?

Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. we can merge once ready

@jeffschwMSFT jeffschwMSFT added the Servicing-approved Approved for servicing release label Aug 23, 2023
@carlossanlop carlossanlop merged commit 3155448 into release/8.0 Aug 23, 2023
171 of 173 checks passed
@carlossanlop carlossanlop deleted the backport/pr-90966-to-release/8.0 branch August 23, 2023 21:36
@ghost ghost locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants