Skip to content

Fix Optimization Profile read#124497

Merged
jkotas merged 1 commit intodotnet:mainfrom
FixBo:main
Feb 18, 2026
Merged

Fix Optimization Profile read#124497
jkotas merged 1 commit intodotnet:mainfrom
FixBo:main

Conversation

@FixBo
Copy link
Contributor

@FixBo FixBo commented Feb 17, 2026

fread returns the number of elements read, not the number of bytes.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Feb 17, 2026
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

@huoyaoyuan
Copy link
Member

Thanks. Can you please check other fread instances as well?

@FixBo
Copy link
Contributor Author

FixBo commented Feb 17, 2026

The others looks correct in your PR

I found one in old mono code

size_t len = fread(buffer_orig, fsize, 1, f);

@FixBo
Copy link
Contributor Author

FixBo commented Feb 18, 2026

@jkotas this is one more fix after #116203

@jkotas
Copy link
Member

jkotas commented Feb 18, 2026

/ba-g timeout

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jkotas jkotas merged commit d69bdbe into dotnet:main Feb 18, 2026
103 of 106 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-VM-coreclr community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments