[NativeAOT-LLVM] [Question] CORINFO_HELP_READYTORUN_DELEGATE_CTOR implementation

[yowl]

When compiling

runtimelab/src/coreclr/nativeaot/System.Private.TypeLoader/src/Internal/Reflection/Execution/AssemblyBinderImplementation.cs

Lines 28 to 32 in 4fe7f4e

	private AssemblyBinderImplementation()
	{
	_scopeGroups = new KeyValuePair<RuntimeAssemblyName, ScopeDefinitionGroup>[0];
	ModuleList.AddModuleRegistrationCallback(RegisterModule);
	}

AddModuleRegistrationCallback accepts a Action<ModuleInfo> and so will call the helper CORINFO_HELP_READYTORUN_DELEGATE_CTOR .

For the helper CORINFO_HELP_READYTORUN_DELEGATE_CTOR , if I ask for the symbol name from its call->gtEntryPoint.handle I'll get something like:

__DelegateCtor_S_P_CoreLib_System_Delegate__InitializeClosedInstance__S_P_TypeLoader_Internal_Reflection_Execution_AssemblyBinderImplementation__RegisterModule

I'd then have to write out an implementation for this ( which I believe we don't currently have), that would go on to call S_P_CoreLib_System_Delegate__InitializeClosedInstance I suppose.

My question is, should I do that? I ask because the IL implementation for the ctor in AssemblyBinderImplementation would directly call S_P_CoreLib_System_Delegate__InitializeClosedInstance without the need for a __DelegateCtor_S_P_CoreLib_System_Delegate__InitializeClosedInstance__S_P_TypeLoader_Internal_Reflection_Execution_AssemblyBinderImplementation__RegisterModule .

Thanks

[jkotas]

I ask because the IL implementation for the ctor in AssemblyBinderImplementation would directly call S_P_CoreLib_System_Delegate__InitializeClosedInstance

I think you would need to inline it in the importer in fgOptimizeDelegateConstructor to make this work. Is it what you meant? It sounds good to me. It may improve the nativeaot non-wasm path as well.