Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NativeAOT-LLVM: package publishing broken #2539

Closed
yowl opened this issue Apr 1, 2024 · 12 comments
Closed

NativeAOT-LLVM: package publishing broken #2539

yowl opened this issue Apr 1, 2024 · 12 comments
Labels
area-NativeAOT-LLVM LLVM generation for Native AOT compilation (including Web Assembly)

Comments

@yowl
Copy link
Contributor

yowl commented Apr 1, 2024

HI @jkotas, could you please post the current package publishing error, the merge has broken it again?

Thanks,

@jkotas
Copy link
Member

jkotas commented Apr 2, 2024

It is failing with

image

I do not think that it was broken by the merge.

We are required to switch to standardized YAML templates, and it looks like that the branches that have not switched yet fail the official builds now.

@agocke Could you please confirm that the above error is caused by missing official templates?

If it is the case, the fix is going to be to take another merge to pick up changes like dotnet/runtime#99433 and then fix things up.

@jkotas jkotas added the area-NativeAOT-LLVM LLVM generation for Native AOT compilation (including Web Assembly) label Apr 2, 2024
@yowl
Copy link
Contributor Author

yowl commented Apr 6, 2024

I've started the next merge, as mentioned above, there are yml changes. Will we be able to swtich to these new jobs do you think:

          - template: /eng/pipelines/common/platform-matrix.yml
            parameters:
              jobTemplate: /eng/pipelines/common/global-build-job.yml
              helixQueuesTemplate: /eng/pipelines/coreclr/templates/helix-queues-setup.yml
              buildConfig: checked
              platforms:
              - linux_x64
              - windows_x64
              - Browser_wasm_win
              - wasi_wasm_win
              jobParameters:
                timeoutInMinutes: 300
                buildArgs: -s clr.aot+libs+nativeaot.packages -c debug -rc $(_BuildConfig)
                postBuildSteps:
                  - template: /eng/pipelines/common/templates/runtimes/build-runtime-tests-and-send-to-helix.yml
                    parameters:
                      creator: dotnet-bot
                      testRunNamePrefixSuffix: CoreCLR_$(_BuildConfig)

i.e. the helix-queues-setup.yml and build-runtime-tests-and-send-to-helix.yml? I will try global-build-job.yml to see how it goes.

@jkotas
Copy link
Member

jkotas commented Apr 6, 2024

global-build-job.yml and helix-queues-setup.yml look reusable I am not 100% sure about build-runtime-tests-and-send-to-helix.yml

@SingleAccretion
Copy link

SingleAccretion commented Apr 6, 2024

Note: we don't use helix for tests (the tests are run on the build machines).

@agocke
Copy link
Member

agocke commented Apr 16, 2024

Yup the above issue is caused by the switch to internal builds.

I'm happy to fix up the internal pipeline, but we need to get the public pipeline swapped over. Most important is to just get a merge from runtime-main. I can probably take it from there.

@yowl
Copy link
Contributor Author

yowl commented Apr 24, 2024

@jkotas I think it should have published by now, but hasn't, would you mind seeing what the error is please?

@jkotas
Copy link
Member

jkotas commented Apr 24, 2024

I talked to @agocke earlier today and he is going to take it from here to fix this up. (It may require reconfiguring AzDo in addition to editing the checked-in ymls.)

@jkotas
Copy link
Member

jkotas commented Apr 27, 2024

Almost there! After #2563, the publish is failing with:

D:\a_work\1\s.packages\microsoft.dotnet.arcade.sdk\9.0.0-beta.24224.2\tools\SdkTasks\PublishArtifactsInManifest.proj(136,5): error : Asset 'runtime.win-x64.Microsoft.DotNet.ILCompiler.LLVM' is specified twice in the build information. Assets should not be duplicated.

The problem is that runtime.win-x64.Microsoft.DotNet.ILCompiler.LLVM is built by both windows-x64/BuildProduct and browser-wasm/Build host packages steps. @yowl @SingleAccretion How is it expected to work?

@jkotas
Copy link
Member

jkotas commented Apr 27, 2024

#2566 should fix it.

@jkotas
Copy link
Member

jkotas commented Apr 27, 2024

Packages published successfully (Microsoft.DotNet.ILCompiler.LLVM 9.0.0-preview.4.24227.1)!

@SingleAccretion
Copy link

I just tested the packages on our hello world sample and they work. I think this can be closed. Thanks everyone!

@yowl
Copy link
Contributor Author

yowl commented Apr 28, 2024

Thanks all!

@yowl yowl closed this as completed Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-NativeAOT-LLVM LLVM generation for Native AOT compilation (including Web Assembly)
Projects
None yet
Development

No branches or pull requests

4 participants