Skip to content

Commit c0f9732

Browse files
committed
typo: hander -> handler
Related to dotnet/dotnet-api-docs#2155
1 parent 62956bc commit c0f9732

File tree

10 files changed

+20
-20
lines changed

10 files changed

+20
-20
lines changed

machine-learning/tutorials/GitHubIssueClassification/Data/issues_test.tsv

Lines changed: 3 additions & 3 deletions
Large diffs are not rendered by default.

machine-learning/tutorials/GitHubIssueClassification/Data/issues_train.tsv

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10872,7 +10872,7 @@ ID Area Title Description
1087210872
21367 area-System.Drawing Properly dispose of all resources in System.Drawing tests I think the resources will be finalized, but this is good practice and it was mentioned this should be done
1087310873
21368 area-System.Runtime Reenable test in System.Runtime.InteropServices for ILC Api is now implemented. Fixes https://github.com/dotnet/corefx/issues/20600
1087410874
21371 area-System.Net Faster SslStream SslStream apparently shows up as bottleneck in server-side scenarios. Info from @davidfowl offline: * Benchmarks observed: TechEmpower benchmark - see [results](https://msit.powerbi.com/view?r=eyJrIjoiMzFiNDdjNWEtODRiZS00ZDM3LTg4YWEtMGQ3OWQ2ZTc3MDUyIiwidCI6IjcyZjk4OGJmLTg2ZjEtNDFhZi05MWFiLTJkN2NkMDExZGI0NyIsImMiOjV9) * PlainText (with pipelining): 1.31M RPS * PlainText with Https (with pipelining): 156K RPS ... clear large ~10x overhead at this moment * [HttpsConnectionAdapter code](https://github.com/aspnet/KestrelHttpServer/blob/c83f606b220714fa7b1b6a6a91b16d78cee6005f/src/Microsoft.AspNetCore.Server.Kestrel.Https/HttpsConnectionAdapter.cs) in Kestrel * Idea: Compare SSL slowdown in competing technologies (incl. C) to get the idea where it could be potentially pushed.
10875-
21373 area-System.Net Fix DefaultProxyCredentials edge case on NETFX After my PR #21325, I discovered an edge case where we need to check for a non-null Proxy property in the underlying WebRequest. On .NET Framework, System.Net.Http is built on WebRequest (HttpWebRequest) and is subject to side-affects from it. The static property WebRequest.DefaultWebProxy affects the initial value of WebRequest.Proxy. So, it's possible that a developer may have set WebRequest.DefaultWebProxy to null prior to using System.Net.Http in the app. The net affect of this is that there won't be any proxy used as the system default proxy and thus the HttpClientHandler.DefaultProxyCredentials is ignored. On .NET Core, there is no relationship between System.Net.Http and System.Net.WebRequest. So, in all cases on .NET Core, where a developer has specified HttpClientHander.UseProxy=true and HttpClientHandler.Proxy = null (default values), the handler will always try to use the system default proxy (if configured).
10875+
21373 area-System.Net Fix DefaultProxyCredentials edge case on NETFX After my PR #21325, I discovered an edge case where we need to check for a non-null Proxy property in the underlying WebRequest. On .NET Framework, System.Net.Http is built on WebRequest (HttpWebRequest) and is subject to side-affects from it. The static property WebRequest.DefaultWebProxy affects the initial value of WebRequest.Proxy. So, it's possible that a developer may have set WebRequest.DefaultWebProxy to null prior to using System.Net.Http in the app. The net affect of this is that there won't be any proxy used as the system default proxy and thus the HttpClientHandler.DefaultProxyCredentials is ignored. On .NET Core, there is no relationship between System.Net.Http and System.Net.WebRequest. So, in all cases on .NET Core, where a developer has specified HttpClientHandler.UseProxy=true and HttpClientHandler.Proxy = null (default values), the handler will always try to use the system default proxy (if configured).
1087610876
21376 area-System.Runtime Fix failing System.Runtime.Interop.Tests on ILC "Fixes https://github.com/dotnet/corefx/issues/21348 Override all the remaining Reflection apis whose default implementation is ""throw"". This will increase the chance of success in the cases where the two CoreLib's have different dependencies on Reflection objects passed into them. We actually try very hard to avoid these but there are some cases where the cost of doing that is too high - CustomAttributeExtensions being one of them."
1087710877
21377 area-System.Runtime InternalTestAotSubset is failing in ILC x86 only ``` Assert.Same() Failure\r\nExpected: \r\nActual: Stack Trace : at System.Tests.StringTests.InternalTestAotSubset() at xunit.console.netcore!<BaseAddress>+0xb808d1 at SharedLibrary!<BaseAddress>+0x7626f3 at SharedLibrary!<BaseAddress>+0x7624f3 ``` @AtsushiKan this is your test. Seems 32 bit specific?
1087810878
21379 area-System.Runtime BinarySearchSZArray tests failing in ILC ``` BinarySearch_SZArray<Int16>(array: [-32768, 0, 0, 32767], index: 0, length: 1, value: -32768, comparer: null, expected: 0) BinarySearch_SZArray<Int16>(array: [-32768, 0, 0, 32767], index: 0, length: 4, value: -32768, comparer: null, expected: 0) BinarySearch_SZArray<Int16>(array: [-32768, 0, 0, 32767], index: 1, length: 3, value: -32768, comparer: null, expected: -2) BinarySearch_SZArray<SByte>(array: [-128, 0, 0, 127], index: 0, length: 1, value: -128, comparer: null, expected: 0) BinarySearch_SZArray<SByte>(array: [-128, 0, 0, 127], index: 0, length: 4, value: -128, comparer: null, expected: 0) BinarySearch_SZArray<SByte>(array: [-128, 0, 0, 127], index: 1, length: 3, value: -128, comparer: null, expected: -2) IndexOf_SZArray<ArrayTests+Int16Enum>(array: [Min], value: Min, startIndex: 0, count: 1, expected: 0) ``` https://mc.dot.net/#/product/netcore/master/source/official~2Fcorefx~2Fmaster~2F/type/test~2Ffunctional~2Filc~2F/build/20170622.02/workItem/System.Runtime.Tests.Execution eg https://mc.dot.net/#/product/netcore/master/source/official~2Fcorefx~2Fmaster~2F/type/test~2Ffunctional~2Filc~2F/build/20170622.02/workItem/System.Runtime.Tests.Execution/analysis/xunit/System.Tests.ArrayTests~2FBinarySearch_SZArray%3CInt16%3E(array:%20%5B-32768,%200,%200,%2032767%5D,%20index:%200,%20length:%201,%20value:%20-32768,%20comparer:%20null,%20expected:%200) @joshfree can you please assign to a dev on your side.

snippets/csharp/VS_Snippets_CFX/s_ueexceptionhandler/cs/program.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ class Program
3232
// <snippet1>
3333
static void Main(string[] args)
3434
{
35-
// Create an instance of the MyExceptionHander class.
35+
// Create an instance of the MyExceptionHandler class.
3636
MyExceptionHandler thisExceptionHandler =
3737
new MyExceptionHandler();
3838

snippets/csharp/VS_Snippets_VBCSharp/csProgGuideDelegates/CS/Delegates.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -430,7 +430,7 @@ public Form1()
430430

431431
}
432432

433-
// Event hander for any event with an EventArgs or
433+
// Event handler for any event with an EventArgs or
434434
// derived class in the second parameter
435435
private void MultiHandler(object sender, System.EventArgs e)
436436
{
@@ -721,4 +721,4 @@ The Unicode Standard 2.0
721721
*/
722722
//</Snippet12>
723723
}
724-
}
724+
}

snippets/csharp/VS_Snippets_VBCSharp/csvariance/cs/form1.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ public partial class Form1 : Form
1515
Label label1 = new Label();
1616
Button button1 = new Button();
1717
//<Snippet200>
18-
// Event hander that accepts a parameter of the EventArgs type.
18+
// Event handler that accepts a parameter of the EventArgs type.
1919
private void MultiHandler(object sender, System.EventArgs e)
2020
{
2121
label1.Text = System.DateTime.Now.ToString();
@@ -70,4 +70,4 @@ static void Test()
7070
}
7171
//</Snippet201>
7272

73-
}
73+
}

snippets/csharp/VS_Snippets_Wpf/CommandingOverviewSnippets/CSharp/Window1.xaml.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ private void CanExecuteCustomCommand(object sender,
189189
//</SnippetCommandingOverviewCanExecute>
190190

191191

192-
//<SnippetCommandingOverviewMultipleCmdHander>
192+
//<SnippetCommandingOverviewMultipleCmdHandler>
193193
private void ExecutedDisplayCommand(object sender,
194194
ExecutedRoutedEventArgs e)
195195
{
@@ -211,7 +211,7 @@ private void ExecutedDisplayCommand(object sender,
211211
}
212212
}
213213
}
214-
//</SnippetCommandingOverviewMultipleCmdHander>
214+
//</SnippetCommandingOverviewMultipleCmdHandler>
215215

216216
//<SnippetCommandingOverviewMultipleCanExecute>
217217
private void CanExecuteDisplayCommand(object sender,
@@ -383,4 +383,4 @@ private void DoEvent(object e)
383383
public delegate string NoArgDelegate();
384384
}
385385
//</SnippetThreadingArticleWeatherComponent2>
386-
}
386+
}

snippets/visualbasic/VS_Snippets_CFX/s_ueexceptionhandler/vb/module1.vb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ Namespace CS
2929
Module Module1
3030
' <snippet1>
3131
Sub Main(ByVal args() As String)
32-
' Create an instance of the MyExceptionHander class.
32+
' Create an instance of the MyExceptionHandler class.
3333
Dim thisExceptionHandler As New MyExceptionHandler()
3434

3535
' Enable the custom handler by setting

snippets/visualbasic/VS_Snippets_CLR/portableclasslibrarymvvm/vb/relaycommand.vb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ Namespace SimpleMVVM.ViewModel
99
Private _isEnabled As Boolean
1010
Private ReadOnly _handler As Action
1111

12-
Public Sub New(ByVal hander As Action)
13-
_handler = hander
12+
Public Sub New(ByVal handler As Action)
13+
_handler = handler
1414
End Sub
1515

1616
Public Event CanExecuteChanged As EventHandler Implements ICommand.CanExecuteChanged
@@ -37,4 +37,4 @@ Namespace SimpleMVVM.ViewModel
3737

3838
End Class
3939
End Namespace
40-
' </snippet4>
40+
' </snippet4>

snippets/visualbasic/VS_Snippets_VBCSharp/csvariance/vb/form1.vb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
Dim Button1 As Button
44

55
'<Snippet200>
6-
' Event hander that accepts a parameter of the EventArgs type.
6+
' Event handler that accepts a parameter of the EventArgs type.
77
Private Sub MultiHandler(ByVal sender As Object,
88
ByVal e As System.EventArgs)
99
Label1.Text = DateTime.Now

snippets/visualbasic/VS_Snippets_Wpf/CommandingOverviewSnippets/visualbasic/window1.xaml.vb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ Namespace SDKSamples
164164
'</SnippetCommandingOverviewCanExecute>
165165

166166

167-
'<SnippetCommandingOverviewMultipleCmdHander>
167+
'<SnippetCommandingOverviewMultipleCmdHandler>
168168
Private Sub ExecutedDisplayCommand(ByVal sender As Object, ByVal e As ExecutedRoutedEventArgs)
169169
Dim command As RoutedCommand = TryCast(e.Command, RoutedCommand)
170170

@@ -180,7 +180,7 @@ Namespace SDKSamples
180180
End If
181181
End If
182182
End Sub
183-
'</SnippetCommandingOverviewMultipleCmdHander>
183+
'</SnippetCommandingOverviewMultipleCmdHandler>
184184

185185
'<SnippetCommandingOverviewMultipleCanExecute>
186186
Private Sub CanExecuteDisplayCommand(ByVal sender As Object, ByVal e As CanExecuteRoutedEventArgs)
@@ -325,4 +325,4 @@ Namespace SDKSamples
325325
Public Delegate Function NoArgDelegate() As String
326326
End Class
327327
'</SnippetThreadingArticleWeatherComponent2>
328-
End Namespace
328+
End Namespace

0 commit comments

Comments
 (0)