Skip to content

Remove set accessors from the view model #911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2019
Merged

Remove set accessors from the view model #911

merged 1 commit into from
May 15, 2019

Conversation

@BillWagner
Copy link
Member

The view model can be immutable. This matches the text description (and the intent).

Fixes dotnet/docs#11830

@BillWagner
Remove set accessors from the view model
88a6aef 
The view model can be immutable. This matches the text description (and the intent).
@BillWagner BillWagner requested a review from Thraka May 15, 2019 20:26
rpetrusha
rpetrusha approved these changes May 15, 2019
View reviewed changes
Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @BillWagner. You can merge when you're ready.

@BillWagner BillWagner merged commit 367d40e into dotnet:master May 15, 2019
@BillWagner BillWagner deleted the update-view-model branch May 15, 2019 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Thraka Thraka Awaiting requested review from Thraka

1 more reviewer

@rpetrusha rpetrusha rpetrusha approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Confusing phrase

2 participants

@BillWagner @rpetrusha