Skip to content

Commit 44efda9

Browse files
committed
activities for dnx
1 parent 2bb7e06 commit 44efda9

File tree

2 files changed

+17
-2
lines changed

2 files changed

+17
-2
lines changed

src/Cli/dotnet/Commands/Tool/Execute/ToolExecuteCommand.cs

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,13 +44,20 @@ public override int Execute()
4444
VersionRange versionRange = _parseResult.GetVersionRange();
4545
PackageId packageId = new PackageId(_packageToolIdentityArgument.Id);
4646

47+
var toolLocationActivity = Activities.Source.StartActivity("find-tool");
48+
toolLocationActivity?.SetTag("packageId", packageId.ToString());
49+
toolLocationActivity?.SetTag("versionRange", versionRange?.ToString() ?? "latest");
50+
4751
// Look in local tools manifest first, but only if version is not specified
4852
if (versionRange == null)
4953
{
5054
var localToolsResolverCache = new LocalToolsResolverCache();
5155

5256
if (_toolManifestFinder.TryFindPackageId(packageId, out var toolManifestPackage))
5357
{
58+
toolLocationActivity?.SetTag("kind", "local");
59+
toolLocationActivity?.Stop();
60+
5461
var toolPackageRestorer = new ToolPackageRestorer(
5562
_toolPackageDownloader,
5663
_sources,
@@ -82,10 +89,12 @@ public override int Execute()
8289
additionalFeeds: _addSource);
8390

8491
(var bestVersion, var packageSource) = _toolPackageDownloader.GetNuGetVersion(packageLocation, packageId, _verbosity, versionRange, _restoreActionConfig);
92+
toolLocationActivity?.SetTag("kind", "one-shot");
93+
toolLocationActivity?.Stop();
8594

8695
// TargetFramework is null, which means to use the current framework. Global tools can override the target framework to use (or select assets for),
8796
// but we don't support this for local or one-shot tools.
88-
if (!_toolPackageDownloader.TryGetDownloadedTool(packageId, bestVersion, targetFramework: null, verbosity: _verbosity, out var toolPackage))
97+
if (!_toolPackageDownloader.TryGetDownloadedTool(packageId, bestVersion, targetFramework: null, verbosity: _verbosity, out var toolPackage))
8998
{
9099
if (!UserAgreedToRunFromSource(packageId, bestVersion, packageSource))
91100
{
@@ -119,9 +128,12 @@ public override int Execute()
119128
restoreActionConfig: _restoreActionConfig);
120129
}
121130

131+
using var toolExecuteActivity = Activities.Source.StartActivity("execute-tool");
132+
toolExecuteActivity?.SetTag("packageId", packageId.ToString());
133+
toolExecuteActivity?.SetTag("version", toolPackage.Version.ToString());
134+
toolExecuteActivity?.SetTag("source", toolPackage.Command.Runner);
122135
var commandSpec = ToolCommandSpecCreator.CreateToolCommandSpec(toolPackage.Command.Name.Value, toolPackage.Command.Executable.Value, toolPackage.Command.Runner, _allowRollForward, _forwardArguments);
123136
var command = CommandFactoryUsingResolver.Create(commandSpec);
124-
using var _ = Activities.Source.StartActivity("execute-inline-tool");
125137
var result = command.Execute();
126138
return result.ExitCode;
127139
}

src/Cli/dotnet/InteractiveConsole.cs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
using System.CommandLine;
55
using System.Diagnostics.CodeAnalysis;
66
using Microsoft.DotNet.Cli.Commands;
7+
using Microsoft.DotNet.Cli.Utils;
78

89
namespace Microsoft.DotNet.Cli;
910

@@ -30,6 +31,8 @@ public static class InteractiveConsole
3031
return null;
3132
}
3233

34+
using var _ = Activities.Source.StartActivity("confirm-run-from-source");
35+
3336
Console.Write(AddPromptOptions(message));
3437

3538
while (true)

0 commit comments

Comments
 (0)